[PATCH] (haskeline) Include termios.h on android - ghc-devs - Haskell.org

newer
[PATCH] fixes for android in...

[PATCH] (haskeline) Include termios.h on android

older
Re: [commit: ghc] master: Build...

Nathan Hüsken

25 Jan 2013 25 Jan '13

3:45 a.m.

Hey, This patch is for libraries/haskeline. On android, winsize is defined in termios.h and therefor termios.h must be included.

Attachments:

haskeline_termios.patch (text/x-patch — 989 bytes)

Reply

Sign in to reply online Use email software

Show replies by date

Ian Lynagh

17 Feb 17 Feb

7:42 a.m.

Hi Nathan, On Fri, Jan 25, 2013 at 09:45:47AM +0100, Nathan Hüsken wrote:

This patch is for libraries/haskeline.

Thanks for the patch, although note that haskeline is maintained by Judah Jacobson and has a trac here: http://trac.haskell.org/haskeline

-#ifdef USE_TERMIOS_H +#if defined(USE_TERMIOS_H) || defined(__ANDROID__)

It looks like this would be better handled by defining USE_TERMIOS_H in the .cabal file if the os is android. Thanks Ian

Reply

Sign in to reply online Use email software

Nathan Hüsken

11:01 a.m.

On 02/17/2013 01:42 PM, Ian Lynagh wrote:

Hi Nathan,

On Fri, Jan 25, 2013 at 09:45:47AM +0100, Nathan Hüsken wrote:

...
This patch is for libraries/haskeline. Thanks for the patch, although note that haskeline is maintained by Judah Jacobson and has a trac here: http://trac.haskell.org/haskeline

...
-#ifdef USE_TERMIOS_H +#if defined(USE_TERMIOS_H) || defined(__ANDROID__) It looks like this would be better handled by defining USE_TERMIOS_H in the .cabal file if the os is android.

I agree, but I was unable to detect in tharget os in cabal when cross compiling.

Reply

Sign in to reply online Use email software

Ian Lynagh

11:28 a.m.

On Sun, Feb 17, 2013 at 05:01:45PM +0100, Nathan Hüsken wrote:

On 02/17/2013 01:42 PM, Ian Lynagh wrote:

...
...
-#ifdef USE_TERMIOS_H +#if defined(USE_TERMIOS_H) || defined(__ANDROID__) It looks like this would be better handled by defining USE_TERMIOS_H in the .cabal file if the os is android.

I agree, but I was unable to detect in tharget os in cabal when cross compiling.

Ah, that should be fixed then. It shouldn't be too hard: the "ghc --info" output already includes e.g. ,("target os","OSLinux") and I'm pretty sure that Cabal already parses the --info output, so it should just be a case of using that value when evaluating the os(android) conditional. Ah, hmm, except OSLinux is a constructor of a type that is in the ghc package. Cabal has slightly different types in Distribution.System. Should we make a shared type, possibly in a new 'platform' package? Thanks Ian

Reply

Sign in to reply online Use email software

4475

Age (days ago)

4498

Last active (days ago)

Download

3 comments

2 participants

tags

participants (2)

Ian Lynagh
Nathan Hüsken