Hi Simon,
note that my cis.upenn.edu address will soon vanish with a puff; better
use mail(a)joachim-breitner.de.
Please allow me to respond on-list, I am sure you are not the only one
who is confused by this.
Yes, the relabeling was maybe the biggest mistake in our process:
Proposals first have a number as Pull Request, but when they are
accepted, they get a new, unrelated sequential number. We should have
just re-used the PR number and have non-sequential numbers for accepted
proposals.
I wonder if we can still fix this. Nobody is really using the
“accepted” number, so maybe it is fine?
> Would it be possible to have a single list of all the proposals, with
> their status?
The official list of all accepted proposals is
https://github.com/ghc-proposals/ghc-proposals/tree/master/proposals
And the list for PRs is
https://github.com/ghc-proposals/ghc-proposals/pulls
where you can also filter by label, i.e. status (most links from the
start page go this, with various filters applied).
If someone is eager to do some hacking, one could aggregate all that in
a fancy overview page somewhere (else), but I am hesitant to create
such code, not because it has to be coded (that’s fun), but it has to
be maintained and kept running and understood by everyone.
> It would be v helpful if, for accepted proposals, the link pointed to
> the canonical, final version of the proposal, and gave its canonical
> final number.
You mean a link “Accepted proposal” at the top of the discussion
thread?
Yes, that would be useful; it’s just one more bit of tedious work.
Cheers,
Joachim
Am Dienstag, den 11.06.2019, 07:41 +0000 schrieb Simon Peyton Jones:
> Joachim
> I get very confused about GHC proposals and how to find the “right one”.
> Here’s an example. We have
> Proposal 54: Top-level kind signatures (instead of CUSKs)
> Proposal 36: Top-level kind signatures
> Apparently they are the same. Richard writes
> When a proposal gets proposed, it is a pull request and is assigned a number. After it gets accepted, it is assigned a sequential accepted proposal number. So not-yet-decided proposals are numbered among all such proposals, and accepted proposals are numbered among all such proposals. This is perhaps confusing, but it's what we currently do.
> You can get from an accepted proposal to its pull request by clicking the link at the top of the proposal.
> Joachim often labels the final resting place of PRs; this one appears overlooked. I've added a link.
> I don’t think I’d understood this change of numbering. So I wonder
> Would it be possible to lay out the scheme on the GHC proposal home page somewhere?
> Would it be possible to have a single list of all the proposals, with their status? At the moment, if you scroll around on the home page you can find various lists, but it would really help to bring them together.
> Or, I suppose, two lists: one for PRs and one for accepted proposals. (In each case they may have different labels.)
> It would be v helpful if, for accepted proposals, the link pointed to the canonical, final version of the proposal, and gave its canonical final number.
> We have quite a lot of proposals, which you do a great job of managing. But I get a bit lost sometimes.
> Thanks
> Simon
--
Joachim Breitner
mail(a)joachim-breitner.de
http://www.joachim-breitner.de/
