Re: [ghc-steering-committee] #210: -Wredundant-minimal-methods, recommendation: accept

Hi, great, I’ll marks this as accepted, with "-Wredundant-minimal-methods". Cheers, Joachim Am Montag, den 04.03.2019, 11:41 +0000 schrieb Simon Peyton Jones via ghc-steering-committee:

I'm happy to support this. And yes

Simon

...

-----Original Message----- From: ghc-steering-committee On Behalf Of Joachim Breitner Sent: 02 March 2019 16:17 To: ghc-steering-committee@haskell.org Subject: [ghc-steering-committee] #210: -Wredundant-minimal-methods, recommendation: accept

Dear Committee,

Levent Erkök has proposed to introduce a warning when a type class specifies a methods as definitely requires (via a MINIMAL pragma), but still gives a default implementation: https://github.com/LeventErkok/ghc-proposals/blob/master/proposals/0000- minimal-should-warn-extras.rst

This seems both useful and and harmless to me, so I propose we accept the proposal.

If we want to do some bike shedding: I think -Wredundant-minimal-methods has a better flow than the proposed -Wminimal-redundant-methods After all, we want to be warned about redundancy of minimal methods, not minimality of redundant methods.

Cheers, Simon

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

---

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/