OK by me. Simon From: ghc-steering-committee [mailto:ghc-steering-committee-bounces@haskell.org] On Behalf Of Simon Marlow Sent: 08 January 2018 10:24 To: ghc-steering-committee@haskell.org Subject: [ghc-steering-committee] Proposal: accept "add incomplete-uni-patterns and incomplete-record-updates to -Wall" I propose that we accept the proposal add incomplete-uni-patterns and incomplete-record-updates to -Wall https://github.com/ghc-proposals/ghc-proposals/pull/71 https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F71&data=02%7C01%7Csimonpj%40microsoft.com%7Cd2da9fadb09344ca5f3008d55681f2a8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636510038485583689&sdata=IsXqPTeN1fP1WAIzphuxHjrSCl%2BqtHBtyJXCi1txGgg%3D&reserved=0 https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F71&data=02%7C01%7Csimonpj%40microsoft.com%7Cd2da9fadb09344ca5f3008d55681f2a8%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636510038485583689&sdata=IsXqPTeN1fP1WAIzphuxHjrSCl%2BqtHBtyJXCi1txGgg%3D&reserved=0 Both warnings are avoidable and considered bad style, which makes them appropriate to include in -Wall. The reason that -Wincomplete-uni-patterns wasn't originally made part of -Wall was due to worries about noisiness (https://ghc.haskell.org/trac/ghc/ticket/4905), but that's not a valid concern. -Wall is intentionally a moving target, if you want to stay Wall-clean you accept that new compiler releases may entail some work. Basically I think this is a no-brainer. Cheers Simon

+1

08.01.2018 21:23 Simon Marlow :

I propose that we accept the proposal

add incomplete-uni-patterns and incomplete-record-updates to -Wall

https://github.com/ghc-proposals/ghc-proposals/pull/71 https://github.com/ghc-proposals/ghc-proposals/pull/71

https://github.com/ghc-proposals/ghc-proposals/pull/71 Both warnings are avoidable and considered bad style, which makes them appropriate to include in -Wall.

The reason that -Wincomplete-uni-patterns wasn't originally made part of -Wall was due to worries about noisiness (https://ghc.haskell.org/trac/ghc/ticket/4905 https://ghc.haskell.org/trac/ghc/ticket/4905), but that's not a valid concern. -Wall is intentionally a moving target, if you want to stay Wall-clean you accept that new compiler releases may entail some work.

Basically I think this is a no-brainer.

Cheers Simon

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee