Please review #637: Modify multiline string proposal #569 to remove one trailing newline - ghc-steering-committee - Haskell.org

newer
Please review #570: Native...

Please review #637: Modify multiline string proposal #569 to remove one trailing newline

older
Dealing with abuse on the issue...

Adam Gundry

16 Jul 2024 16 Jul '24

3:19 a.m.

Dear Committee, Brandon Chinn proposes to amend the multiline string literal proposal #569 to remove one trailing newline: https://github.com/ghc-proposals/ghc-proposals/pull/637 I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of #569. Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process Cheers, Adam -- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

Reply

Sign in to reply online Use email software

Show replies by date

Eric Seidel

28 Jul 28 Jul

12:32 p.m.

Dear Committee, Brandon has proposed an amendment to his previous multiline string proposal. https://github.com/ghc-proposals/ghc-proposals/pull/637 The change is to strip one trailing newline from the lexed string, meaning that a multiline string like """ hello world """ would actually lex as "hello\nworld". He makes a compelling case that this behavior is more compositional. I recommend acceptance. This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections. Eric On Tue, Jul 16, 2024, at 02:19, Adam Gundry wrote:

Dear Committee,

Brandon Chinn proposes to amend the multiline string literal proposal #569 to remove one trailing newline:

https://github.com/ghc-proposals/ghc-proposals/pull/637

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of #569.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

Malte Ott

12:46 p.m.

On 2024-07-28 11:32, Eric Seidel wrote:

He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

I agree, this sounds like an improvement.

Reply

Sign in to reply online Use email software

Matthías Páll Gissurarson

3:23 p.m.

Sounds like a good improvement. Accept. /Matti Palli On Sun, Jul 28, 2024 at 18:46 Malte Ott wrote:

On 2024-07-28 11:32, Eric Seidel wrote:

...
He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

I agree, this sounds like an improvement. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

Jakob Brünker

4:29 p.m.

Seems like a good change to me. Jakob On Sun, Jul 28, 2024 at 9:23 PM Matthías Páll Gissurarson wrote:

Sounds like a good improvement. Accept.

/Matti Palli

On Sun, Jul 28, 2024 at 18:46 Malte Ott wrote:

...
On 2024-07-28 11:32, Eric Seidel wrote:

...
He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

I agree, this sounds like an improvement. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

Moritz Angermann

8:27 p.m.

Sounds reasonable! 2024년 7월 29일 (월) 오전 5:29, Jakob Brünker 님이 작성:

Seems like a good change to me.

Jakob

On Sun, Jul 28, 2024 at 9:23 PM Matthías Páll Gissurarson wrote:

...
Sounds like a good improvement. Accept.

/Matti Palli

On Sun, Jul 28, 2024 at 18:46 Malte Ott wrote:

...
On 2024-07-28 11:32, Eric Seidel wrote:

...
He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

I agree, this sounds like an improvement. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

Arnaud Spiwack

29 Jul 29 Jul

3:28 a.m.

I'm in favour as well. On Mon, 29 Jul 2024 at 02:28, Moritz Angermann wrote:

Sounds reasonable!

2024년 7월 29일 (월) 오전 5:29, Jakob Brünker 님이 작성:

...
Seems like a good change to me.

Jakob

On Sun, Jul 28, 2024 at 9:23 PM Matthías Páll Gissurarson wrote:

...
Sounds like a good improvement. Accept.

/Matti Palli

On Sun, Jul 28, 2024 at 18:46 Malte Ott wrote:

...
On 2024-07-28 11:32, Eric Seidel wrote:

...
He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

I agree, this sounds like an improvement. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io.

Reply

Sign in to reply online Use email software

Erik de Castro Lopo

3:51 a.m.

:thumbsup: from me. Arnaud Spiwack wrote:

I'm in favour as well.

On Mon, 29 Jul 2024 at 02:28, Moritz Angermann wrote:

...
Sounds reasonable!

2024년 7월 29일 (월) 오전 5:29, Jakob Brünker 님이 작성:

...
Seems like a good change to me.

Jakob

On Sun, Jul 28, 2024 at 9:23 PM Matthías Páll Gissurarson wrote:

...
Sounds like a good improvement. Accept.

/Matti Palli

On Sun, Jul 28, 2024 at 18:46 Malte Ott wrote:

...
On 2024-07-28 11:32, Eric Seidel wrote:

...
He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

I agree, this sounds like an improvement. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io.

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Reply

Sign in to reply online Use email software

Simon Peyton Jones

5:19 a.m.

I'm in support. Simon On Sun, 28 Jul 2024 at 17:32, Eric Seidel wrote:

Dear Committee,

Brandon has proposed an amendment to his previous multiline string proposal.

https://github.com/ghc-proposals/ghc-proposals/pull/637

The change is to strip one trailing newline from the lexed string, meaning that a multiline string like

""" hello world """

would actually lex as "hello\nworld".

He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

Eric

On Tue, Jul 16, 2024, at 02:19, Adam Gundry wrote:

...
Dear Committee,

Brandon Chinn proposes to amend the multiline string literal proposal #569 to remove one trailing newline:

https://github.com/ghc-proposals/ghc-proposals/pull/637

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of #569.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

Sebastian Graf

2:06 p.m.

+1 Am Mo., 29. Juli 2024 um 11:19 Uhr schrieb Simon Peyton Jones < simon.peytonjones@gmail.com>:

I'm in support.

Simon

On Sun, 28 Jul 2024 at 17:32, Eric Seidel wrote:

...
Dear Committee,

Brandon has proposed an amendment to his previous multiline string proposal.

https://github.com/ghc-proposals/ghc-proposals/pull/637

The change is to strip one trailing newline from the lexed string, meaning that a multiline string like

""" hello world """

would actually lex as "hello\nworld".

He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

Eric

On Tue, Jul 16, 2024, at 02:19, Adam Gundry wrote:

...
Dear Committee,

Brandon Chinn proposes to amend the multiline string literal proposal #569 to remove one trailing newline:

https://github.com/ghc-proposals/ghc-proposals/pull/637

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of #569.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

Eric Seidel

4 Aug 4 Aug

2:39 p.m.

Ok, we have support from everyone except Adam and Simon M, who haven't responded. I think that's good enough, I declare the amendedment accepted. On Mon, Jul 29, 2024, at 13:06, Sebastian Graf wrote:

+1

Am Mo., 29. Juli 2024 um 11:19 Uhr schrieb Simon Peyton Jones :

...
I'm in support.

Simon

On Sun, 28 Jul 2024 at 17:32, Eric Seidel wrote:

...
Dear Committee,

Brandon has proposed an amendment to his previous multiline string proposal.

https://github.com/ghc-proposals/ghc-proposals/pull/637

The change is to strip one trailing newline from the lexed string, meaning that a multiline string like

""" hello world """

would actually lex as "hello\nworld".

He makes a compelling case that this behavior is more compositional. I recommend acceptance.

This is a tiny change, so I'll give us a week for review and will declare the amendment accepted next weekend barring any objections.

Eric

On Tue, Jul 16, 2024, at 02:19, Adam Gundry wrote:

...
Dear Committee,

Brandon Chinn proposes to amend the multiline string literal proposal #569 to remove one trailing newline:

https://github.com/ghc-proposals/ghc-proposals/pull/637

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of #569.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Reply

Sign in to reply online Use email software

289

Age (days ago)

308

Last active (days ago)

Download

10 comments

10 participants

tags

participants (10)

Adam Gundry
Arnaud Spiwack
Eric Seidel
Erik de Castro Lopo
Jakob Brünker
Malte Ott
Matthías Páll Gissurarson
Moritz Angermann
Sebastian Graf
Simon Peyton Jones