Re: [ghc-steering-committee] [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246)
Dear Steering Committee I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review. Matthew has revised his proposal #246 Overloaded Quotations<https://github.com/mpickering/ghc-proposals/blob/overloaded-proposal/proposals/0000-overloaded-bracket.rst>. One particular point is that it does explicitly apply to Typed Template Haskell, not just untyped (see “Proposed changes” item 6). Moreover he has an implementation here: https://gitlab.haskell.org/ghc/ghc/merge_requests/2247 I recommended back in Nov that we accept (see attached email), but I asked him to make some revisions (as you can see in the discussion thread). All of this connects to (and I believe is compatible with) #195 (make Q (TExp a) into a newtype),<https://github.com/ghc-proposals/ghc-proposals/pull/195> which we are set to accept too, once the proposal is revised. Iavor: you are the shepherd for that. I’ve had support for acceptance from * Joachim * Eric * Sandy * Simon M * Richard * Arnaud * Iavor I would love to hear from * Chris A * Vitaly B Others: reply only if you have any comments on the revised proposal. I’ll accept this at the end of the week. Simon From: Matthew Pickering <notifications@github.com> Sent: 04 December 2019 13:58 To: ghc-proposals/ghc-proposals <ghc-proposals@noreply.github.com> Cc: Simon Peyton Jones <simonpj@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246) I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F246%3Femail_source%3Dnotifications%26email_token%3DAAEOY636NCRXHIEMMDRTHBTQW6ZNTA5CNFSM4H5HNWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5DHLQ%23issuecomment-561656750&data=02%7C01%7Csimonpj%40microsoft.com%7C6cfb80518ac74d06153508d778c1f133%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110646683835630&sdata=tCNZ5ALBG81l%2FJGwoX9p6jBLIPZqKJCjPNyrlG89Bh4%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEOY62KELEHCDTSD4HEI73QW6ZNTANCNFSM4H5HNWRQ&data=02%7C01%7Csimonpj%40microsoft.com%7C6cfb80518ac74d06153508d778c1f133%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110646683835630&sdata=EFWou3zjc86I%2BW8HPXHIkzqnHpfNsApjNvMqKV2yZ0M%3D&reserved=0>.
Well, my response did have a question in it. Did anyone have any thoughts? On Wed, Dec 4, 2019 at 7:24 AM Simon Peyton Jones via ghc-steering-committee <ghc-steering-committee@haskell.org> wrote:
Dear Steering Committee
I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review.
Matthew has revised his proposal #246 Overloaded Quotations <https://github.com/mpickering/ghc-proposals/blob/overloaded-proposal/proposals/0000-overloaded-bracket.rst>. One particular point is that it does explicitly apply to Typed Template Haskell, not just untyped (see “Proposed changes” item 6).
Moreover he has an implementation here: https://gitlab.haskell.org/ghc/ghc/merge_requests/2247
I recommended back in Nov that we accept (see attached email), but I asked him to make some revisions (as you can see in the discussion thread). All of this connects to (and I believe is compatible with) #195 (make Q (TExp a) into a newtype), <https://github.com/ghc-proposals/ghc-proposals/pull/195> which we are set to accept too, once the proposal is revised. Iavor: you are the shepherd for that.
I’ve had support for acceptance from
- Joachim - Eric - Sandy - Simon M - Richard - Arnaud - Iavor
I would love to hear from
- Chris A - Vitaly B
Others: reply only if you have any comments on the revised proposal. I’ll accept this at the end of the week.
Simon
*From:* Matthew Pickering <notifications@github.com> *Sent:* 04 December 2019 13:58 *To:* ghc-proposals/ghc-proposals <ghc-proposals@noreply.github.com> *Cc:* Simon Peyton Jones <simonpj@microsoft.com>; Mention < mention@noreply.github.com> *Subject:* Re: [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246)
I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F246%3Femail_source%3Dnotifications%26email_token%3DAAEOY636NCRXHIEMMDRTHBTQW6ZNTA5CNFSM4H5HNWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5DHLQ%23issuecomment-561656750&data=02%7C01%7Csimonpj%40microsoft.com%7C6cfb80518ac74d06153508d778c1f133%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110646683835630&sdata=tCNZ5ALBG81l%2FJGwoX9p6jBLIPZqKJCjPNyrlG89Bh4%3D&reserved=0>, or unsubscribe <https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEOY62KELEHCDTSD4HEI73QW6ZNTANCNFSM4H5HNWRQ&data=02%7C01%7Csimonpj%40microsoft.com%7C6cfb80518ac74d06153508d778c1f133%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110646683835630&sdata=EFWou3zjc86I%2BW8HPXHIkzqnHpfNsApjNvMqKV2yZ0M%3D&reserved=0> . _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
I think you mean The issue is that `Code a` is not `Applicative`, because we cannot define `pure` for all Haskell types. I wonder if the full power of `Applicative` is actually needed to do the translation though? If not, perhaps we should modify `Quote` to reflect the operations that we need. Is that it? Could you ask on the discussion thread, so that Matthew can respond? I actually don’t quite understand the question. Simon From: Iavor Diatchki <iavor.diatchki@gmail.com> Sent: 04 December 2019 15:35 To: Simon Peyton Jones <simonpj@microsoft.com> Cc: ghc-steering-committee@haskell.org Subject: Re: [ghc-steering-committee] [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246) Well, my response did have a question in it. Did anyone have any thoughts? On Wed, Dec 4, 2019 at 7:24 AM Simon Peyton Jones via ghc-steering-committee <ghc-steering-committee@haskell.org<mailto:ghc-steering-committee@haskell.org>> wrote: Dear Steering Committee I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review. Matthew has revised his proposal #246 Overloaded Quotations<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmpickering%2Fghc-proposals%2Fblob%2Foverloaded-proposal%2Fproposals%2F0000-overloaded-bracket.rst&data=02%7C01%7Csimonpj%40microsoft.com%7C6ea14a87a5724819166708d778cf7c89%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110704852522992&sdata=FhL8LEwt00Yk0HLISSJguj3BSrL2YAK9hEzdC%2B%2FwO%2Fg%3D&reserved=0>. One particular point is that it does explicitly apply to Typed Template Haskell, not just untyped (see “Proposed changes” item 6). Moreover he has an implementation here: https://gitlab.haskell.org/ghc/ghc/merge_requests/2247<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.haskell.org%2Fghc%2Fghc%2Fmerge_requests%2F2247&data=02%7C01%7Csimonpj%40microsoft.com%7C6ea14a87a5724819166708d778cf7c89%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110704852532990&sdata=LWPVx%2B5DLEQ0GPEL9eWZ%2FzrkeaVbiUuUQCZMjY92QOQ%3D&reserved=0> I recommended back in Nov that we accept (see attached email), but I asked him to make some revisions (as you can see in the discussion thread). All of this connects to (and I believe is compatible with) #195 (make Q (TExp a) into a newtype),<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F195&data=02%7C01%7Csimonpj%40microsoft.com%7C6ea14a87a5724819166708d778cf7c89%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110704852532990&sdata=dwR6samDLQdPucK%2FnjOnasNhzRZ1nUp73DU7SGn8CvU%3D&reserved=0> which we are set to accept too, once the proposal is revised. Iavor: you are the shepherd for that. I’ve had support for acceptance from * Joachim * Eric * Sandy * Simon M * Richard * Arnaud * Iavor I would love to hear from * Chris A * Vitaly B Others: reply only if you have any comments on the revised proposal. I’ll accept this at the end of the week. Simon From: Matthew Pickering <notifications@github.com<mailto:notifications@github.com>> Sent: 04 December 2019 13:58 To: ghc-proposals/ghc-proposals <ghc-proposals@noreply.github.com<mailto:ghc-proposals@noreply.github.com>> Cc: Simon Peyton Jones <simonpj@microsoft.com<mailto:simonpj@microsoft.com>>; Mention <mention@noreply.github.com<mailto:mention@noreply.github.com>> Subject: Re: [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246) I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F246%3Femail_source%3Dnotifications%26email_token%3DAAEOY636NCRXHIEMMDRTHBTQW6ZNTA5CNFSM4H5HNWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5DHLQ%23issuecomment-561656750&data=02%7C01%7Csimonpj%40microsoft.com%7C6ea14a87a5724819166708d778cf7c89%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110704852542984&sdata=uajvJO%2F%2Fya4oc3woIHd3lnojErEzV9bT2DyAR2%2FeX%2B0%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEOY62KELEHCDTSD4HEI73QW6ZNTANCNFSM4H5HNWRQ&data=02%7C01%7Csimonpj%40microsoft.com%7C6ea14a87a5724819166708d778cf7c89%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110704852542984&sdata=GwKp2yhSiEya6pJunHkfD5JfQC6xJSruH8MCbYmj5GM%3D&reserved=0>. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org<mailto:ghc-steering-committee@haskell.org> https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmail.haskell.org%2Fcgi-bin%2Fmailman%2Flistinfo%2Fghc-steering-committee&data=02%7C01%7Csimonpj%40microsoft.com%7C6ea14a87a5724819166708d778cf7c89%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110704852552978&sdata=MTCwiGj%2BCyvkLYZj35bZJkR%2Bgm1ClIxKo1TEQvvPo9s%3D&reserved=0>
Yes that was it---I posted on #246 and Matt clarified what the plan was, so I am on board. On Wed, Dec 4, 2019 at 7:39 AM Simon Peyton Jones <simonpj@microsoft.com> wrote:
I think you mean
The issue is that `Code a` is not `Applicative`, because we cannot
define `pure` for all Haskell types. I wonder if the full power of
`Applicative` is actually needed to do the translation though? If not, perhaps we should modify `Quote` to reflect the operations that we need.
Is that it? Could you ask on the discussion thread, so that Matthew can respond? I actually don’t quite understand the question.
Simon
From: Iavor Diatchki <iavor.diatchki@gmail.com> Sent: 04 December 2019 15:35 To: Simon Peyton Jones <simonpj@microsoft.com> Cc: ghc-steering-committee@haskell.org Subject: Re: [ghc-steering-committee] [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246)
Well, my response did have a question in it. Did anyone have any thoughts?
On Wed, Dec 4, 2019 at 7:24 AM Simon Peyton Jones via ghc-steering-committee <ghc-steering-committee@haskell.org> wrote:
Dear Steering Committee
I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review.
Matthew has revised his proposal #246 Overloaded Quotations. One particular point is that it does explicitly apply to Typed Template Haskell, not just untyped (see “Proposed changes” item 6).
Moreover he has an implementation here: https://gitlab.haskell.org/ghc/ghc/merge_requests/2247
I recommended back in Nov that we accept (see attached email), but I asked him to make some revisions (as you can see in the discussion thread). All of this connects to (and I believe is compatible with) #195 (make Q (TExp a) into a newtype), which we are set to accept too, once the proposal is revised. Iavor: you are the shepherd for that.
I’ve had support for acceptance from
Joachim Eric Sandy Simon M Richard Arnaud Iavor
I would love to hear from
Chris A Vitaly B
Others: reply only if you have any comments on the revised proposal. I’ll accept this at the end of the week.
Simon
From: Matthew Pickering <notifications@github.com> Sent: 04 December 2019 13:58 To: ghc-proposals/ghc-proposals <ghc-proposals@noreply.github.com> Cc: Simon Peyton Jones <simonpj@microsoft.com>; Mention <mention@noreply.github.com> Subject: Re: [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246)
I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
Nothing from Vitaly B or Chris A. I declare the proposal accepted. Joachim, can you merge please? Simon From: Simon Peyton Jones <simonpj@microsoft.com> Sent: 04 December 2019 15:24 To: ghc-steering-committee@haskell.org Cc: Simon Peyton Jones <simonpj@microsoft.com> Subject: RE: [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246) Dear Steering Committee I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review. Matthew has revised his proposal #246 Overloaded Quotations<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fmpickering%2Fghc-proposals%2Fblob%2Foverloaded-proposal%2Fproposals%2F0000-overloaded-bracket.rst&data=02%7C01%7Csimonpj%40microsoft.com%7C7a0ac32c2fcc4d92ea5508d778ce051a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110699587244274&sdata=I0tNA6zLF%2BuduEvm1T0kXcCGDtgEx7h1wa0xgGeHyRQ%3D&reserved=0>. One particular point is that it does explicitly apply to Typed Template Haskell, not just untyped (see "Proposed changes" item 6). Moreover he has an implementation here: https://gitlab.haskell.org/ghc/ghc/merge_requests/2247 I recommended back in Nov that we accept (see attached email), but I asked him to make some revisions (as you can see in the discussion thread). All of this connects to (and I believe is compatible with) #195 (make Q (TExp a) into a newtype),<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F195&data=02%7C01%7Csimonpj%40microsoft.com%7C7a0ac32c2fcc4d92ea5508d778ce051a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110699587254268&sdata=EflG3cXQIdtlQlKln%2F3PEeK1T%2FRXq%2Fif7%2FIS3csirg4%3D&reserved=0> which we are set to accept too, once the proposal is revised. Iavor: you are the shepherd for that. I've had support for acceptance from * Joachim * Eric * Sandy * Simon M * Richard * Arnaud * Iavor I would love to hear from * Chris A * Vitaly B Others: reply only if you have any comments on the revised proposal. I'll accept this at the end of the week. Simon From: Matthew Pickering <notifications@github.com<mailto:notifications@github.com>> Sent: 04 December 2019 13:58 To: ghc-proposals/ghc-proposals <ghc-proposals@noreply.github.com<mailto:ghc-proposals@noreply.github.com>> Cc: Simon Peyton Jones <simonpj@microsoft.com<mailto:simonpj@microsoft.com>>; Mention <mention@noreply.github.com<mailto:mention@noreply.github.com>> Subject: Re: [ghc-proposals/ghc-proposals] Overloaded Quotation Brackets (#246) I have completed the revisions and wish to resubmit the proposal to the committee. The implementation is also finished an ready for review. - You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fghc-proposals%2Fghc-proposals%2Fpull%2F246%3Femail_source%3Dnotifications%26email_token%3DAAEOY636NCRXHIEMMDRTHBTQW6ZNTA5CNFSM4H5HNWR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEF5DHLQ%23issuecomment-561656750&data=02%7C01%7Csimonpj%40microsoft.com%7C7a0ac32c2fcc4d92ea5508d778ce051a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110699587254268&sdata=oWMOjzrjbFa2xG578L%2B3gcqsByM8qXvahpRtlcv3lVk%3D&reserved=0>, or unsubscribe<https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAAEOY62KELEHCDTSD4HEI73QW6ZNTANCNFSM4H5HNWRQ&data=02%7C01%7Csimonpj%40microsoft.com%7C7a0ac32c2fcc4d92ea5508d778ce051a%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637110699587264269&sdata=wXEhToKPA2luvTRw1DY3iPHxernEToQQrt4G3SVchZI%3D&reserved=0>.
participants (2)
-
Iavor Diatchki -
Simon Peyton Jones