Hi Simon, note that my cis.upenn.edu address will soon vanish with a puff; better use mail@joachim-breitner.de. Please allow me to respond on-list, I am sure you are not the only one who is confused by this. Yes, the relabeling was maybe the biggest mistake in our process: Proposals first have a number as Pull Request, but when they are accepted, they get a new, unrelated sequential number. We should have just re-used the PR number and have non-sequential numbers for accepted proposals. I wonder if we can still fix this. Nobody is really using the “accepted” number, so maybe it is fine?
Would it be possible to have a single list of all the proposals, with their status?
The official list of all accepted proposals is https://github.com/ghc-proposals/ghc-proposals/tree/master/proposals And the list for PRs is https://github.com/ghc-proposals/ghc-proposals/pulls where you can also filter by label, i.e. status (most links from the start page go this, with various filters applied). If someone is eager to do some hacking, one could aggregate all that in a fancy overview page somewhere (else), but I am hesitant to create such code, not because it has to be coded (that’s fun), but it has to be maintained and kept running and understood by everyone.
It would be v helpful if, for accepted proposals, the link pointed to the canonical, final version of the proposal, and gave its canonical final number.
You mean a link “Accepted proposal” at the top of the discussion thread? Yes, that would be useful; it’s just one more bit of tedious work. Cheers, Joachim Am Dienstag, den 11.06.2019, 07:41 +0000 schrieb Simon Peyton Jones:
Joachim I get very confused about GHC proposals and how to find the “right one”. Here’s an example. We have Proposal 54: Top-level kind signatures (instead of CUSKs) Proposal 36: Top-level kind signatures Apparently they are the same. Richard writes When a proposal gets proposed, it is a pull request and is assigned a number. After it gets accepted, it is assigned a sequential accepted proposal number. So not-yet-decided proposals are numbered among all such proposals, and accepted proposals are numbered among all such proposals. This is perhaps confusing, but it's what we currently do. You can get from an accepted proposal to its pull request by clicking the link at the top of the proposal. Joachim often labels the final resting place of PRs; this one appears overlooked. I've added a link. I don’t think I’d understood this change of numbering. So I wonder Would it be possible to lay out the scheme on the GHC proposal home page somewhere? Would it be possible to have a single list of all the proposals, with their status? At the moment, if you scroll around on the home page you can find various lists, but it would really help to bring them together. Or, I suppose, two lists: one for PRs and one for accepted proposals. (In each case they may have different labels.) It would be v helpful if, for accepted proposals, the link pointed to the canonical, final version of the proposal, and gave its canonical final number. We have quite a lot of proposals, which you do a great job of managing. But I get a bit lost sometimes. Thanks Simon -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
| I wonder if we can still fix this. Nobody is really using the “accepted”
| number, so maybe it is fine?
I don't have a strong opinion -- others may.
But it would help, *on the home page*
https://github.com/ghc-proposals/ghc-proposals
to have clear lists:
(A) List of all not-yet-accepted proposals, along with their status.
(B) List of all accepted proposals, along with their status.
(Status = labels, I guess.)
For (B) the link you give
https://github.com/ghc-proposals/ghc-proposals/pulls
seems good, though additional guidance (along with the link) would be helpful. For example:
* In this list, accepted proposals won't show up, because they should
be closed.
* You can filter by status by clicking on the "Labels" button.
When I fitered by "dormant" I only saw three -- that was a lot fewer than I expected.
For (A) it's sad not to have their labels; e.g. implemented or not. Is that hard to do?
Thanks!
Simon
| -----Original Message-----
| From: Joachim Breitner
Hi, Am Dienstag, den 11.06.2019, 09:05 +0000 schrieb Simon Peyton Jones:
I wonder if we can still fix this. Nobody is really using the “accepted” number, so maybe it is fine?
I don't have a strong opinion -- others may.
But it would help, *on the home page* https://github.com/ghc-proposals/ghc-proposals to have clear lists:
(A) List of all not-yet-accepted proposals, along with their status. (B) List of all accepted proposals, along with their status.
for (A) we have these links - ≡ List of proposals under discussion - ≡ List of proposals waiting for shepherd - ≡ List of proposals under review - ≡ List of dormant proposals (but we also eventually close proposals, so this is not precise) All these lists point to the discussion for a proposal, not the proposal itself. There is no good way of showing the union of these proposals, as GitHub’s label query language is not expressive enough (no union of queries) I can add a section to the homepage that collects all these links, if they are not easy enough to find right now. For (B) we (now, looks like I forgot to push a few weeks ago) point to - https://github.com/ghc-proposals/ghc-proposals/tree/master/proposals which is accurate, but not pretty and there are no labels. If we start updating the top post of reach proposal to point to the final thing, then using this for (B) would work: https://github.com/ghc-proposals/ghc-proposals/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3AAccepted+ It again points to the discussion page, which is a bit odd for accepted proposals, but if there is a clear link on top “accepted proposal”, and maybe some explanation “This proposal has been accepted and can be found at; this discussion is here for reference”, then that might be fine? This view would also clearly show the “Implemented” label, which we have to maintain, of course. It’s a bit more work, but I guess it is the right thing to do. Will do it right away.
(Status = labels, I guess.)
For (B) the link you give https://github.com/ghc-proposals/ghc-proposals/pulls seems good, though additional guidance (along with the link) would be helpful. For example: * In this list, accepted proposals won't show up, because they should be closed.
Yes, you need to disable the default filter, e.g. https://github.com/ghc-proposals/ghc-proposals/pulls?q= or click on closed.
* You can filter by status by clicking on the "Labels" button.
When I fitered by "dormant" I only saw three -- that was a lot fewer than I expected.
Again, because by default GitHub only shows open PRs. Eventually, we or the authors close proposals. Cheers, Joachim -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
Dear Joachim,
* You can filter by status by clicking on the "Labels" button.
When I fitered by "dormant" I only saw three -- that was a lot fewer
than I expected.
Again, because by default GitHub only shows open PRs. Eventually, we or the authors close proposals.
That being said, some dormant PRs are still open and unlabelled. I nearly randomly hit: https://github.com/ghc-proposals/ghc-proposals/pull/183 this morning. I'm guessing, there may be more. -- Kind regards, Artem Pelenitsyn
Cheers, Joachim -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee
Hi, I just * Added easier to find links to https://github.com/ghc-proposals/ghc-proposals * Added the Implemented label to some proposals that have the `implemented` thing non-empty in the proposal file. (I rely on volunteers to indicate which proposals have been implemented; there is no good technical solution in place to automate or monitor that efficiently) * I went through all(!) accepted proposals, and added a link to the accepted version to the top of the discussion thread, e.g. https://github.com/ghc-proposals/ghc-proposals/pull/6 This means that there is now a path the start page → list of accepted proposals → discussion page → proposal I hope I’ll be able to maintain this. Help is appreciated, in particular pinging me about implemented proposals. Enough tedious work for now. Cheers, Joachim Am Dienstag, den 11.06.2019, 13:47 +0200 schrieb Joachim Breitner:
Hi,
Am Dienstag, den 11.06.2019, 09:05 +0000 schrieb Simon Peyton Jones:
I wonder if we can still fix this. Nobody is really using the “accepted” number, so maybe it is fine?
I don't have a strong opinion -- others may.
But it would help, *on the home page* https://github.com/ghc-proposals/ghc-proposals to have clear lists:
(A) List of all not-yet-accepted proposals, along with their status. (B) List of all accepted proposals, along with their status.
for (A) we have these links - ≡ List of proposals under discussion - ≡ List of proposals waiting for shepherd - ≡ List of proposals under review - ≡ List of dormant proposals (but we also eventually close proposals, so this is not precise)
All these lists point to the discussion for a proposal, not the proposal itself.
There is no good way of showing the union of these proposals, as GitHub’s label query language is not expressive enough (no union of queries)
I can add a section to the homepage that collects all these links, if they are not easy enough to find right now.
For (B) we (now, looks like I forgot to push a few weeks ago) point to - https://github.com/ghc-proposals/ghc-proposals/tree/master/proposals which is accurate, but not pretty and there are no labels.
If we start updating the top post of reach proposal to point to the final thing, then using this for (B) would work: https://github.com/ghc-proposals/ghc-proposals/pulls?utf8=%E2%9C%93&q=is%3Apr+label%3AAccepted+ It again points to the discussion page, which is a bit odd for accepted proposals, but if there is a clear link on top “accepted proposal”, and maybe some explanation “This proposal has been accepted and can be found at; this discussion is here for reference”, then that might be fine?
This view would also clearly show the “Implemented” label, which we have to maintain, of course.
It’s a bit more work, but I guess it is the right thing to do. Will do it right away.
(Status = labels, I guess.)
For (B) the link you give https://github.com/ghc-proposals/ghc-proposals/pulls seems good, though additional guidance (along with the link) would be helpful. For example: * In this list, accepted proposals won't show up, because they should be closed.
Yes, you need to disable the default filter, e.g. https://github.com/ghc-proposals/ghc-proposals/pulls?q= or click on closed.
* You can filter by status by clicking on the "Labels" button.
When I fitered by "dormant" I only saw three -- that was a lot fewer than I expected.
Again, because by default GitHub only shows open PRs. Eventually, we or the authors close proposals.
Cheers, Joachim _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee -- Joachim Breitner mail@joachim-breitner.de http://www.joachim-breitner.de/
participants (3)
-
Artem Pelenitsyn -
Joachim Breitner -
Simon Peyton Jones