Please review #678: Amendment to ImportShadowing

older
Named defaults -- attention needed

Adam Gundry

4 Oct 2024 4 Oct '24

3:58 a.m.

Dear Committee, Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports: https://github.com/ghc-proposals/ghc-proposals/pull/678 I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal. Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process Cheers, Adam -- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

Show replies by date

Erik de Castro Lopo

16 Oct 16 Oct

7:38 p.m.

Hi all, I have recommended "accept" for this minor modification of this proposal. I would appreciate it if everyone else on the committee would vote. Thanks, Erik Adam Gundry wrote:

...

Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Sebastian Graf

17 Oct 17 Oct

3:31 a.m.

New subject: Please review #678: Amendment to ImportShadowing

Hi, I vote "accept" as well. I'm a bit surprised by the subtlety, but the clarified semantics makes sense. Cheers, Sebastian ------ Originalnachricht ------ Von "Erik de Castro Lopo" An ghc-steering-committee@haskell.org Datum 17.10.2024 01:38:19 Betreff Re: [ghc-steering-committee] Please review #678: Amendment to ImportShadowing

...

Hi all,

I have recommended "accept" for this minor modification of this proposal.

I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Moritz Angermann

3:45 a.m.

Hi, I’m in support as well! Best, Moritz On Thu, Oct 17, 2024 at 4:31 PM Sebastian Graf wrote:

...

Hi,

I vote "accept" as well. I'm a bit surprised by the subtlety, but the clarified semantics makes sense.

Cheers, Sebastian

------ Originalnachricht ------ Von "Erik de Castro Lopo" An ghc-steering-committee@haskell.org Datum 17.10.2024 01:38:19 Betreff Re: [ghc-steering-committee] Please review #678: Amendment to ImportShadowing

...
Hi all,

I have recommended "accept" for this minor modification of this proposal.

I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Simon Peyton Jones

3:58 a.m.

I support, subject to a couple of typos I have identified. Simon On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo wrote:

...

Hi all,

I have recommended "accept" for this minor modification of this proposal.

I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Malte Ott

18 Oct 18 Oct

4:33 a.m.

New subject: Please review #678: Amendment to ImportShadowing

I support as well. On 2024-10-17 08:58, Simon Peyton Jones wrote:

...

I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo wrote:

...
Hi all,

I have recommended "accept" for this minor modification of this proposal.

I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Jakob Brünker

4:42 a.m.

Seems like a reasonable amendment, I'm in support. On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...

I support as well.

...
I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo wrote:

...
Hi all,

I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...
...
I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...
...
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Arnaud Spiwack

20 Oct 20 Oct

10:50 p.m.

I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it? So, in favour. On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...

Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...
I support as well.

...
I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo wrote:

...
Hi all,

I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...
...
I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...
...
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io.

Simon Peyton Jones

21 Oct 21 Oct

4:01 a.m.

I find it a little annoying that this isn't backward compatible Me too. I outline on the Github a way to make it backward compatible. *Everyone*: do express a view there. Simon On Mon, 21 Oct 2024 at 03:50, Arnaud Spiwack wrote:

...

I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?

So, in favour.

On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...
Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...
I support as well.

...
I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo
wrote:

...
Hi all,

I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...
...
I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

--

...
...
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...
...
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Matthías Páll Gissurarson

4:27 a.m.

I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want. On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack wrote:

...

I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?

So, in favour.

On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...
Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...
I support as well.

...
I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo
wrote:

...
Hi all,

I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...
...
I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

...
Dear Committee,

Gergő Érdi proposes to amend his import shadowing proposal #652 to clarify the behaviour of module re-exports:

https://github.com/ghc-proposals/ghc-proposals/pull/678

I'd like to nominate Erik de Castro Lopo as the shepherd, as he shepherded the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

--

...
...
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...
...
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- -- Matthías Páll Gissurarson http://mpg.is/

Simon Peyton Jones

4:48 a.m.

...

we'd be well served by a better spec for what `module M` means in an export list,

Well, that's the entire purpose of this amendment! - Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884... ? Simon On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson wrote:

...

I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.

On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack wrote:

...
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?

So, in favour.

On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...
Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...
I support as well.

...
I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> wrote:

...
Hi all,

I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...
...
I would appreciate it if everyone else on the committee would vote.

Thanks, Erik

Adam Gundry wrote:

> Dear Committee, > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > clarify the behaviour of module re-exports: > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > shepherded the original proposal. > > Please guide us to a conclusion as outlined in > https://github.com/ghc-proposals/ghc-proposals#committee-process > > Cheers, > > Adam > > > -- > Adam Gundry, Haskell Consultant > Well-Typed LLP, https://www.well-typed.com/ > > Registered in England & Wales, OC335890 > 27 Old Gloucester Street, London WC1N 3AX, England >

--

...
...
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...
...
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- -- Matthías Páll Gissurarson http://mpg.is/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Matthías Páll Gissurarson

5:40 a.m.

I’m in favor of the backward compatible one, it’s a bit more complicated but (I think) clearer. I’ve left some comments on the PR itself. /Matti Palli On Mon, Oct 21, 2024 at 10:48 Simon Peyton Jones < simon.peytonjones@gmail.com> wrote:

...

...
we'd be well served by a better spec for what `module M` means in an export list,

Well, that's the entire purpose of this amendment!

- Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884... ?

Simon

On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson wrote:

...
I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.

On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack wrote:

...
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?

So, in favour.

On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...
Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...
I support as well.

...
I support, subject to a couple of typos I have identified.

Simon

On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> wrote:

> Hi all, > > I have recommended "accept" for this minor modification of this

On 2024-10-17 08:58, Simon Peyton Jones wrote: proposal.

...
> > I would appreciate it if everyone else on the committee would vote. > > Thanks, > Erik > > > Adam Gundry wrote: > > > Dear Committee, > > > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > > clarify the behaviour of module re-exports: > > > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > > shepherded the original proposal. > > > > Please guide us to a conclusion as outlined in > > https://github.com/ghc-proposals/ghc-proposals#committee-process > > > > Cheers, > > > > Adam > > > > > > -- > > Adam Gundry, Haskell Consultant > > Well-Typed LLP, https://www.well-typed.com/ > > > > Registered in England & Wales, OC335890 > > 27 Old Gloucester Street, London WC1N 3AX, England https://www.google.com/maps/search/27+Old+Gloucester+Street,+London+WC1N+3AX,+England?entry=gmail&source=g > > > > > -- >

...
> Erik de Castro Lopo > http://www.mega-nerd.com/ > _______________________________________________ > ghc-steering-committee mailing list > ghc-steering-committee@haskell.org > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee >

...
_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- -- Matthías Páll Gissurarson http://mpg.is/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Sebastian Graf

6:20 a.m.

I would like to hear back from the proposal author. If he's willing to incorporate Simon's spec, I would be very happy. I still accept the proposal as-is in the interest of making progress. Am Mo., 21. Okt. 2024 um 11:40 Uhr schrieb Matthías Páll Gissurarson < mpg@mpg.is>:

...

I’m in favor of the backward compatible one, it’s a bit more complicated but (I think) clearer. I’ve left some comments on the PR itself.

/Matti Palli

On Mon, Oct 21, 2024 at 10:48 Simon Peyton Jones < simon.peytonjones@gmail.com> wrote:

...
...
we'd be well served by a better spec for what `module M` means in an export list,

Well, that's the entire purpose of this amendment!

- Do you think it now gives a clear spec? - Do you prefer the alternative (more complicated, but backward compatible) spec I suggested here https://github.com/ghc-proposals/ghc-proposals/pull/678#issuecomment-2421884... ?

Simon

On Mon, 21 Oct 2024 at 09:27, Matthías Páll Gissurarson wrote:

...
I'm in support. I agree with Simon's comment, we'd be well served by a better spec for what `module M` means in an export list, but this amendment is closer to what we would want.

On Mon, 21 Oct 2024 at 04:50, Arnaud Spiwack wrote:

...
I find it a little annoying that this isn't backward compatible. But on the other hand, it's a very obscure bit of Haskell semantics which is modified, module re-export is something that most people frequently get wrong anyway. At any rate, my feeling is that the proposed change is the right behaviour: if a module defines a function `foo`, and exports a *different* function `foo`, this is at least a smell, isn't it?

So, in favour.

On Fri, 18 Oct 2024 at 17:43, Jakob Brünker wrote:

...
Seems like a reasonable amendment, I'm in support.

On Fri, Oct 18, 2024 at 10:33 AM Malte Ott wrote:

...
I support as well.

On 2024-10-17 08:58, Simon Peyton Jones wrote: > I support, subject to a couple of typos I have identified. > > Simon > > On Thu, 17 Oct 2024 at 00:38, Erik de Castro Lopo < erikd@mega-nerd.com> > wrote: > > > Hi all, > > > > I have recommended "accept" for this minor modification of this proposal. > > > > I would appreciate it if everyone else on the committee would vote. > > > > Thanks, > > Erik > > > > > > Adam Gundry wrote: > > > > > Dear Committee, > > > > > > Gergő Érdi proposes to amend his import shadowing proposal #652 to > > > clarify the behaviour of module re-exports: > > > > > > https://github.com/ghc-proposals/ghc-proposals/pull/678 > > > > > > I'd like to nominate Erik de Castro Lopo as the shepherd, as he > > > shepherded the original proposal. > > > > > > Please guide us to a conclusion as outlined in > > > https://github.com/ghc-proposals/ghc-proposals#committee-process > > > > > > Cheers, > > > > > > Adam > > > > > > > > > -- > > > Adam Gundry, Haskell Consultant > > > Well-Typed LLP, https://www.well-typed.com/ > > > > > > Registered in England & Wales, OC335890 > > > 27 Old Gloucester Street, London WC1N 3AX, England https://www.google.com/maps/search/27+Old+Gloucester+Street,+London+WC1N+3AX,+England?entry=gmail&source=g > > > > > > > > > -- > > ---------------------------------------------------------------------- > > Erik de Castro Lopo > > http://www.mega-nerd.com/ > > _______________________________________________ > > ghc-steering-committee mailing list > > ghc-steering-committee@haskell.org > > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee > >

> _______________________________________________ > ghc-steering-committee mailing list > ghc-steering-committee@haskell.org > https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io. _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- -- Matthías Páll Gissurarson http://mpg.is/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

211

Age (days ago)

228

Last active (days ago)

List overview

Download

12 comments

9 participants

participants (9)

Adam Gundry
Arnaud Spiwack
Erik de Castro Lopo
Jakob Brünker
Malte Ott
Matthías Páll Gissurarson
Moritz Angermann
Sebastian Graf
Simon Peyton Jones

Please review #678: Amendment to ImportShadowing

tags

participants (9)