Please review #673: Amendment to -jsem proposal #540

newer
Please review #680: Clarify CRLF...

Adam Gundry

19 Sep 2024 19 Sep '24

11:27 a.m.

Dear Committee, Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations: https://github.com/ghc-proposals/ghc-proposals/pull/673 https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal. Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process Cheers, Adam -- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

Show replies by date

Erik de Castro Lopo

19 Sep 19 Sep

8 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Hi all, This is minor updates to correct an existing approved proposal. I approve of these changes. Erik Adam Gundry wrote:

...

Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Moritz Angermann

11:51 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Hi all, I believe Erik meant to recommend acceptance of this proposal. I too support this change. Best, Moritz On Fri, 20 Sept 2024 at 09:00, Erik de Castro Lopo wrote:

...

Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Erik de Castro Lopo

20 Sep 20 Sep

12:05 a.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Moritz, Eric Seidel was the shepherd for #540 which #673 (this one) amends. Erik (with a 'k') Moritz Angermann wrote:

...

Hi all,

I believe Erik meant to recommend acceptance of this proposal.

I too support this change.

Best, Moritz

On Fri, 20 Sept 2024 at 09:00, Erik de Castro Lopo wrote:

...
Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/

Moritz Angermann

12:07 a.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Erik, My apologies! I got my eyes crossed 🙇 Best, Moritz On Fri, 20 Sept 2024 at 13:05, Erik de Castro Lopo wrote:

...

Moritz,

Eric Seidel was the shepherd for #540 which #673 (this one) amends.

Erik (with a 'k')

Moritz Angermann wrote:

...
Hi all,

I believe Erik meant to recommend acceptance of this proposal.

I too support this change.

Best, Moritz

On Fri, 20 Sept 2024 at 09:00, Erik de Castro Lopo wrote:

...
Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
...
I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

...
-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Eric Seidel

21 Sep 21 Sep

10:16 a.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Hi all, This seems like a sensible update to an accepted proposal. I recommend we accept the amendment. Eric On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote:

...

Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Malte Ott

3:44 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

I agree. On 2024-09-21 09:16, Eric Seidel wrote:

...

Hi all,

This seems like a sensible update to an accepted proposal.

I recommend we accept the amendment.

Eric

On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote:

...
Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Simon Peyton Jones

23 Sep 23 Sep

6:10 a.m.

New subject: Please review #673: Amendment to -jsem proposal #540

I'm happy to support too, but I would like to see presentational changes, so the final proposal makes sense when read in 5 yrs time. Simon On Sat, 21 Sept 2024 at 20:45, Malte Ott wrote:

...

I agree.

On 2024-09-21 09:16, Eric Seidel wrote:

...
Hi all,

This seems like a sensible update to an accepted proposal.

I recommend we accept the amendment.

Eric

On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote:

...
Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Arnaud Spiwack

10:17 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Quite frankly, this is barely any user-facing change at all. Technically the semaphore could previously be shared by non-Haskell processes in ways the updated proposal doesn't allow. But it's not really something people do. So it all sounds reasonable. On Mon, 23 Sept 2024 at 19:10, Simon Peyton Jones < simon.peytonjones@gmail.com> wrote:

...

I'm happy to support too, but I would like to see presentational changes, so the final proposal makes sense when read in 5 yrs time.

Simon

On Sat, 21 Sept 2024 at 20:45, Malte Ott wrote:

...
I agree.

On 2024-09-21 09:16, Eric Seidel wrote:

...
Hi all,

This seems like a sensible update to an accepted proposal.

I recommend we accept the amendment.

Eric

On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote:

...
Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced the -jsem parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
I'd like to nominate Eric Seidel as the shepherd, since he was the shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- ---------------------------------------------------------------------- Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io.

Sebastian Graf

24 Sep 24 Sep

2:44 a.m.

New subject: Please review #673: Amendment to -jsem proposal #540

I think changes to the communication protocol *are* user-facing, in that any change to the protocol could implies a breaking change between all cabal releases in the future and all GHC releases in the past. It appears that is the case for the planned release of `semaphore-compat-2`, but I'm not 100% sure. In that light, I think it's good to discuss in a proposal to ensure we do not sign off lightly on such breaking changes, in particular for future versions of `semaphore-compat`. I will express support once compatibility and breaking changes are properly addressed. Sebastian ------ Originalnachricht ------ Von "Arnaud Spiwack" An "Simon Peyton Jones" Cc ghc-steering-committee@haskell.org Datum 24.09.2024 04:17:17 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...

Quite frankly, this is barely any user-facing change at all. Technically the semaphore could previously be shared by non-Haskell processes in ways the updated proposal doesn't allow. But it's not really something people do. So it all sounds reasonable.

On Mon, 23 Sept 2024 at 19:10, Simon Peyton Jones wrote:

...
I'm happy to support too, but I would like to see presentational changes, so the final proposal makes sense when read in 5 yrs time.

Simon

On Sat, 21 Sept 2024 at 20:45, Malte Ott wrote:

...
I agree.

...
Hi all,

This seems like a sensible update to an accepted proposal.

I recommend we accept the amendment.

Eric

On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote:

...
Hi all,

This is minor updates to correct an existing approved proposal.

I approve of these changes.

Erik

Adam Gundry wrote:

...
Dear Committee,

Zubin Duggal proposes to amend proposal #540, which introduced

...
...
...
parallelism control mechanism, so that it can avoid incompatibilities arising from different system C library implementations:

https://github.com/ghc-proposals/ghc-proposals/pull/673

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
I'd like to nominate Eric Seidel as the shepherd, since he was

On 2024-09-21 09:16, Eric Seidel wrote: the -jsem the

...
...
...
shepherd of the original proposal.

Please guide us to a conclusion as outlined in https://github.com/ghc-proposals/ghc-proposals#committee-process

Cheers,

Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

--

...
...
Erik de Castro Lopo http://www.mega-nerd.com/ _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org

https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee _______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

-- Arnaud Spiwack Director, Research at https://moduscreate.com and https://tweag.io.

Adam Gundry

29 Oct 29 Oct

3:37 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

It seems Zubin updated the proposal to take account of Sebastian's concerns, but then discussion has tailed off. Are we now in a position to accept this proposal, or are there any remaining concerns? Cheers, Adam On 24/09/2024 07:44, Sebastian Graf wrote:

...

I think changes to the communication protocol *are* user-facing, in that any change to the protocol could implies a breaking change between all cabal releases in the future and all GHC releases in the past. It appears that is the case for the planned release of `semaphore-compat-2`, but I'm not 100% sure.

In that light, I think it's good to discuss in a proposal to ensure we do not sign off lightly on such breaking changes, in particular for future versions of `semaphore-compat`.

I will express support once compatibility and breaking changes are properly addressed.

Sebastian

------ Originalnachricht ------ Von "Arnaud Spiwack" mailto:arnaud.spiwack@tweag.io> An "Simon Peyton Jones" mailto:simon.peytonjones@gmail.com> Cc ghc-steering-committee@haskell.org mailto:ghc-steering-committee@haskell.org Datum 24.09.2024 04:17:17 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...
Quite frankly, this is barely any user-facing change at all. Technically the semaphore could previously be shared by non-Haskell processes in ways the updated proposal doesn't allow. But it's not really something people do. So it all sounds reasonable.

On Mon, 23 Sept 2024 at 19:10, Simon Peyton Jones mailto:simon.peytonjones@gmail.com> wrote:

I'm happy to support too, but I would like to see presentational changes, so the final proposal makes sense when read in 5 yrs time.

Simon

On Sat, 21 Sept 2024 at 20:45, Malte Ott mailto:malte.ott@maralorn.de> wrote:

I agree.

On 2024-09-21 09:16, Eric Seidel wrote: > Hi all, > > This seems like a sensible update to an accepted proposal. > > I recommend we accept the amendment. > > Eric > > On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote: > > Hi all, > > > > This is minor updates to correct an existing approved proposal. > > > > I approve of these changes. > > > > Erik > > > > Adam Gundry wrote: > > > >> Dear Committee, > >> > >> Zubin Duggal proposes to amend proposal #540, which introduced the -jsem > >> parallelism control mechanism, so that it can avoid incompatibilities > >> arising from different system C library implementations: > >> > >> https://github.com/ghc-proposals/ghc-proposals/pull/673 https://github.com/ghc-proposals/ghc-proposals/pull/673 > >> > >> https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... > >> > >> I'd like to nominate Eric Seidel as the shepherd, since he was the > >> shepherd of the original proposal. > >> > >> Please guide us to a conclusion as outlined in > >> https://github.com/ghc-proposals/ghc-proposals#committee-process https://github.com/ghc-proposals/ghc-proposals#committee-process > >> > >> Cheers, > >> > >> Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/ Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

Simon Peyton Jones

6:16 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

I'm supportive. I do not have a well-informed view, but the amendment is born from practical experience, so I am pretty sure it's an improvement. I'd love a bit more detail in the proposal (I have commented in one place) but I might be off-target and would yield to others' advice, including that of the author. Simon On Tue, 29 Oct 2024 at 19:37, Adam Gundry wrote:

...

It seems Zubin updated the proposal to take account of Sebastian's concerns, but then discussion has tailed off. Are we now in a position to accept this proposal, or are there any remaining concerns?

Cheers,

Adam

On 24/09/2024 07:44, Sebastian Graf wrote:

...
I think changes to the communication protocol *are* user-facing, in that any change to the protocol could implies a breaking change between all cabal releases in the future and all GHC releases in the past. It appears that is the case for the planned release of `semaphore-compat-2`, but I'm not 100% sure.

In that light, I think it's good to discuss in a proposal to ensure we do not sign off lightly on such breaking changes, in particular for future versions of `semaphore-compat`.

I will express support once compatibility and breaking changes are properly addressed.

Sebastian

------ Originalnachricht ------ Von "Arnaud Spiwack" mailto:arnaud.spiwack@tweag.io> An "Simon Peyton Jones" mailto:simon.peytonjones@gmail.com> Cc ghc-steering-committee@haskell.org mailto:ghc-steering-committee@haskell.org Datum 24.09.2024 04:17:17 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...
Quite frankly, this is barely any user-facing change at all. Technically the semaphore could previously be shared by non-Haskell processes in ways the updated proposal doesn't allow. But it's not really something people do. So it all sounds reasonable.

On Mon, 23 Sept 2024 at 19:10, Simon Peyton Jones mailto:simon.peytonjones@gmail.com> wrote:

I'm happy to support too, but I would like to see presentational changes, so the final proposal makes sense when read in 5 yrs time.

Simon

On Sat, 21 Sept 2024 at 20:45, Malte Ott mailto:malte.ott@maralorn.de> wrote:

I agree.

On 2024-09-21 09:16, Eric Seidel wrote: > Hi all, > > This seems like a sensible update to an accepted proposal. > > I recommend we accept the amendment. > > Eric > > On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote: > > Hi all, > > > > This is minor updates to correct an existing approved proposal. > > > > I approve of these changes. > > > > Erik > > > > Adam Gundry wrote: > > > >> Dear Committee, > >> > >> Zubin Duggal proposes to amend proposal #540, which introduced the -jsem > >> parallelism control mechanism, so that it can avoid incompatibilities > >> arising from different system C library implementations: > >> > >> https://github.com/ghc-proposals/ghc-proposals/pull/673 https://github.com/ghc-proposals/ghc-proposals/pull/673 > >> > >>

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... < https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
> >> > >> I'd like to nominate Eric Seidel as the shepherd, since he was the > >> shepherd of the original proposal. > >> > >> Please guide us to a conclusion as outlined in > >>

https://github.com/ghc-proposals/ghc-proposals#committee-process < https://github.com/ghc-proposals/ghc-proposals#committee-process>

...
> >> > >> Cheers, > >> > >> Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Sebastian Graf

1 Nov 1 Nov

1 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

I'm in support as well, but would like to see the relationship to PVP major bumps addressed. ------ Originalnachricht ------ Von "Simon Peyton Jones" An "Adam Gundry" Cc ghc-steering-committee@haskell.org Datum 29.10.2024 23:16:20 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...

I'm supportive. I do not have a well-informed view, but the amendment is born from practical experience, so I am pretty sure it's an improvement.

I'd love a bit more detail in the proposal (I have commented in one place) but I might be off-target and would yield to others' advice, including that of the author.

Simon

On Tue, 29 Oct 2024 at 19:37, Adam Gundry wrote:

...
It seems Zubin updated the proposal to take account of Sebastian's concerns, but then discussion has tailed off. Are we now in a position to accept this proposal, or are there any remaining concerns?

Cheers,

Adam

...
I think changes to the communication protocol *are* user-facing, in

...
any change to the protocol could implies a breaking change between all cabal releases in the future and all GHC releases in the past. It appears that is the case for the planned release of `semaphore-compat-2`, but I'm not 100% sure.

In that light, I think it's good to discuss in a proposal to ensure we do not sign off lightly on such breaking changes, in particular for future versions of `semaphore-compat`.

I will express support once compatibility and breaking changes are properly addressed.

Sebastian

------ Originalnachricht ------ Von "Arnaud Spiwack" mailto:arnaud.spiwack@tweag.io> An "Simon Peyton Jones" mailto:simon.peytonjones@gmail.com> Cc ghc-steering-committee@haskell.org mailto:ghc-steering-committee@haskell.org Datum 24.09.2024 04:17:17 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...
Quite frankly, this is barely any user-facing change at all. Technically the semaphore could previously be shared by non-Haskell processes in ways the updated proposal doesn't allow. But it's not really something people do. So it all sounds reasonable.

On Mon, 23 Sept 2024 at 19:10, Simon Peyton Jones mailto:simon.peytonjones@gmail.com> wrote:

I'm happy to support too, but I would like to see

...
...
changes, so the final proposal makes sense when read in 5 yrs

time.

...
Simon

On Sat, 21 Sept 2024 at 20:45, Malte Ott mailto:malte.ott@maralorn.de> wrote:

I agree.

On 2024-09-21 09:16, Eric Seidel wrote: > Hi all, > > This seems like a sensible update to an accepted

On 24/09/2024 07:44, Sebastian Graf wrote: that presentational proposal.

...
...
> > I recommend we accept the amendment. > > Eric > > On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo

wrote:

...
> > Hi all, > > > > This is minor updates to correct an existing approved proposal. > > > > I approve of these changes. > > > > Erik > > > > Adam Gundry wrote: > > > >> Dear Committee, > >> > >> Zubin Duggal proposes to amend proposal #540, which introduced the -jsem > >> parallelism control mechanism, so that it can avoid incompatibilities > >> arising from different system C library

implementations:

...
> >> > >>

https://github.com/ghc-proposals/ghc-proposals/pull/673

...
https://github.com/ghc-proposals/ghc-proposals/pull/673 > >> > >>

https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs...

...
> >> > >> I'd like to nominate Eric Seidel as the shepherd,

since

...
he was the > >> shepherd of the original proposal. > >> > >> Please guide us to a conclusion as outlined in > >>

https://github.com/ghc-proposals/ghc-proposals#committee-process https://github.com/ghc-proposals/ghc-proposals#committee-process

...
> >> > >> Cheers, > >> > >> Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

Eric Seidel

10 Nov 10 Nov

6:07 p.m.

New subject: Please review #673: Amendment to -jsem proposal #540

Sorry for my absence folks. I've looked through the updates and think this is basically landing in a good place once the last comments from Sebastian and Simon are addressed. On Fri, Nov 1, 2024, at 12:00, Sebastian Graf wrote:

...

I'm in support as well, but would like to see the relationship to PVP major bumps addressed.

------ Originalnachricht ------ Von "Simon Peyton Jones" An "Adam Gundry" Cc ghc-steering-committee@haskell.org Datum 29.10.2024 23:16:20 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...
I'm supportive. I do not have a well-informed view, but the amendment is born from practical experience, so I am pretty sure it's an improvement.

I'd love a bit more detail in the proposal (I have commented in one place) but I might be off-target and would yield to others' advice, including that of the author.

Simon

On Tue, 29 Oct 2024 at 19:37, Adam Gundry wrote:

...
It seems Zubin updated the proposal to take account of Sebastian's concerns, but then discussion has tailed off. Are we now in a position to accept this proposal, or are there any remaining concerns?

Cheers,

Adam

On 24/09/2024 07:44, Sebastian Graf wrote:

...
I think changes to the communication protocol *are* user-facing, in that any change to the protocol could implies a breaking change between all cabal releases in the future and all GHC releases in the past. It appears that is the case for the planned release of `semaphore-compat-2`, but I'm not 100% sure.

In that light, I think it's good to discuss in a proposal to ensure we do not sign off lightly on such breaking changes, in particular for future versions of `semaphore-compat`.

I will express support once compatibility and breaking changes are properly addressed.

Sebastian

------ Originalnachricht ------ Von "Arnaud Spiwack" mailto:arnaud.spiwack@tweag.io> An "Simon Peyton Jones" mailto:simon.peytonjones@gmail.com> Cc ghc-steering-committee@haskell.org mailto:ghc-steering-committee@haskell.org Datum 24.09.2024 04:17:17 Betreff Re: [ghc-steering-committee] Please review #673: Amendment to -jsem proposal #540

...
Quite frankly, this is barely any user-facing change at all. Technically the semaphore could previously be shared by non-Haskell processes in ways the updated proposal doesn't allow. But it's not really something people do. So it all sounds reasonable.

On Mon, 23 Sept 2024 at 19:10, Simon Peyton Jones mailto:simon.peytonjones@gmail.com> wrote:

I'm happy to support too, but I would like to see presentational changes, so the final proposal makes sense when read in 5 yrs time.

Simon

On Sat, 21 Sept 2024 at 20:45, Malte Ott mailto:malte.ott@maralorn.de> wrote:

I agree.

On 2024-09-21 09:16, Eric Seidel wrote: > Hi all, > > This seems like a sensible update to an accepted proposal. > > I recommend we accept the amendment. > > Eric > > On Thu, Sep 19, 2024, at 19:00, Erik de Castro Lopo wrote: > > Hi all, > > > > This is minor updates to correct an existing approved proposal. > > > > I approve of these changes. > > > > Erik > > > > Adam Gundry wrote: > > > >> Dear Committee, > >> > >> Zubin Duggal proposes to amend proposal #540, which introduced the -jsem > >> parallelism control mechanism, so that it can avoid incompatibilities > >> arising from different system C library implementations: > >> > >> https://github.com/ghc-proposals/ghc-proposals/pull/673 https://github.com/ghc-proposals/ghc-proposals/pull/673 > >> > >> https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... https://github.com/wz1000/ghc-proposals/blob/new-jsem/proposals/0540-jsem.rs... > >> > >> I'd like to nominate Eric Seidel as the shepherd, since he was the > >> shepherd of the original proposal. > >> > >> Please guide us to a conclusion as outlined in > >> https://github.com/ghc-proposals/ghc-proposals#committee-process https://github.com/ghc-proposals/ghc-proposals#committee-process > >> > >> Cheers, > >> > >> Adam

-- Adam Gundry, Haskell Consultant Well-Typed LLP, https://www.well-typed.com/

Registered in England & Wales, OC335890 27 Old Gloucester Street, London WC1N 3AX, England

_______________________________________________ ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

ghc-steering-committee mailing list ghc-steering-committee@haskell.org https://mail.haskell.org/cgi-bin/mailman/listinfo/ghc-steering-committee

191

Age (days ago)

243

Last active (days ago)

List overview

Download

13 comments

8 participants

participants (8)

Adam Gundry
Arnaud Spiwack
Eric Seidel
Erik de Castro Lopo
Malte Ott
Moritz Angermann
Sebastian Graf
Simon Peyton Jones

Please review #673: Amendment to -jsem proposal #540

tags

participants (8)