November 2013 - ghc-tickets

Re: [GHC] #1480: Template Haskell should allow reification of modules
by GHC 06 Nov '13

06 Nov '13

#1480: Template Haskell should allow reification of modules ----------------------------+---------------------------------------------- Reporter: igloo | Owner: Type: feature | Status: closed request | Milestone: 7.8.1 Priority: highest | Version: 7.7 Component: | Keywords: Template Haskell | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Moderate (less than a day) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: 8398 | ----------------------------+---------------------------------------------- Comment (by simonmar): ah yes, good point. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/1480#comment:31> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #4900: DEPENDS pragma
by GHC 06 Nov '13

06 Nov '13

#4900: DEPENDS pragma -------------------------------------+------------------------------------ Reporter: cdsmith | Owner: Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: TH_Depends | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by parcs): Replying to [comment:63 simonmar]: > At first glance it's not obviously right, since we don't normally modify `ModSummary` during the upsweep - the `ModSummary` is something that is supposed to be collected by the downsweep. A module's list of usage files can only be determined _after_ compiling the module because the list includes files added by TH's `qAddDependencies`. So one way or another, usage-file information has to be propagated from a previous upsweep to a future downsweep (and to the stability check that follows). I proposed two independent solutions: 1. During the downsweep, look inside the HPT to extract the usage-file information from an existing HMI and stuff it into the !ModSummary. 2. During the upsweep, extract the usage-file information from the new HMI and update the module graph with this information. A future downsweep will use this updated module graph. But these solutions don't exactly satisfy the existing invariants of the downsweep and upsweep. For (1), we shouldn't read the HPT during the downsweep. For (2), we shouldn't update a !ModSummary during the upsweep. But I can't think of another solution. I personally like (1), especially since there are two independent upsweeps now. The patch that Adam attached is an updated version of (2). I think it would help review if a future patch was split into several logical patches. It's not a lot of code but it's somewhat tricky code. This is just my understanding of the state of this ticket. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4900#comment:64> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #1480: Template Haskell should allow reification of modules
by GHC 06 Nov '13

06 Nov '13

#1480: Template Haskell should allow reification of modules ----------------------------+---------------------------------------------- Reporter: igloo | Owner: Type: feature | Status: closed request | Milestone: 7.8.1 Priority: highest | Version: 7.7 Component: | Keywords: Template Haskell | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Moderate (less than a day) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: 8398 | ----------------------------+---------------------------------------------- Comment (by simonpj): I don't think splitting `mi_deps` will work, because it lists only the ''home-package'' imports, so we would not thereby find the directly imported modules that happen to be in other packages. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/1480#comment:30> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #4900: DEPENDS pragma
by GHC 06 Nov '13

06 Nov '13

#4900: DEPENDS pragma -------------------------------------+------------------------------------ Reporter: cdsmith | Owner: Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: TH_Depends | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by simonmar): I still need to review this patch carefully. At first glance it's not obviously right, since we don't normally modify `ModSummary` during the upsweep - the `ModSummary` is something that is supposed to be collected by the downsweep. But I don't have all the details in my head right now, I'll try to come back to this when I have more time. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4900#comment:63> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #1480: Template Haskell should allow reification of modules
by GHC 06 Nov '13

06 Nov '13

#1480: Template Haskell should allow reification of modules ----------------------------+---------------------------------------------- Reporter: igloo | Owner: Type: feature | Status: closed request | Milestone: 7.8.1 Priority: highest | Version: 7.7 Component: | Keywords: Template Haskell | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Moderate (less than a day) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: 8398 | ----------------------------+---------------------------------------------- Comment (by simonmar): An alternative is to split `dep_mods` into two; the direct imports and the rest. That would avoid growing the `.hi` file. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/1480#comment:29> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #4135: Can't Quote Instance Associated Types in Template Haskell
by GHC 06 Nov '13

06 Nov '13

#4135: Can't Quote Instance Associated Types in Template Haskell ----------------------------------------------+---------------------------- Reporter: Ashley Yakeley | Owner: Type: bug | Status: closed Priority: low | Milestone: 7.6.2 Component: Template Haskell | Version: 6.12.1 Resolution: fixed | Keywords: Operating System: Linux | Architecture: x86_64 Type of failure: GHC rejects valid program | (amd64) Test Case: th/T4135, T4135a | Difficulty: Unknown Blocking: | Blocked By: 4230 | Related Tickets: ----------------------------------------------+---------------------------- Changes (by simonpj): * status: new => closed * testcase: th/T4135 => th/T4135, T4135a * resolution: => fixed Comment: Comment 2 works now, with the new Template Haskell story. I've added a new test `T4135a`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4135#comment:18> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #4230: Template Haskell: less type checking in quotations?
by GHC 06 Nov '13

06 Nov '13

#4230: Template Haskell: less type checking in quotations? -------------------------------------+------------------------------------ Reporter: simonpj | Owner: Type: feature request | Status: closed Priority: low | Milestone: 7.6.2 Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: 4125, 4135 | Related Tickets: -------------------------------------+------------------------------------ Changes (by simonpj): * status: new => closed * resolution: => fixed Comment: Closing this because the [blog:Template%20Haskell%20Proposal TH blog post proposal] is now implemented. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4230#comment:21> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #7477: reifyInstances can't deal with polykinded type families
by GHC 06 Nov '13

06 Nov '13

#7477: reifyInstances can't deal with polykinded type families -------------------------+------------------------------------------------- Reporter: | Owner: goldfire | Status: closed Type: bug | Milestone: 7.8.1 Priority: | Version: 7.7 normal | Keywords: TemplateHaskell TypeFamilies Component: | PolyKinds Compiler | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown fixed | Blocked By: Operating System: | Related Tickets: Unknown/Multiple | Type of failure: | None/Unknown | Test Case: | th/T7477 | Blocking: | -------------------------+------------------------------------------------- Changes (by simonpj): * status: new => closed * testcase: => th/T7477 * resolution: => fixed Comment: Fixed at last. Simon -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/7477#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #4135: Can't Quote Instance Associated Types in Template Haskell
by GHC 06 Nov '13

06 Nov '13

#4135: Can't Quote Instance Associated Types in Template Haskell ----------------------------------------------+---------------------------- Reporter: Ashley Yakeley | Owner: Type: bug | Status: new Priority: low | Milestone: 7.6.2 Component: Template Haskell | Version: 6.12.1 Resolution: | Keywords: Operating System: Linux | Architecture: x86_64 Type of failure: GHC rejects valid program | (amd64) Test Case: th/T4135 | Difficulty: Unknown Blocking: | Blocked By: 4230 | Related Tickets: ----------------------------------------------+---------------------------- Comment (by Simon Peyton Jones <simonpj@…>): In [changeset:"7a318d7d3a1467251b3133c43f01c7372c32904e/testsuite"]: {{{ #!CommitTicketReference repository="testsuite" revision="7a318d7d3a1467251b3133c43f01c7372c32904e" Test for Trac #4135, comment 2 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4135#comment:17> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #7477: reifyInstances can't deal with polykinded type families
by GHC 06 Nov '13

06 Nov '13

#7477: reifyInstances can't deal with polykinded type families -------------------------+------------------------------------------------- Reporter: | Owner: goldfire | Status: new Type: bug | Milestone: 7.8.1 Priority: | Version: 7.7 normal | Keywords: TemplateHaskell TypeFamilies Component: | PolyKinds Compiler | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------+------------------------------------------------- Comment (by Simon Peyton Jones <simonpj@…>): In [changeset:"37158ff9ee3603c863eee8dcdfd196750fe8847a/testsuite"]: {{{ #!CommitTicketReference repository="testsuite" revision="37158ff9ee3603c863eee8dcdfd196750fe8847a" Test Trac #7477 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/7477#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0