April 2013 - ghc-tickets

Re: [GHC] #7190: GHC's -fprof-auto does not work with LINE pragmas
by GHC 12 Apr '13

12 Apr '13

#7190: GHC's -fprof-auto does not work with LINE pragmas ---------------------------------+------------------------------------------ Reporter: timthelion | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.8.1 Component: Profiling | Version: 7.4.2 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Changes (by igloo): * difficulty: => Unknown * component: Compiler => Profiling * milestone: => 7.8.1 Comment: Thanks for the report. We'll take a look. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7190#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

[GHC] #7827: GHC internal error: `a' is not in scope during type checking, but it passed the renamer
by GHC 12 Apr '13

12 Apr '13

#7827: GHC internal error: `a' is not in scope during type checking, but it passed the renamer --------------------------------------+------------------------------------- Reporter: guest | Owner: Type: bug | Status: new Priority: normal | Component: Compiler Version: 7.6.2 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: GHC rejects valid program | Blockedby: Blocking: | Related: --------------------------------------+------------------------------------- In the attached code the following lines give an internal GHC error. At least this should not happen. I also think this is valid code. Removing either type annotation makes this code compile. {{{ bug :: WrappedR Int -> SomeFunction bug (Wrap node) = case node of (Memo' (emptyT :: t a b) memoize (Var m) :: R' a b Int) -> -- also breaks }}} {{{ /Users/alessandro/Documents/Uni/thesis/test/bug-tvar-passed- renamer.hs:14:104: GHC internal error: `a' is not in scope during type checking, but it passed the renamer tcl_env of environment: [(am4, Identifier[node::R' a b Int, <NotTopLevel>, 1]), (rgs, Identifier[bug::WrappedR Int -> SomeFunction, <NotTopLevel>, 1])] In the type `R' a b Int' In a pattern type signature: R' a b Int In the pattern: Memo' (emptyT :: t a b) (memoize :: MVar (t a b) -> (a -> b) -> a -> b) (Var m :: R' a b Int) :: R' a b Int }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7827> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 6

Re: [GHC] #6135: Unboxed Booleans
by GHC 12 Apr '13

12 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by simonpj): Oh, ok. Then I suppose the path of least resistance is to stick with `Int#` throughout. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:44> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 12 Apr '13

12 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by jstolarek): I already took care of that a few weeks ago. We have logical primops that operate on Int# (andI#, orI#, xorI#, notI#) - see #7689. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:43> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 12 Apr '13

12 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by simonpj): Good idea (giving new names to the new ops). I've remembered why `Word#` is probably the right return type, not `Int#`: because we want to perform logical operations like `and` and `or` on the result of comparisons, and those work on `Word#` not `Int#`. So to me that argues for the primops all returning `Int#`. Simon M what do you say? Simon -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:42> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 12 Apr '13

12 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by jstolarek): Almost backward compatible that is - people will need to import GHC.PrimWrappers instead of GHC.Prim, but that's easier than changing all uses of primops. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:41> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 12 Apr '13

12 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by jstolarek): I just had this thought: how about we use the names of existing primops for wrappers and give new names to modified primops, e.g.: {{{ gtCharW# :: Char# -> Char# -> Word# -- Primop, new name gtChar# :: Char# -> Char# -> Bool -- Wrapper, old name }}} This way the change will be backwards compatible. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:40> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 11 Apr '13

11 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by simonmar): Definitely. I vote for the `Int#` versions, just because there's much less to change, and it's less likely to break anything. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:39> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 11 Apr '13

11 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by simonpj): True. But if `dataToTag#` returns `Int#` then so should `grChar#`. That is either {{{ dataToTag# :: a -> Int# grChar# :: Char# -> Char# -> Int# }}} or {{{ dataToTag# :: a -> Word# grChar# :: Char# -> Char# -> Word# }}} I don't mind which, but they should clearly be the same! Simon -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:38> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6135: Unboxed Booleans
by GHC 11 Apr '13

11 Apr '13

#6135: Unboxed Booleans ---------------------------------+------------------------------------------ Reporter: benl | Owner: jstolarek Type: feature request | Status: patch Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: None/Unknown Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: #605 | ---------------------------------+------------------------------------------ Comment(by simonmar): Replying to [comment:31 benl]: > there is really no reason to suggest that the result of a boolean comparison operator might be negative! I suspect the reason tagToEnum# currently takes an Int# is because literals like 5# are Int#. There's no reason to suggest that the result of a boolean comparison might be 3, yet `Word#` includes that value. I don't think `Int#` is any worse than `Word#` in including lots of impossible values, and furthermore there's a lot less friction to using `Int#` because everything else uses it. Just saying. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/6135#comment:37> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0