February 2015 - ghc-tickets

[GHC] #9912: Allow access to full logs in Harbormaster builds
by GHC 18 Sep '15

18 Sep '15

#9912: Allow access to full logs in Harbormaster builds -------------------------------------+------------------------------------- Reporter: goldfire | Owner: hvr Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: 7.8.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Harbormaster helpfully tries building every commit and every differential revision. However, when it fails, we only get the tail of the output, with no way to get more information. A case in point is [https://phabricator.haskell.org/harbormaster/build/2736/ this build], where a performance test case failed with `[stat too good]`. In this particular case, the commit is intended to be an optimization, so this failure is not terribly unexpected. I wanted to update `all.T` with the new figure, but I couldn't get the figure that Harbormaster's configuration had. Instead, I had to run the test on my machine (a Mac), get a different number, and hope that Harbormaster's configuration fell within 5% of mine. It did, in this case, but might not next time. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9912> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 6

[GHC] #9976: Ignore newlines in code diffs on Phab
by GHC 17 Sep '15

17 Sep '15

#9976: Ignore newlines in code diffs on Phab -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: feature | Status: new request | Milestone: Priority: low | Version: 7.8.4 Component: Trac & Git | Operating System: Unknown/Multiple Keywords: | Type of failure: None/Unknown Architecture: | Blocked By: Unknown/Multiple | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Doing code reviews in Phab is great. However, the way that the lint feature works encourages patchers to split lines as they means that more attention is drawn to split lines than perhaps should be. As a concrete example, I'm reading Phab:D538 this morning, and looking at line 402 of !DsArrows. Alan has added a new field to a data structure and needed to insert a `_` to make the code remain well typed... but this forced a line split to avoid a lint error. Now, I have to check if there are any changes in the second half of the line manually, because the character-diff highlighting fails after the line split. Is there a way to improve this behavior? I can think of two approaches: * (Better option) Teach the character-diff highlighting feature to look across linebreaks. * (Worse option) Encourage patchers ''not'' to make new line breaks until their final commit. Suppress lint problems about line breaks by request. This is, of course, minor, but it would certainly be nice! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9976> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 1

[GHC] #10035: Harbormaster doesn't post to Differential on success
by GHC 17 Sep '15

17 Sep '15

#10035: Harbormaster doesn't post to Differential on success -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: feature | Status: new request | Milestone: Priority: normal | Version: Component: Trac & Git | Operating System: Unknown/Multiple Keywords: | Type of failure: None/Unknown Architecture: | Blocked By: Unknown/Multiple | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- I recently posted a small diff to Phab to get a validate running (Phab:D630, if you must know). Harbormaster happily went and validated, but it never told me that it succeeded! Harbormaster's logs show the success, but I was waiting for an email (generated by activity on my diff, not sent directly from Harbormaster). If others think that this might be nice behavior, could we make this the default, the Harbormaster posts to Differential on success or failure? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10035> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 3

[GHC] #9782: Do not by default set ekmett as owner for 'Core libraries'
by GHC 17 Sep '15

17 Sep '15

#9782: Do not by default set ekmett as owner for 'Core libraries' -------------------------------------+------------------------------------- Reporter: thomie | Owner: hvr Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- And if possible, do a mass update of removing him from existing tickets: https://ghc.haskell.org/trac/ghc/query?component=Core+Libraries&owner=ekmett -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9782> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2

[GHC] #10033: Can't push to `wip/...` branches because of pre-commit check
by GHC 17 Sep '15

17 Sep '15

#10033: Can't push to `wip/...` branches because of pre-commit check -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: 7.8.4 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- I made some edits on my `wip/rae` branch and tried to push to the remote `wip/rae` branch. But I see this: {{{ 11:42:05 ~/Documents/Programming/ghc-cur> git push -u origin wip/rae --force Counting objects: 5, done. Delta compression using up to 2 threads. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 580 bytes | 0 bytes/s, done. Total 5 (delta 4), reused 0 (delta 0) remote: performing tab-check... remote: Error: you may not add a line containing a tab to these tab-free files: remote: testsuite/tests/rename/should_fail/Makefile To ssh://git@git.haskell.org/ghc.git ! [remote rejected] wip/rae -> wip/rae (pre-receive hook declined) error: failed to push some refs to 'ssh://git@git.haskell.org/ghc.git' }}} There are two problems here: 1. I didn't change `testsuite/tests/rename/should_fail/Makefile`! 2. `Makefile`s like having tabs in them. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10033> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 1

[GHC] #9855: Harbormaster uses the wrong code sometimes
by GHC 17 Sep '15

17 Sep '15

#9855: Harbormaster uses the wrong code sometimes -------------------------------------+------------------------------------- Reporter: goldfire | Owner: hvr Type: bug | Status: new Priority: normal | Milestone: Component: Trac & Git | Version: Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Harbormaster sometimes uses an inconsistent codebase for building, and then reports spurious build errors. A specific example is [https://phabricator.haskell.org/harbormaster/build/2444/ here]. The line where the error is reported is correct in the Differential view, but somehow Harbormaster is confused. Even stranger, this particular error could result only if ''part'' of a file were out-of-date. Something somewhere is trying to be awfully clever and failing. I know that sometimes I have deviated from any recommended Phab workflow. I attest that, to the best of my knowledge, I have not done so with this patch. It is based off my `origin/master`, and I have done no rebasing since posting on Phab. I have not pushed to the central GHC repo, but that doesn't appear to be necessary. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9855> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2

[GHC] #9710: Clean up Trac versions
by GHC 16 Sep '15

16 Sep '15

#9710: Clean up Trac versions -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: task | Status: new Priority: normal | Milestone: Component: Build System | Version: 7.8.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- The "Version" pull-down menu in Trac has no apparent ordering principle. This should be fixed. Even better, scrap many of the very old versions, as they're unsupported, anyway. Thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9710> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 3

[GHC] #10044: Wrong line number reported with CPP and line beginning with #
by GHC 16 Sep '15

16 Sep '15

#10044: Wrong line number reported with CPP and line beginning with # -------------------------------------+------------------------------------- Reporter: goldfire | Owner: Type: bug | Status: new Priority: low | Milestone: Component: Compiler | Version: 7.10.1-rc2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- If I compile {{{ {-# LANGUAGE CPP #-} module Bug where {- # hi there! -} * }}} I'm told of a parse error for the `*` on line 10. But that `*` is line 9! The problem is that, with `CPP` on, the line number counter gets confused if a line begins with a #, perhaps after whitespace. I actually hit this and was confused in real code. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/10044> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 4

[GHC] #9235: Simplifier ticks exhausted on recursive class method
by GHC 16 Sep '15

16 Sep '15

#9235: Simplifier ticks exhausted on recursive class method -----------------------------------+--------------------------------------- Reporter: klao | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.8.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Compile-time crash Unknown/Multiple | Test Case: Difficulty: Unknown | Blocking: Blocked By: | Related Tickets: | -----------------------------------+--------------------------------------- GHC 7.8 and HEAD panic on the following code: {{{#!haskell module C where class C a where c :: C a => a -> Int c a = c a {-# INLINE c #-} instance C () x :: Int x = c () }}} Note that it's the coincidence of the 3 conditions that triggers this bug: 1. the `c` method has to be inlined (explicity or implicitly) 2. it has to be recursive (but, it doesn't have to be as dumbly recursive as in the example) 3. it has to have this weird, slightly mistaken type signature: `C a => a -> Int` instead of simply `a -> Int`. But, when this incidentally happens (in my case, both 2. ''and'' 3. were unintentional), the user gets a very hard to debug issue. They don't even get an indication which module is responsible if `c` is used from a different module than the one with the class definition. Also note that this happens even with a non-optimized build. And in this example `c` has to be explicitly marked NOINLINE to prevent it. (In the instance that I caught in the wild simply removing the INLINE annotation was enough.) Finally, on a side note: shouldn't 3. by itself be an error? Or a warning at least? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9235> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2

[GHC] #9925: ghc internal error while installing hakyll
by GHC 16 Sep '15

16 Sep '15

#9925: ghc internal error while installing hakyll ----------------------------------+---------------------------------------- Reporter: fvictorio | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Keywords: | Operating System: Linux Architecture: x86_64 (amd64) | Type of failure: Runtime crash Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: ----------------------------------+---------------------------------------- Tried to install hakyll on Ubuntu 14.04 {{{ cabal update cabal install hakyll }}} Error during installation: {{{ [55 of 69] Compiling Text.Pandoc.Writers.OpenDocument ( src/Text/Pandoc/Writers/OpenDocument.hs, dist/build/Text/Pandoc/Writers/OpenDocument.o ) ghc: internal error: evacuate: strange closure type 15574408 (GHC version 7.6.3 for x86_64_unknown_linux) Please report this as a GHC bug: http://www.haskell.org/ghc/reportabug }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9925> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2