November 2018 - ghc-tickets

[GHC] #15925: Production quality bindists for hadrian
by GHC 27 Nov '18

27 Nov '18

#15925: Production quality bindists for hadrian -------------------------------------+------------------------------------- Reporter: alpmestan | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.7 (Hadrian) | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The bindists currently produced by hadrian are largely untested, especially on other platforms than linux. Moreover, we had not made a clear decision on what to do with respect to the relocatable GHCs that hadrian produces and wrapper scripts. We realized that everyone would be happy if: - the bindists follow the in-tree structure of `<build root>/stage1`, with `bin` containing the actual programs for most cases, etc. No wrapper script just yet. This way we can just unpack the archive and call `bin/ghc`. We still perhaps need to generate a script for ghci, but that's not really a wrapper, it's just a special case of `ghc` really. - `./configure && make install` would systematically generate wrapper scripts and install everything the way we do in our current bindists. I will look into getting this to work soon and will use this ticket to report progress. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15925> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 3

[GHC] #15812: add System.Mem.Address to base
by GHC 26 Nov '18

26 Nov '18

#15812: add System.Mem.Address to base -------------------------------------+------------------------------------- Reporter: carter | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: | Version: 8.7 libraries/base | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): D5268 | Wiki Page: -------------------------------------+------------------------------------- per libraries in progress discussion and https://phabricator.haskell.org/D5268 current state is this {{{ {-# LANGUAGE MagicHash #-} Module System.Mem.Address ( -- * Types Addr(..), -- * Address arithmetic nullAddr, plusAddr, minusAddr, remAddr, -- * Conversion addrToInt, addrToPtr, ptrToAddr ) where import GHC.Base ( Int(..) ) import GHC.Prim import GHC.Exts (isTrue#) import GHC.Ptr import Foreign.Marshal.Utils import Data.Typeable ( Typeable ) import Data.Data ( Data(..), mkNoRepType ) -- | A machine address data Addr = Addr Addr# deriving ( Typeable ) instance Show Addr where showsPrec _ (Addr a) = showString "0x" . showHex (fromIntegral (I# (addr2Int# a)) :: Word) instance Eq Addr where Addr a# == Addr b# = isTrue# (eqAddr# a# b#) Addr a# /= Addr b# = isTrue# (neAddr# a# b#) instance Ord Addr where Addr a# > Addr b# = isTrue# (gtAddr# a# b#) Addr a# >= Addr b# = isTrue# (geAddr# a# b#) Addr a# < Addr b# = isTrue# (ltAddr# a# b#) Addr a# <= Addr b# = isTrue# (leAddr# a# b#) instance Data Addr where toConstr _ = error "toConstr" gunfold _ _ = error "gunfold" dataTypeOf _ = mkNoRepType "Data.Primitive.Types.Addr" -- | The null address nullAddr :: Addr nullAddr = Addr nullAddr# infixl 6 `plusAddr`, `minusAddr` infixl 7 `remAddr` -- | Offset an address by the given number of bytes plusAddr :: Addr -> Int -> Addr plusAddr (Addr a#) (I# i#) = Addr (plusAddr# a# i#) -- | Distance in bytes between two addresses. The result is only valid if the -- difference fits in an 'Int'. minusAddr :: Addr -> Addr -> Int minusAddr (Addr a#) (Addr b#) = I# (minusAddr# a# b#) -- | The remainder of the address and the integer. remAddr :: Addr -> Int -> Int remAddr (Addr a#) (I# i#) = I# (remAddr# a# i#) -- | Convert an 'Addr' to an 'Int'. addrToInt :: Addr -> Int {-# INLINE addrToInt #-} addrToInt (Addr addr#) = I# (addr2Int# addr#) -- | convert `Addr` to `Ptr a` addrToPtr :: Addr -> Ptr a addrToPtr (Addr addr#) = Ptr addr# -- | convert `Ptr a` to `Addr` ptrToAddr :: Ptr a -> Addr ptrToAddr (Ptr p) = Addr p }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15812> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 5

[GHC] #15955: Cannot get debugging symbols for compiled c-sources
by GHC 26 Nov '18

26 Nov '18

#15955: Cannot get debugging symbols for compiled c-sources -------------------------------------+------------------------------------- Reporter: nh2 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Compiler | Version: 8.2.2 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I cannot for my life figure out how to pass `-g` to some cabal-file `c-sources`'s compilation. I've tried putting various combinations into `ghc-options`, but for the cases where compilation runs through, debugging symbols are not present, and for all other cases the assembler crashes, with the message as shown in my little survey of flags and whether they end up at `as` (as determined via `strace`): {{{ Using ghc-8.2.2 -g -optc-g -opta-g -optc-Wa,-g -opta-Wa,-g passes -g to as -g -optc-g -opta-g -optc-Wa,-g does not pass -g to as -g -optc-g -opta-g -opta-Wa,-g passes -g to as -optc-g -opta-g -opta-Wa,-g does not pass -g to as -g -opta-g -opta-Wa,-g passes --gdwarf2 and -g to as -g -opta-Wa,-g passes -g to as (and no --gdwarf2) -g -opta-g passes --gdwarf2 to as, but no -g However, in all 3 cases above the build fails with /tmp/ghc6595_0/ghc_4.s:444:0: error: Error: file number 1 already allocated | 444 | .file 1 "src/Codec/Compression/LZ4/Conduit.hsc" | ^ `gcc' failed in phase `Assembler'. (Exit code: 1) }}} (copied from https://gist.github.com/nh2/b57ed4c419f7b13d7cc299caa335f3ab) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15955> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 4

[GHC] #12965: String merging broken on Windows
by GHC 26 Nov '18

26 Nov '18

#12965: String merging broken on Windows ----------------------------------------+--------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Windows Architecture: Unknown/Multiple | Type of failure: None/Unknown Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: ----------------------------------------+--------------------------------- #9577 introduced string literal merging via the linker. Unfortunately I haven't been able to get this to function on Windows, resulting in testsuite failures of #9577. Even `gcc` appears to do the wrong thing here, {{{ $ cat hi.c #include <stdio.h> const char *hi = "hello world"; extern const char *hi2; void main() { printf("%p %p", hi, hi2); } $ cat hi2.c const char *hi2 = "hello world"; $ gcc -c hi.c; gcc -c hi2.c; gcc -fmerge-all-constants hi2.o hi.o $ ./a.exe 0x100403040 0x100403030 $ gcc -s hi2.c $ cat hi2.s .file "hi2.c" .globl hi .section .rdata,"dr" .LC0: .ascii "hello world\0" .data .align 8 hi: .quad .LC0 .ident "GCC: (GNU) 5.3.0" }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12965> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 10

[GHC] #14482: GHC -M mode fails to ensure that boot files are built before source files
by GHC 26 Nov '18

26 Nov '18

#14482: GHC -M mode fails to ensure that boot files are built before source files -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.2.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Imagine we have a module with a boot file. In general it is necessary to ensure that we compile the boot file *before* the source file to ensure that the `hi-boot` file exists when we go to typecheck the module (triggering the behavior observed in #14481). However, `ghc -M` doesn't guarantee this. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14482> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 7

[GHC] #15019: Fix performance regressions from #14737
by GHC 26 Nov '18

26 Nov '18

#15019: Fix performance regressions from #14737 -------------------------------------+------------------------------------- Reporter: tdammers | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Compile-time Unknown/Multiple | performance bug Test Case: | Blocked By: Blocking: | Related Tickets: #14737 Differential Rev(s): D4568 | Wiki Page: -------------------------------------+------------------------------------- #14737, while drastically improving performance on some edge cases, introduces performance regressions in 3 test cases: perf/compiler/parsing001.run perf/compiler/T9020.run perf/compiler/T12707.run -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15019> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 27

[GHC] #15366: GHC.Conc.Windows has a surprising queue
by GHC 26 Nov '18

26 Nov '18

#15366: GHC.Conc.Windows has a surprising queue -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: Core | Version: 8.4.3 Libraries | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Runtime Unknown/Multiple | performance bug Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- `GHC.Conc.Windows` seems to use `[DelayReq]` as a priority queue, and uses `foldr` to insert multiple elements into it. Unless these lists are always very short (are they?) that seems like a bad idea. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15366> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 4

[GHC] #15732: getArgsWithResponseFiles does not filter out RTS options
by GHC 26 Nov '18

26 Nov '18

#15732: getArgsWithResponseFiles does not filter out RTS options -------------------------------------+------------------------------------- Reporter: ckoparkar | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.8.1 Component: | Version: 8.6.1 libraries/base | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect result Unknown/Multiple | at runtime Test Case: | Blocked By: Blocking: | Related Tickets: #13896 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I discovered this while working on a fix for #15072. {{{GHC.ResponseFile.getArgsWithResponseFiles}}} is a recent addition to {{{base-4.12}}}. The idea was to have a function which could read command- line arguments supplied via response files, but otherwise would behave exactly like `System.Environment.getArgs` (see #13896). However, these functions return different results when RTS options are supplied. 1. {{{getArgs}}} does not include RTS options in the list it returns. 2. {{{getArgsWithResponseFiles}}} includes them. It's trivial to reproduce this. Consider these files: {{{ -- Bug1.hs module Main where import System.Environment ( getArgs ) main :: IO () main = do args <- getArgs putStrLn $ "Args: " ++ show args }}} and {{{ -- Bug2.hs module Main where import GHC.ResponseFile ( getArgsWithResponseFiles ) main :: IO () main = do args <- getArgsWithResponseFiles putStrLn $ "ArgsResp: " ++ show args }}} And run them with: {{{#!sh $ ghc-8.6.1 -rtsopts Bug1.hs && ghc-8.6.1 -rtsopts Bug2.hs $ ./Bug1 1 +RTS -H32m -RTS 10 20 Args: ["1","10","20"] -- 'opts_file' contains the same arguments passed to Bug1, and we -- use a '@' to pass it as a response file $ ./Bug2 @opts_file ArgsResp: ["1","+RTS","-H32m","-RTS","10","20"] }}} We should fix {{{getArgsWithResponseFiles}}} to properly handle {{{+RTS ... -RTS}}} and {{{--RTS}}} flags. Currently, {{{getArgs}}} relies on the [http://git.haskell.org/ghc.git/blob/HEAD:/rts/RtsFlags.c#l661 runtime system] for filtering out appropriate things. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15732> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 4

[GHC] #14534: Split T12971 into its own Makefile
by GHC 26 Nov '18

26 Nov '18

#14534: Split T12971 into its own Makefile -------------------------------------+------------------------------------- Reporter: dfeuer | Owner: (none) Type: task | Status: new Priority: low | Milestone: 8.6.1 Component: Test Suite | Version: 8.2.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Other Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- `testsuite/tests/driver/Makefile` includes the `T12971` target. This (intentionally) has non-ASCII characters in it. As a result, any change to that makefile will trigger a lint error. We should give that test its own makefile to isolate it a bit. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14534> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 4

[GHC] #15484: MultiLayerModules and T13701 timeout on i386 Linux
by GHC 26 Nov '18

26 Nov '18

#15484: MultiLayerModules and T13701 timeout on i386 Linux -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.4.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- CircleCI's Linux/i386 configuration fails with timeouts on `MultiLayerModules`, `T13701`, -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/15484> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 6