- ghc-tickets - Haskell.org

Re: [GHC] #3064: Very long compile times with type functions
by GHC 24 Dec '14

24 Dec '14

#3064: Very long compile times with type functions -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: closed Priority: low | Milestone: 7.12.1 Component: Compiler | Version: 6.10.1 (Type checker) | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: Compile- | Related Tickets: time performance bug | Test Case: | perf/compiler/T3064 | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by goldfire): * milestone: 7.6.1 => 7.12.1 Comment: From the second-to-last bullet point in Simon's commit message, it looks like this is a breaking change and should not be merged into 7.10 since RC1 is already out. I have to say the breakage is a little disappointing here. Here is the real-life example from the Note: {{{ class Ord r => UserOfRegs r a where ... (i1) instance UserOfRegs r a => UserOfRegs r (Maybe a) where ... (i2) instance (Ord r, UserOfRegs r CmmReg) => UserOfRegs r CmmExpr where ... }}} Note the `Ord r` constraint in `(i2)`, which is newly-required by this change. What's disappointing here is that `Ord r` is "obviously" derivable from `UserOfRegs r CmmReg`! While I understand the reasoning in the Note (that `UserOfRegs r CmmReg` is not strictly smaller than the instance head, and therefore looking in its superclasses might, in perverse but realistic scenarios, might cause the superclass dictionary to loop), it's far from obvious from a user standpoint. Is it possible to alert the user to this problem in an error message? It seems, from the diff, that this is not yet done. And, should this perhaps be the first 7.12 release note? As it's a breaking change, I do think it should be called out in the user manual. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/3064#comment:20> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #3064: Very long compile times with type functions
by GHC 24 Dec '14

24 Dec '14

#3064: Very long compile times with type functions -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: bug | Status: closed Priority: low | Milestone: 7.6.1 Component: Compiler | Version: 6.10.1 (Type checker) | Keywords: Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: Compile- | Related Tickets: time performance bug | Test Case: | perf/compiler/T3064 | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by carter): should this be merged into the 7.10 branch or remilestoned for 7.12 only? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/3064#comment:19> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #3064: Very long compile times with type functions
by GHC 24 Dec '14

24 Dec '14

#3064: Very long compile times with type functions -------------------------------------------------+------------------------- Reporter: simonpj | Owner: Type: bug | Status: Priority: low | closed Component: Compiler (Type checker) | Milestone: 7.6.1 Resolution: fixed | Version: Operating System: Unknown/Multiple | 6.10.1 Type of failure: Compile-time performance bug | Keywords: Test Case: perf/compiler/T3064 | Architecture: Blocking: | Unknown/Multiple | Difficulty: | Unknown | Blocked By: | Related Tickets: -------------------------------------------------+------------------------- Comment (by Simon Peyton Jones <simonpj@…>): In [changeset:"a6f0f5ab45b2643b561e0a0a54a4f14745ab2152/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="a6f0f5ab45b2643b561e0a0a54a4f14745ab2152" Eliminate so-called "silent superclass parameters" The purpose of silent superclass parameters was to solve the awkward problem of superclass dictinaries being bound to bottom. See THE PROBLEM in Note [Recursive superclasses] in TcInstDcls Although the silent-superclass idea worked, * It had non-local consequences, and had effects even in Haddock, where we had to discard silent parameters before displaying instance declarations * It had unexpected peformance costs, shown up by Trac #3064 and its test case. In monad-transformer code, when constructing a Monad dictionary you had to pass an Applicative dictionary; and to construct that you neede a Functor dictionary. Yet these extra dictionaries were often never used. (All this got much worse when we added Applicative as a superclass of Monad.) Test T3064 compiled *far* faster after silent superclasses were eliminated. * It introduced new bugs. For example SilentParametersOverlapping, T5051, and T7862, all failed to compile because of instance overlap directly because of the silent-superclass trick. So this patch takes a new approach, which I worked out with Dimitrios in the closing hours before Christmas. It is described in detail in THE PROBLEM in Note [Recursive superclasses] in TcInstDcls. Seems to work great! Quite a bit of knock-on effect * The main implementation work is in tcSuperClasses in TcInstDcls Everything else is fall-out * IdInfo.DFunId no longer needs its n-silent argument * Ditto IDFunId in IfaceSyn * Hence interface file format changes * Now that DFunIds do not have silent superclass parameters, printing out instance declarations is simpler. There is tiny knock-on effect in Haddock, so that submodule is updated * I realised that when computing the "size of a dictionary type" in TcValidity.sizePred, we should be rather conservative about type functions, which can arbitrarily increase the size of a type. Hence the new datatype TypeSize, which has a TSBig constructor for "arbitrarily big". * instDFunType moves from TcSMonad to Inst * Interestingly, CmmNode and CmmExpr both now need a non-silent (Ord r) in a couple of instance declarations. These were previously silent but must now be explicit. * Quite a bit of wibbling in error messages }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/3064#comment:18> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2189: hSetBuffering stdin NoBuffering doesn't work on Windows
by GHC 24 Dec '14

24 Dec '14

#2189: hSetBuffering stdin NoBuffering doesn't work on Windows -------------------------------------+------------------------------------- Reporter: FalconNL | Owner: ekmett Type: bug | Status: new Priority: normal | Milestone: 7.12.1 Component: Core | Version: 6.8.2 Libraries | Keywords: hsetbuffering Resolution: | buffering buffer Operating System: Windows | Architecture: x86 Type of failure: | Difficulty: Unknown None/Unknown | Blocked By: Test Case: | Related Tickets: Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * cc: ryan.gl.scott@…, core-libraries-committee@… (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2189#comment:43> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

[GHC] #9876: mkdir errors when running `make sdist`
by GHC 23 Dec '14

23 Dec '14

#9876: mkdir errors when running `make sdist` -------------------------------------+------------------------------------- Reporter: joehillen | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.9 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Easy (less than 1 | Type of failure: hour) | None/Unknown Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- Hi. Newcomer here. I was taking a look at #9095 and I get the following errors when running `make sdist`. {{{ "rm" -f sdistprep/ghc-7.9.20141208-windows-extra-src.tar.bz2 mkdir sdistprep mkdir: cannot create directory ‘sdistprep’: File exists make[1]: [sdist-windows-tarballs-prep] Error 1 (ignored) mkdir sdistprep/windows-tarballs mkdir sdistprep/windows-tarballs/ghc-7.9.20141208 mkdir sdistprep/windows-tarballs/ghc-7.9.20141208/ghc-tarballs cd sdistprep/windows-tarballs/ghc-7.9.20141208/ghc-tarballs && lndir /home/joe/src/ghc/ghc-tarballs "rm" -rf sdistprep/windows-tarballs/ghc-7.9.20141208/ghc-tarballs/.git cd sdistprep/windows-tarballs && "/bin/tar" chf - ghc-7.9.20141208 2> windows_extra_src_ghc_log | bzip2 -c > /home/joe/src/ghc/sdistprep/ghc-7.9.20141208-windows-extra-src.tar.bz2 "rm" -rf sdistprep/testsuite-ghc "rm" -f sdistprep/ghc-7.9.20141208-testsuite.tar.bz2 mkdir sdistprep mkdir: cannot create directory ‘sdistprep’: File exists make[1]: [sdist-testsuite-prep] Error 1 (ignored) mkdir sdistprep/testsuite-ghc mkdir sdistprep/testsuite-ghc/ghc-7.9.20141208 mkdir sdistprep/testsuite-ghc/ghc-7.9.20141208/testsuite cd sdistprep/testsuite-ghc/ghc-7.9.20141208/testsuite && lndir /home/joe/src/ghc/testsuite /home/joe/src/ghc/testsuite: No such file or directory make[1]: *** [sdist-testsuite-prep] Error 1 make: *** [sdist] Error 2 }}} Generally when using 'mkdir' in a Makefile I've found it best to always use 'mkdir -p' just like you should how you should always use 'rm -f'. It's a simple fix. I'm submitting a patch for it. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9876> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 7

[GHC] #9879: Panic with partial type signatures
by GHC 23 Dec '14

23 Dec '14

#9879: Panic with partial type signatures -------------------------------------+------------------------------------- Reporter: monoidal | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler (Type | Version: 7.9 checker) | Operating System: Keywords: | Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: GHCi crash Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Attempting to check kind of type hole `_` in GHCi or putting it in a TH quotation causes a panic `rnHsTyKi HsWildcardTy`: {{{ :kind _ let x = [t|_|] }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9879> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 5

[GHC] #9744: Make program name and project version configurable
by GHC 23 Dec '14

23 Dec '14

#9744: Make program name and project version configurable -------------------------------------+------------------------------------- Reporter: luite | Owner: luite Type: feature request | Status: new Priority: normal | Milestone: 7.10.1 Component: Compiler | Version: 7.9 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- GHC uses `cProjectVersion` in a few places and `ghc` is hardcoded as the program name. This is used for example for determining the location of the user package database (`getAppUserDataDirectory "ghc"`) and the names of dynamic libraries. I've been working around this for GHCJS, but it requires copying quite a bit of code. I have a patch that adds the program name and version to `Settings` that I'll submit once I've tested GHCJS with HEAD. My patch just allows these settings to be changed by GHC API clients. However, we could also make GHC itself read its own values from the `settings` file. This way we could add a version tag to a GHC installation without recompiling, keeping its packages and package databases separate from existing ones. Let me know if there's any interest in this and I'll add it to the patch. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9744> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 4

[GHC] #9751: add runMeta Hook or TcM variant of hscCompileCoreExprHook
by GHC 23 Dec '14

23 Dec '14

#9751: add runMeta Hook or TcM variant of hscCompileCoreExprHook -------------------------------------+------------------------------------- Reporter: luite | Owner: luite Type: task | Status: new Priority: normal | Milestone: 7.10.1 Component: GHC API | Version: 7.8.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- GHCJS has to jump through hoops to make annotations work and to get the necessary information for linking a TH splice. The main reason is that `hscCompileCoreExprHook` does not expose the `TcM` environment. Easiest fix would be to add {{{#!hs hscCompileCoreExprTcMHook :: HscEnv -> SrcSpan -> CoreExpr -> TcM HValue }}} to `Hooks`, but it'd be better to hook `runMeta` instead. Unfortunately `runMeta` is polymorphic, so it could be more tricky. I'm going to see if I can hook `runMeta` in a reasonable way, and if I run out of time for 7.10.1, send a patch with `hscCompileCoreExprTcMHook` instead. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9751> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 2

[GHC] Batch modify: #229, #609, #849, #888, #1216, #1349, #1466, #1544, #1620, #1965, #2189, #2408, #2725, #3055, #3085, #3217, #3231, #3242, #3379, #3831, #3927, #3984, #4012, #4092, #4102, #4211, #4243, #4245, #4259, #4295, #4372, #4374, #4385, #4451, #4470, #4879, #4900, #4937, #5075, #5108, #5143, #5218, #5239, #5289, #5320, #5355, #5364, #5369, #5392, #5429, #5444, #5463, #5467, #5470, #5522, #5539, #5542, #5556, #5567, #5590, #5615, #5619, #5620, #5641, #5642, #5645, #5646, #5666, #5672, #5692, #5702,
by GHC 23 Dec '14

23 Dec '14

Batch modification to #229, #609, #849, #888, #1216, #1349, #1466, #1544, #1620, #1965, #2189, #2408, #2725, #3055, #3085, #3217, #3231, #3242, #3379, #3831, #3927, #3984, #4012, #4092, #4102, #4211, #4243, #4245, #4259, #4295, #4372, #4374, #4385, #4451, #4470, #4879, #4900, #4937, #5075, #5108, #5143, #5218, #5239, #5289, #5320, #5355, #5364, #5369, #5392, #5429, #5444, #5463, #5467, #5470, #5522, #5539, #5542, #5556, #5567, #5590, #5615, #5619, #5620, #5641, #5642, #5645, #5646, #5666, #5672, #5692, #5702, #5757, #5761, #5775, #5777, #5780, #5786, #5791, #5807, #5813, #5821, #5823, #5834, #5835, #5840, #5902, #5916, #5927, #5928, #5941, #5945, #5954, #5972, #5985, #6004, #6017, #6024, #6037, #6040, #6047, #6070, #6079, #6087, #6089, #6092, #6101, #6107, #6113, #6124, #6132, #6166, #7044, #7045, #7048, #7056, #7057, #7063, #7066, #7078, #7081, #7098, #7103, #7104, #7105, #7109, #7114, #7133, #7140, #7141, #7152, #7158, #7161, #7169, #7181, #7190, #7198, #7204, #7240, #7245, #7246, #7253, #7258, #7259, #7275, #7277, #7283, #7285, #7289, #7296, #7297, #7300, #7305, #7307, #7316, #7330, #7331, #7335, #7337, #7353, #7367, #7371, #7373, #7374, #7378, #7380, #7388, #7389, #7395, #7398, #7401, #7413, #7414, #7428, #7430, #7437, #7443, #7450, #7459, #7461, #7473, #7492, #7494, #7495, #7503, #7511, #7535, #7539, #7542, #7543, #7593, #7596, #7604, #7606, #7608, #7610, #7611, #7621, #7624, #7625, #7634, #7635, #7637, #7644, #7647, #7650, #7655, #7660, #7665, #7666, #7668, #7669, #7670, #7672, #7687, #7695, #7723, #7741, #7746, #7763, #7765, #7779, #7789, #7790, #7803, #7808, #7810, #7828, #7829, #7836, #7849, #7883, #7983, #8010, #8014, #8034, #8036, #8107, #8144, #8198, #8199, #8226, #8229, #8238, #8252, #8272, #8281, #8285, #8288, #8321, #8323, #8362, #8379, #8398, #8405, #8422, #8423, #8429, #8457, #8489, #8581, #8594, #8623, #8657, #8694, #8695, #8731, #8732, #8733, #8746, #8751, #8761, #8767, #8793, #8827, #8910, #8920, #8922, #8971, #8976, #8981, #9014, #9022, #90 34, #9043, #9046, #9089, #9094, #9133, #9218, #9237, #9238, #9248, #9251, #9274, #9289, #9331, #9342, #9352, #9353, #9358, #9405, #9453, #9526, #9573, #9586, #9588, #9596, #9600, #9601, #9606, #9614, #9618, #9638, #9649, #9671, #9674, #9682, #9716, #9717, #9735, #9743, #9744, #9751, #9760, #9769, #9772, #9792, #9793, #9797, #9799, #9821, #9823, #9841, #9858, #9890, #9895, #9899, #9900, #9911 by thoughtpolice: milestone to 7.12.1 Comment: Moving to 7.12.1 milestone; if you feel this is an error and should be addressed sooner, please move it back to the 7.10.1 milestone. -- Tickets URL: <http://ghc.haskell.org/trac/ghc/query?id=229%2C609%2C849%2C888%2C1216%2C134… 98%2C7204%2C7240%2C7245%2C7246%2C7253%2C7258%2C7259%2C7275%2C7277%2C7283%2C7285%2C7289%2C7296%2C7297%2C7300%2C7305%2C7307%2C7316%2C7330%2C7331%2C7335%2C7337%2C7353%2C7367%2C7371%2C7373%2C7374%2C7378%2C7380%2C7388%2C7389%2C7395%2C7398%2C7401%2C7413%2C7414%2C7428%2C7430%2C7437%2C7443%2C7450%2C7459%2C7461%2C7473%2C7492%2C7494%2C7495%2C7503%2C7511%2C7535%2C7539%2C7542%2C7543%2C7593%2C7596%2C7604%2C7606%2C7608%2C7610%2C7611%2C7621%2C7624%2C7625%2C7634%2C7635%2C7637%2C7644%2C7647%2C7650%2C7655%2C7660%2C7665%2C7666%2C7668%2C7669%2C7670%2C7672%2C7687%2C7695%2C7723%2C7741%2C7746%2C7763%2C7765%2C7779%2C7789%2C7790%2C7803%2C7808%2C7810%2C7828%2C7829%2C7836%2C7849%2C7883%2C7983%2C8010%2C8014%2C8034%2C8036%2C8107%2C8144%2C8198%2C8199%2C8226%2C8229%2C8238%2C8252%2C8272%2C8281%2C8285%2C8288%2C8321%2C8323%2C8362%2C8379%2C8398%2C8405%2C8422%2C8423%2C8429%2C8457%2C8489%2C8581%2C8594%2C8623%2C8657%2C8694%2C8695%2C8731%2C8732%2C8733%2C8746%2C8751%2C8761%2C8767%2C8793%2C8827%2C8910%2C8920%2C8922%2C8971% 2C8976%2C8981%2C9014%2C9022%2C9034%2C9043%2C9046%2C9089%2C9094%2C9133%2C9218%2C9237%2C9238%2C9248%2C9251%2C9274%2C9289%2C9331%2C9342%2C9352%2C9353%2C9358%2C9405%2C9453%2C9526%2C9573%2C9586%2C9588%2C9596%2C9600%2C9601%2C9606%2C9614%2C9618%2C9638%2C9649%2C9671%2C9674%2C9682%2C9716%2C9717%2C9735%2C9743%2C9744%2C9751%2C9760%2C9769%2C9772%2C9792%2C9793%2C9797%2C9799%2C9821%2C9823%2C9841%2C9858%2C9890%2C9895%2C9899%2C9900%2C9911> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

[GHC] Batch modify: #1498, #2401, #2614, #3052, #3184, #3372, #3373, #3427, #3462, #3464, #3483, #3547, #3559, #3588, #3619, #3632, #3645, #3649, #3699, #3701, #3704, #3712, #3713, #3744, #3753, #3755, #3766, #3767, #3782, #3786, #3869, #3881, #3895, #3903, #3937, #3946, #3980, #3990, #4016, #4020, #4048, #4049, #4052, #4081, #4096, #4101, #4105, #4114, #4121, #4140, #4150, #4162, #4176, #4180, #4213, #4215, #4222, #4281, #4288, #4296, #4301, #4308, #4316, #4329, #4340, #4366, #4413, #4440, #4442, #4453, #4
by GHC 23 Dec '14

23 Dec '14

Batch modification to #1498, #2401, #2614, #3052, #3184, #3372, #3373, #3427, #3462, #3464, #3483, #3547, #3559, #3588, #3619, #3632, #3645, #3649, #3699, #3701, #3704, #3712, #3713, #3744, #3753, #3755, #3766, #3767, #3782, #3786, #3869, #3881, #3895, #3903, #3937, #3946, #3980, #3990, #4016, #4020, #4048, #4049, #4052, #4081, #4096, #4101, #4105, #4114, #4121, #4140, #4150, #4162, #4176, #4180, #4213, #4215, #4222, #4281, #4288, #4296, #4301, #4308, #4316, #4329, #4340, #4366, #4413, #4440, #4442, #4453, #4459, #4466, #4471, #4479, #4520, #4800, #4806, #4815, #4823, #4824, #4831, #4833, #4836, #4837, #4861, #4899, #4913, #4931, #4938, #4942, #4955, #4959, #4960, #4980, #5014, #5016, #5059, #5063, #5073, #5140, #5142, #5171, #5188, #5197, #5219, #5224, #5251, #5262, #5266, #5267, #5273, #5288, #5291, #5296, #5298, #5302, #5305, #5326, #5333, #5376, #5378, #5495, #5654, #5918, #5959, #8156, #8258, #8303, #8539, #8959, #9247, #9260, #9307 by thoughtpolice: milestone to 7.12.1 Comment: Moving to 7.12.1 milestone; if you feel this is an error and should be addressed sooner, please move it back to the 7.10.1 milestone. -- Tickets URL: <http://ghc.haskell.org/trac/ghc/query?id=1498%2C2401%2C2614%2C3052%2C3184%2…> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0