- ghc-tickets - Haskell.org

Re: [GHC] #1042: Floating point exception
by GHC 21 Sep '14

21 Sep '14

#1042: Floating point exception -------------------------------------+------------------------------------- Reporter: dons | Owner: Type: merge | Status: closed Priority: normal | Milestone: 6.6.1 Component: Compiler | Version: 6.6 Resolution: fixed | Keywords: Operating System: | Architecture: x86 Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: #8695 Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by dfeuer): Never mind. The check was elsewhere. Sorry folks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/1042#comment:13> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #1042: Floating point exception
by GHC 21 Sep '14

21 Sep '14

#1042: Floating point exception -------------------------------------+------------------------------------- Reporter: dons | Owner: Type: merge | Status: closed Priority: normal | Milestone: 6.6.1 Component: Compiler | Version: 6.6 Resolution: fixed | Keywords: Operating System: | Architecture: x86 Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: #8695 Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by dfeuer): * status: new => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/1042#comment:12> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #1042: Floating point exception
by GHC 21 Sep '14

21 Sep '14

#1042: Floating point exception -------------------------------------+------------------------------------- Reporter: dons | Owner: Type: merge | Status: new Priority: normal | Milestone: 6.6.1 Component: Compiler | Version: 6.6 Resolution: | Keywords: Operating System: | Architecture: x86 Unknown/Multiple | Difficulty: Unknown Type of failure: Incorrect | Blocked By: result at runtime | Related Tickets: #8695 Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by dfeuer): * owner: igloo => * status: closed => new * resolution: fixed => Comment: I'm sorry to reopen an 8 year old bug, but I tripped over this today while attempting (unsuccessfully, so far) to write a version of `divModInt` that plays nice with CSE: {{{#!hs divModInt :: Int -> Int -> (Int, Int) (I# x) `divModInt` (I# y) = case x `divModInt#` y of (# q, r #) -> (I# q, I# r) divModInt# :: Int# -> Int# -> (# Int#, Int# #) x# `divModInt#` y# = case x' `quotRemInt#` y# of (# q, r #) -> (# q +# qadj, r +# radj #) where (# x', qadj, radj #) = if | isTrue# (x# ># 0#) && isTrue# (y# <# 0#) -> (# x# -# 1#, -1#, y# +# 1# #) | isTrue# (x# <# 0#) && isTrue# (y# ># 0#) -> (# x# +# 1#, -1#, y# -# 1# #) | otherwise -> (# x#, 0#, 0# #) }}} When I test this with {{{#!hs main = print $ divModInt minBound (-1) }}} I get a floating point exception. `GHC.Base.divMod` does not trip over this, even though it seems to be doing exactly the same arithmetic. As far as I can tell, this is ''supposed'' to be handled by `quotRemInt#` -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/1042#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #5615: ghc produces poor code for `div` with constant powers of 2.
by GHC 21 Sep '14

21 Sep '14

#5615: ghc produces poor code for `div` with constant powers of 2. -------------------------------------+------------------------------------- Reporter: Lennart | Owner: daniel.is.fischer Type: bug | Status: new Priority: normal | Milestone: 7.10.1 Component: Compiler | Version: 7.4.1-rc1 Resolution: | Keywords: Operating System: | Architecture: x86 Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by dfeuer): Replying to [comment:17 thomie]: Here's an updated link to [http://research.microsoft.com/pubs/151917 /divmodnote-letter.pdf Daan Leijen's paper]. Euclidean div/mod, along with other benefits, works much better than Haskell div/mod with the idea I've been playing with of implementing `div`-like things and `mod`-like things using `divMod`-like things. In particular, CSE can do some really nifty stuff with either `quotRem` or `divModEuclidean`, but it has no hope with `divMod` (at least as it's currently implemented) in the general case, because the latter has complicated code that gets all torn up before it gets to CSE. I don't know if there's a way to fix that. It does work out if one or both of the operands is known and there's sufficient inlining. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/5615#comment:19> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #7863: Verbosity level for quieter Template Haskell
by GHC 21 Sep '14

21 Sep '14

#7863: Verbosity level for quieter Template Haskell -------------------------------------+------------------------------------- Reporter: dolio | Owner: hvr Type: feature | Status: closed request | Milestone: 7.10.1 Priority: low | Version: 7.6.3 Component: Template | Keywords: linker Haskell | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: #5647 Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D232 | -------------------------------------+------------------------------------- Changes (by hvr): * status: patch => closed * resolution: => fixed Comment: Please reopen if this is not what we want -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/7863#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #7863: Verbosity level for quieter Template Haskell
by GHC 21 Sep '14

21 Sep '14

#7863: Verbosity level for quieter Template Haskell -------------------------------------+------------------------------------- Reporter: dolio | Owner: hvr Type: feature | Status: patch request | Milestone: 7.10.1 Priority: low | Version: 7.6.3 Component: Template | Keywords: linker Haskell | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: #5647 Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D232 | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"9f7e3633c692dce75c27607131bd386178fb0fcf/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="9f7e3633c692dce75c27607131bd386178fb0fcf" Change linker message verbosity to `-v2` (re #7863) With this change, the linker status logging output such as Loading package ghc-prim ... linking ... done. Loading package integer-gmp ... linking ... done. Loading package base ... linking ... done. is suppressed unless verbosity level is `-v2` or higher. This is done to reduce the compiler message noise when TH is involved, which can reduce the visibiliy of compile warnings. Reviewed By: ekmett, austin Differential Revision: https://phabricator.haskell.org/D232 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/7863#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #7863: Verbosity level for quieter Template Haskell
by GHC 20 Sep '14

20 Sep '14

#7863: Verbosity level for quieter Template Haskell -------------------------------------+------------------------------------- Reporter: dolio | Owner: hvr Type: feature | Status: patch request | Milestone: 7.10.1 Priority: low | Version: 7.6.3 Component: Template | Keywords: linker Haskell | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: #5647 Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D232 | -------------------------------------+------------------------------------- Changes (by hvr): * status: new => patch * differential: => Phab:D232 Comment: There were only two testcases whose output needed tweaking, so I went ahead and submitted a code-rev -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/7863#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #4426: Simplify the rules for implicit quantification
by GHC 20 Sep '14

20 Sep '14

#4426: Simplify the rules for implicit quantification -------------------------------------+------------------------------------- Reporter: simonpj | Owner: Type: feature | Status: new request | Milestone: 7.12.1 Priority: highest | Version: 6.12.3 Component: Compiler | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #7880 None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D211 | -------------------------------------+------------------------------------- Changes (by hvr): * milestone: 7.10.1 => 7.12.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/4426#comment:19> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #7863: Verbosity level for quieter Template Haskell
by GHC 20 Sep '14

20 Sep '14

#7863: Verbosity level for quieter Template Haskell -------------------------------------+------------------------------------- Reporter: dolio | Owner: hvr Type: feature | Status: new request | Milestone: 7.10.1 Priority: low | Version: 7.6.3 Component: Template | Keywords: linker Haskell | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: #5647 Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by hvr): * owner: => hvr Comment: The actual change seems to be just a single character: {{{#!diff diff --git a/compiler/ghci/Linker.lhs b/compiler/ghci/Linker.lhs index 5b0251c..ecba45b 100644 --- a/compiler/ghci/Linker.lhs +++ b/compiler/ghci/Linker.lhs @@ -1292,7 +1292,7 @@ findFile mk_file_path (dir : dirs) \begin{code} maybePutStr :: DynFlags -> String -> IO () maybePutStr dflags s - = when (verbosity dflags > 0) $ + = when (verbosity dflags > 1) $ do let act = log_action dflags act dflags SevInteractive noSrcSpan defaultUserStyle (text s) }}} as `maybePutStr` is used for all linker-related progress logging output With that change, a GHCi session looks like {{{ $ inplace/bin/ghc-stage2 --interactive GHCi, version 7.9.20140919: http://www.haskell.org/ghc/ :? for help λ:2> Control.DeepSeq.rnf () () it :: () λ:3> }}} for comparison, here's what this looks like in GHC 7.8.3: {{{ GHCi, version 7.8.3: http://www.haskell.org/ghc/ :? for help Loading package ghc-prim ... linking ... done. Loading package integer-gmp ... linking ... done. Loading package base ... linking ... done. λ:2> Control.DeepSeq.rnf () Loading package array-0.5.0.0 ... linking ... done. Loading package deepseq-1.3.0.2 ... linking ... done. () it :: () λ:3> }}} If we want it that way, I'll go forward and adapt any testsuite wobbles this may have caused. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/7863#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #5647: CLI option to silence "Loading package foo ... linking ... done" output
by GHC 20 Sep '14

20 Sep '14

#5647: CLI option to silence "Loading package foo ... linking ... done" output -------------------------------------+------------------------------------- Reporter: hvr | Owner: Type: feature | Status: closed request | Milestone: 7.10.1 Priority: normal | Version: 7.2.1 Component: Compiler | Keywords: Resolution: duplicate | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #7863 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by hvr): * status: new => closed * difficulty: => Unknown * resolution: => duplicate * related: => #7863 Comment: Closing this ticket in favour of #7863 which sounds more promising -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/5647#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0