- ghc-tickets - Haskell.org

Re: [GHC] #2233: Overhaul System.Process
by GHC 21 Nov '13

21 Nov '13

#2233: Overhaul System.Process --------------------------------------+------------------------------------ Reporter: simonmar | Owner: simonmar Type: task | Status: patch Priority: normal | Milestone: _|_ Component: libraries/process | Version: 6.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by simonmar): Looks great, thanks for doing this! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2233#comment:19> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2301: Proper handling of SIGINT/SIGQUIT
by GHC 21 Nov '13

21 Nov '13

#2301: Proper handling of SIGINT/SIGQUIT -------------------------------------+------------------------------------- Reporter: duncan | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.8.1 Component: | Version: 6.12.3 libraries/process | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: POSIX | Difficulty: Unknown Type of failure: Incorrect result | Blocked By: at runtime | Related Tickets: Test Case: | #3994,#5766,#7229,#4274,#3318,#1619 Blocking: | -------------------------------------+------------------------------------- Comment (by simonmar): I think you're absolutely right to throw `UserInterrupt` locally. The only question is what to do if it propagates to the top of a `forkIO` thread. I think it would be good to note in the docs that `UserInterrupt` only causes the process to die if it propagates to the top of the main thread, so if this is a child thread you need to arrange to propagate it to the parent, say by using `async` instead of raw `forkIO`. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2301#comment:42> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2233: Overhaul System.Process
by GHC 20 Nov '13

20 Nov '13

#2233: Overhaul System.Process --------------------------------------+------------------------------------ Reporter: simonmar | Owner: simonmar Type: task | Status: patch Priority: normal | Milestone: _|_ Component: libraries/process | Version: 6.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"0faf513f7e3667246d40767d25d0871b49d95851/process"]: {{{ #!CommitTicketReference repository="process" revision="0faf513f7e3667246d40767d25d0871b49d95851" Document spawnProcess and spawnCommand (#2233) Authored-by: Duncan Coutts <duncan(a)well-typed.com> Signed-off-by: Herbert Valerio Riedel <hvr(a)gnu.org> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2233#comment:18> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2233: Overhaul System.Process
by GHC 20 Nov '13

20 Nov '13

#2233: Overhaul System.Process --------------------------------------+------------------------------------ Reporter: simonmar | Owner: simonmar Type: task | Status: patch Priority: normal | Milestone: _|_ Component: libraries/process | Version: 6.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"d53196e313023ce92a5181074b7bb2ab7d35b5f3/process"]: {{{ #!CommitTicketReference repository="process" revision="d53196e313023ce92a5181074b7bb2ab7d35b5f3" API cleanup with new functions and old "soft" deprecated Add callProcess, callCommand, spawnProcess, spawnCommand as per the design in #2233 (but not relying on any of the SIGCHLD stuff). Move the various pre-createProcess functions to a section at the bottom in the Haddock docs. Don't yet mark anything as deprecated. That can come later. Authored-by: Duncan Coutts <duncan(a)well-typed.com> Signed-off-by: Herbert Valerio Riedel <hvr(a)gnu.org> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2233#comment:16> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2233: Overhaul System.Process
by GHC 20 Nov '13

20 Nov '13

#2233: Overhaul System.Process --------------------------------------+------------------------------------ Reporter: simonmar | Owner: simonmar Type: task | Status: patch Priority: normal | Milestone: _|_ Component: libraries/process | Version: 6.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: None/Unknown | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: --------------------------------------+------------------------------------ Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"a2c3294223bf1f5a1887b4f1bb6e1534699f4eba/process"]: {{{ #!CommitTicketReference repository="process" revision="a2c3294223bf1f5a1887b4f1bb6e1534699f4eba" Reorder code sections to be rather clearer And move the deprecated things (as per #2233) to the end, out of the way. Authored-by: Duncan Coutts <duncan(a)well-typed.com> Signed-off-by: Herbert Valerio Riedel <hvr(a)gnu.org> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2233#comment:17> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2301: Proper handling of SIGINT/SIGQUIT
by GHC 20 Nov '13

20 Nov '13

#2301: Proper handling of SIGINT/SIGQUIT -------------------------------------+------------------------------------- Reporter: duncan | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.8.1 Component: | Version: 6.12.3 libraries/process | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: POSIX | Difficulty: Unknown Type of failure: Incorrect result | Blocked By: at runtime | Related Tickets: Test Case: | #3994,#5766,#7229,#4274,#3318,#1619 Blocking: | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"1b1f18b89d23094f4411be534c493a0da8aeadb9/process"]: {{{ #!CommitTicketReference repository="process" revision="1b1f18b89d23094f4411be534c493a0da8aeadb9" Add tests for the delegated control-C handling (#2301) Authored-by: Duncan Coutts <duncan(a)well-typed.com> Signed-off-by: Herbert Valerio Riedel <hvr(a)gnu.org> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2301#comment:40> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2301: Proper handling of SIGINT/SIGQUIT
by GHC 20 Nov '13

20 Nov '13

#2301: Proper handling of SIGINT/SIGQUIT -------------------------------------+------------------------------------- Reporter: duncan | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.8.1 Component: | Version: 6.12.3 libraries/process | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: POSIX | Difficulty: Unknown Type of failure: Incorrect result | Blocked By: at runtime | Related Tickets: Test Case: | #3994,#5766,#7229,#4274,#3318,#1619 Blocking: | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"3d8f9bb7f84c1fbb5efa62dd46daae44110ddb18/process"]: {{{ #!CommitTicketReference repository="process" revision="3d8f9bb7f84c1fbb5efa62dd46daae44110ddb18" Rename runGenProcess_ and leave a deprecated stub At least Cabal was using runGenProcess_, and the previous patches addressing #2301 changed its type already. So this adds a deprecated stub with the original type and the real function gets to have a less odd name. Authored-by: Duncan Coutts <duncan(a)well-typed.com> Signed-off-by: Herbert Valerio Riedel <hvr(a)gnu.org> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2301#comment:41> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #2301: Proper handling of SIGINT/SIGQUIT
by GHC 20 Nov '13

20 Nov '13

#2301: Proper handling of SIGINT/SIGQUIT -------------------------------------+------------------------------------- Reporter: duncan | Owner: Type: bug | Status: patch Priority: high | Milestone: 7.8.1 Component: | Version: 6.12.3 libraries/process | Keywords: Resolution: | Architecture: Unknown/Multiple Operating System: POSIX | Difficulty: Unknown Type of failure: Incorrect result | Blocked By: at runtime | Related Tickets: Test Case: | #3994,#5766,#7229,#4274,#3318,#1619 Blocking: | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"a0467f3ee892f5843c1ba98bcb9630e1e5b4863b/process"]: {{{ #!CommitTicketReference repository="process" revision="a0467f3ee892f5843c1ba98bcb9630e1e5b4863b" Implement delegated control-C handling on Unix (#2301) This is a generalisation of the SIGINT-ignoring that system and rawSystem do, to allow it to be used via the general createProcess. For the gory details of SIGINT handling, see http://www.cons.org/cracauer/sigint.html We implement the 'WCE' method described there. That important feature was only available to system and rawSystem (mirroring the C system() behaviour). These functions are very limited and indeed deprecated, so we need this feature in general. In particular projects like Cabal are suffering because they cannot do this properly (or need horrible workarounds copy and pasting much of System.Process and using System.Process.Internals). The feature is available now via a new delegate_ctlc flag in the CreateProcess options record. The use of signal handlers is still a little hairy, but probably better than before (for situations where there were multiple concurrent calls to system/rawSystem). One thing to note is that waitForProcess and getProcessExitCode can now throw the UserInterrupt exception. This is all documented in the haddock docs (both a short description and also the excruciating details). Authored-by: Duncan Coutts <duncan(a)well-typed.com> Signed-off-by: Herbert Valerio Riedel <hvr(a)gnu.org> }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/2301#comment:39> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #6056: INLINABLE pragma prevents worker-wrapper to happen.
by GHC 20 Nov '13

20 Nov '13

#6056: INLINABLE pragma prevents worker-wrapper to happen. --------------------------------------------+------------------------------ Reporter: milan | Owner: simonpj Type: bug | Status: new Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime performance bug | Unknown/Multiple Test Case: | Difficulty: Unknown Blocking: | Blocked By: | Related Tickets: --------------------------------------------+------------------------------ Comment (by simonpj): I agree that it's surprising and undesirable. The reason it happens is this. GHC keeps an "`Unfolding` inside each `Id`: * For INLINEABLE things it is the original user-written RHS * For w/w'd things it is the wrapper function But there's only ''one'' `Unfolding` for each `Id`, so we have to choose. As you point out, that is a pity. Solution is probably to keep two unfoldings, in effect. Thanks for pointing this out so clearly. Simon -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/6056#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0

Re: [GHC] #5395: Context reduction stack overflow without undecidable instances
by GHC 20 Nov '13

20 Nov '13

#5395: Context reduction stack overflow without undecidable instances -------------------------------------+------------------------------------- Reporter: guest | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.0.4 Resolution: | Keywords: type family, Operating System: Unknown/Multiple | termination Type of failure: GHC rejects | Architecture: Unknown/Multiple valid program | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------- Comment (by nomeata): BTW, the user guide still says the default is 20: http://www.haskell.org/ghc/docs/7.6.3/html/users_guide/flag- reference.html#idp39856880 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/5395#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler

1 0