Re: [GHC] #14588: GHC 8.2.1 allows bang patterns in let-bindings without -XBangPatterns

#14588: GHC 8.2.1 allows bang patterns in let-bindings without -XBangPatterns -------------------------------------+------------------------------------- Reporter: kmiyazato | Owner: (none) Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: GHC accepts | Unknown/Multiple invalid program | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D4270 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ryan Scott ): In [changeset:"9caf40e9d7233a2a6e78a0c4f2d2f13acbf804dd/ghc" 9caf40e9/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9caf40e9d7233a2a6e78a0c4f2d2f13acbf804dd" Fix #14588 by checking for more bang patterns Summary: Commit 372995364c52eef15066132d7d1ea8b6760034e6 inadvertently removed a check in the parser which rejected let-bindings with bang patterns, leading to #14588. This fixes it by creating a `hintBangPat` function to perform this check, and sprinkling it in the right places. Test Plan: make test TEST=T14588 Reviewers: bgamari, alanz, simonpj Reviewed By: bgamari, simonpj Subscribers: rwbarton, thomie, mpickering, carter GHC Trac Issues: #14588 Differential Revision: https://phabricator.haskell.org/D4270 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14588#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler