Re: [GHC] #16183: GHC HEAD regression: -ddump-splices incorrectly parenthesizes HsKindSig applications

#16183: GHC HEAD regression: -ddump-splices incorrectly parenthesizes HsKindSig applications -------------------------------------+------------------------------------- Reporter: RyanGlScott | Owner: (none) Type: bug | Status: merge Priority: normal | Milestone: 8.8.1 Component: Template Haskell | Version: 8.7 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Debugging | Unknown/Multiple information is incorrect | Test Case: th/T16183 Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | https://gitlab.haskell.org/ghc/ghc/merge_requests/121 -------------------------------------+------------------------------------- Comment (by Marge Bot ): In [changeset:"b1e569a54085bf1093b4f858f8c7c739e3be769b/ghc" b1e569a5/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="b1e569a54085bf1093b4f858f8c7c739e3be769b" Use sigPrec in more places in Convert and HsUtils Trac #16183 was caused by TH conversion (in `Convert`) not properly inserting parentheses around occurrences of explicit signatures where appropriate, such as in applications, function types, and type family equations. Solution: use `parenthesizeHsType sigPrec` in these places. While I was in town, I also updated `nlHsFunTy` to do the same thing. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16183#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler