Re: [GHC] #10007: Fix misattribution of Cost Centre profiles to lintAnnots

#10007: Fix misattribution of Cost Centre profiles to lintAnnots -------------------------------------+------------------------------------- Reporter: thoughtpolice | Owner: scpmw Type: bug | Status: new Priority: high | Milestone: 7.10.1 Component: Profiling | Version: 7.10.1-rc1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect result | Unknown/Multiple at runtime | Test Case: Blocked By: | Blocking: Related Tickets: #9961 | Differential Revisions: Phab:D616 | Phab:D636 -------------------------------------+------------------------------------- Comment (by Simon Marlow ): In [changeset:"daed18c35cda114d8a5303bcb645195e1fd397e3/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="daed18c35cda114d8a5303bcb645195e1fd397e3" Fix a profiling bug Summary: We were erroneously discarding SCCs on function-typed variables. These can affect the call stack, so we have to retain them. The bug was introduced during the recent SourceNote refactoring. This is an alternative to the fix proposed in D616. I also added the scc005 test from that diff, which works with this change. While I was here, I also fixed up the other profiling tests, marking a few as expect_broken_for(10037) where the opt/unopt output differs in non-fatal ways. Test Plan: profiling tests Reviewers: scpmw, ezyang, austin Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D636 GHC Trac Issues: #10007 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10007#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler