Re: [GHC] #14578: Incorrect parenthesization of types in -ddump-deriv

21 Dec 2017

      #14578: Incorrect parenthesization of types in -ddump-deriv
-------------------------------------+-------------------------------------
        Reporter:  RyanGlScott       |                Owner:  (none)
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:
       Component:  Compiler          |              Version:  8.2.2
      Resolution:                    |             Keywords:  deriving
Operating System:  Unknown/Multiple  |         Architecture:
 Type of failure:  Debugging         |  Unknown/Multiple
  information is incorrect           |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D4266
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ryan Scott ):

 In [changeset:"1bd91a7ac60eba3b0c019e2228f4b2b07f8cd5ad/ghc" 1bd91a7/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="1bd91a7ac60eba3b0c019e2228f4b2b07f8cd5ad"
 Fix #14578 by checking isCompoundHsType in more places

 Summary:
 The `HsType` pretty-printer does not automatically insert
 parentheses where necessary for type applications, so a function
 `isCompoundHsType` was created in D4056 towards this purpose.
 However, it was not used in as many places as it ought to be,
 resulting in #14578.

 Test Plan: make test TEST=T14578

 Reviewers: alanz, bgamari, simonpj

 Reviewed By: alanz, simonpj

 Subscribers: simonpj, rwbarton, thomie, carter

 GHC Trac Issues: #14578

 Differential Revision: https://phabricator.haskell.org/D4266
 }}}

-- 
Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14578#comment:5
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler