Re: [GHC] #16046: -fno-stack-protector still necessary?

#16046: -fno-stack-protector still necessary? -------------------------------------+------------------------------------- Reporter: clumens | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Build System | Version: 8.4.3 (make) | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D5465 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"29ecb52033b951e09b6141aeb92460db2f4c3183/ghc" 29ecb520/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="29ecb52033b951e09b6141aeb92460db2f4c3183" aclocal.m4: drop obsolete -fno-stack-protector Summary: Initially -fno-stack-protector was added for openbsd specifically for ghc-6.5: changeset:f638fdfe1d9de1307355c8074fbff9c28342c0ef (2006) and later it was extended to cover osx: changeset:c2cd83e7d85c11e6a33e1cde263eb2312566d535 (2009) None of the reports hint at exact breakage. I guess both happened in -fvia-C mode where GHC's Evil Mangler had a chance to mangle stack canaries generated by fstack-protector. ghc has no evil mangler anymore and the change is not needed at least for C codegen. validated the patch on OpenBSD-6.4. No new failures compared to clean master branch. Signed-off-by: Sergei Trofimovich Test Plan: validated on OpenBSD Reviewers: bgamari Subscribers: rwbarton, erikd, carter GHC Trac Issues: #16046 Differential Revision: https://phabricator.haskell.org/D5465 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/16046#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler