Re: [GHC] #9616: Incorrect numbers from HpcMarkup.markup_plugin

1 Oct 2014

      #9616: Incorrect numbers from HpcMarkup.markup_plugin
-------------------------------------+-------------------------------------
              Reporter:  dfeuer      |            Owner:
                  Type:  bug         |           Status:  patch
              Priority:  normal      |        Milestone:
             Component:  Code        |          Version:  7.9
  Coverage                           |         Keywords:
            Resolution:              |     Architecture:  Unknown/Multiple
      Operating System:              |       Difficulty:  Easy (less than 1
  Unknown/Multiple                   |  hour)
       Type of failure:  Incorrect   |       Blocked By:
  result at runtime                  |  Related Tickets:
             Test Case:              |
              Blocking:              |
Differential Revisions:  Phab:D259   |
-------------------------------------+-------------------------------------

Comment (by Joachim Breitner ):

 In [changeset:"2a8856884de7d476e26b4ffa829ccb3a14d6f63e/ghc"]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="2a8856884de7d476e26b4ffa829ccb3a14d6f63e"
 Use dropWhileEndLE p instead of reverse . dropWhile p . reverse

 Summary: Using `dropWhileEndLE` tends to be faster and easier to read
 than the `reverse . dropWhile p . reverse` idiom. This also cleans up
 some other, nearby, messes. Fix #9616 (incorrect number formatting
 potentially leading to incorrect numbers in output).

 Test Plan: Run validate

 Reviewers: thomie, rwbarton, nomeata, austin

 Reviewed By: nomeata, austin

 Subscribers: simonmar, ezyang, carter, thomie

 Projects: #ghc

 Differential Revision: https://phabricator.haskell.org/D259

 GHC Trac Issues: #9623, #9616

 Conflicts:
         compiler/basicTypes/OccName.lhs
 }}}

--
Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9616#comment:4
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler