#10298: Infinite loop when shared libraries are unavailable
-------------------------------------+-------------------------------------
Reporter: snoyberg | Owner: simonmar
Type: bug | Status: closed
Priority: normal | Milestone: 7.10.2
Component: Runtime System | Version: 7.10.1
Resolution: duplicate | Keywords:
Operating System: Linux | Architecture: x86_64
Type of failure: Runtime crash | (amd64)
Blocked By: | Test Case:
Related Tickets: #7695 | Blocking:
| Differential Revisions: Phab:D898
-------------------------------------+-------------------------------------
Comment (by Ben Gamari ):
In [changeset:"d69dfba4e27c4ec33459906fd87c9a56a371f510/ghc"]:
{{{
#!CommitTicketReference repository="ghc"
revision="d69dfba4e27c4ec33459906fd87c9a56a371f510"
Fix self-contained handling of ASCII encoding
D898 was primarily intended to fix hangs in the event that iconv was
unavailable (namely #10298 and #7695). In addition to this fix, it also
introduced self-contained handling of ANSI terminals to allow compiled
executables to run in minimal environments lacking iconv.
However, the behavior that the patch introduced is highly suspicious.
Specifically, it gives the user a UTF-8 encoding even if they requested
ASCII.
This has the potential to break quite a lot of code. At very least it
breaks GHC's Unicode terminal detection logic, which attempts to catch
an invalid character when encoding a pair of smart-quotes. Of course,
this exception will never be thrown if a UTF-8 encoder is used.
Here we use the `char8` encoding to handle requests for ASCII encodings
in the event that we find iconv to be non-functional.
Fixes #10623.
Test Plan: Validate with T8959a
Reviewers: rwbarton, hvr, austin, hsyl20
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1059
GHC Trac Issues: #10623
}}}
--
Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10298#comment:13
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler
