Re: [GHC] #10942: CPP pragma ignored if top comments and Opt_KeepRawTokenStream

12 Nov 2015

      #10942: CPP pragma ignored if top comments and Opt_KeepRawTokenStream
-------------------------------------+-------------------------------------
        Reporter:  alanz             |                Owner:  mpickering
            Type:  bug               |               Status:  patch
        Priority:  normal            |            Milestone:  8.0.1
       Component:  Compiler          |              Version:  7.10.2
  (Parser)                           |
      Resolution:                    |             Keywords:
Operating System:  Unknown/Multiple  |         Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |            Test Case:
      Blocked By:                    |             Blocking:
 Related Tickets:                    |  Differential Rev(s):  Phab:D1444
       Wiki Page:                    |
-------------------------------------+-------------------------------------

Comment (by Ben Gamari ):

 In [changeset:"5d6133bec0f682e86ee31bbdb6d82e6fb2ede8f7/ghc" 5d6133b/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="5d6133bec0f682e86ee31bbdb6d82e6fb2ede8f7"
 Ignore comments in getOptions

 When Opt_KeepRawTokenStream is turned on then getOptions fails to find
 the language pragmas which can cause unexpected parse errors when using
 the GHC API. A simple solution is to make it skip over any comments in
 the token
 stream.

 Test Plan: ./validate

 Reviewers: austin, bgamari

 Subscribers: alanz, thomie

 Differential Revision: https://phabricator.haskell.org/D1444

 GHC Trac Issues: #10942
 }}}

--
Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10942#comment:7
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler