Re: [GHC] #10830: maximumBy has a space leak

3 Sep 2015

      #10830: maximumBy has a space leak
-------------------------------------+-------------------------------------
        Reporter:  NeilMitchell      |                   Owner:
            Type:  bug               |                  Status:  patch
        Priority:  normal            |               Milestone:
       Component:  libraries/base    |                 Version:  7.10.2
      Resolution:                    |                Keywords:
Operating System:  Windows           |            Architecture:
                                     |  Unknown/Multiple
 Type of failure:  None/Unknown      |               Test Case:
      Blocked By:                    |                Blocking:
 Related Tickets:                    |  Differential Revisions:  Phab:D1205
-------------------------------------+-------------------------------------

Comment (by Joachim Breitner ):

 In [changeset:"85915e9b73a662f3cc474323ec370d4f61817474/ghc" 85915e9/ghc]:
 {{{
 #!CommitTicketReference repository="ghc"
 revision="85915e9b73a662f3cc474323ec370d4f61817474"
 Make Data.List.foldr1 inline

 Previously, foldr1 would be defiend recursively and thus not inline.
 This is bad, for example, when maximumBy has a strict comparison
 function: Before the BBP, it was implemented via foldl1, which inlined
 and yielded good code. With BBP, it goes via foldr1, so we better inline
 this as well. Fixes #10830.

 Differential Revision: https://phabricator.haskell.org/D1205
 }}}

--
Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10830#comment:7
GHC http://www.haskell.org/ghc/
The Glasgow Haskell Compiler