Re: [GHC] #10256: parser: API Annotations : guardquals1 does not annotate commas properly

#10256: parser: API Annotations : guardquals1 does not annotate commas properly -------------------------------------+------------------------------------- Reporter: alanz | Owner: alanz Type: bug | Status: patch Priority: normal | Milestone: 7.10.2 Component: Compiler | Version: 7.10.1 (Parser) | Keywords: Resolution: | ApiAnnotations Operating System: Unknown/Multiple | Architecture: Type of failure: None/Unknown | Unknown/Multiple Blocked By: | Test Case: Related Tickets: | Blocking: | Differential Revisions: Phab:D818 -------------------------------------+------------------------------------- Comment (by Austin Seipp ): In [changeset:"9eab6feed44ad8beb6703d2e27ce47a8f79d0f49/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="9eab6feed44ad8beb6703d2e27ce47a8f79d0f49" parser: API Annotations : guardquals1 does not annotate commas properly The `guardquals1` production includes : guardquals1 ',' qual {% addAnnotation (gl $ last $ unLoc $1) AnnComma (gl $2) >> return (sLL $1 $> ($3 : unLoc $1)) } The AnnComma should be attached to `(gl $ head $ unLoc $1)`, rather than `last`. Reviewed By: austin Differential Revision: https://phabricator.haskell.org/D818 GHC Trac Issues: #10256 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/10256#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler