[GHC] #9826: add Storable Complex and Ratio instance to base library
#9826: add Storable Complex and Ratio instance to base library -------------------------------------+------------------------------------- Reporter: carter | Owner: carter Type: feature request | Status: new Priority: normal | Milestone: 7.10.1 Component: libraries/base | Version: 7.8.3 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- per the libraries discussion + core libraries committee OK, I'm putting a phab differential up for adding Storable instances for Complex and Ratio (and then noticing that theres basically NO tests for Storable except indirectly) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9826> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9826: add Storable Complex and Ratio instance to base library -------------------------------------+------------------------------------- Reporter: carter | Owner: carter Type: feature | Status: patch request | Milestone: 7.10.1 Priority: normal | Version: 7.8.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D519 | -------------------------------------+------------------------------------- Changes (by carter): * status: new => patch * differential: => Phab:D519 Comment: still need to add tests... but storable per se has no tests in base! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9826#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9826: add Storable Complex and Ratio instance to base library -------------------------------------+------------------------------------- Reporter: carter | Owner: carter Type: feature | Status: patch request | Milestone: 7.10.1 Priority: normal | Version: 7.8.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D519 | -------------------------------------+------------------------------------- Comment (by hvr): please add links to the libraries/CLC discussion threads in the ticket- description -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9826#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9826: add Storable Complex and Ratio instance to base library -------------------------------------+------------------------------------- Reporter: carter | Owner: carter Type: feature | Status: patch request | Milestone: 7.10.1 Priority: normal | Version: 7.8.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D519 | -------------------------------------+------------------------------------- Description changed by carter: Old description:
per the libraries discussion + core libraries committee OK, I'm putting a phab differential up for adding Storable instances for Complex and Ratio
(and then noticing that theres basically NO tests for Storable except indirectly)
New description: per the libraries discussion + core libraries committee OK, I'm putting a phab differential up for adding Storable instances for Complex and Ratio (and then noticing that theres basically NO tests for Storable except indirectly) the libraries thread for Complex and Ratio https://www.haskell.org/pipermail/libraries/2014-November/024064.html the thread on the CLC list https://groups.google.com/forum/#!topic /haskell-core-libraries/mjBSo2CQ3LU -- -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9826#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9826: add Storable Complex and Ratio instance to base library -------------------------------------+------------------------------------- Reporter: carter | Owner: carter Type: feature | Status: patch request | Milestone: 7.10.1 Priority: normal | Version: 7.8.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D519 | -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel <hvr@…>): In [changeset:"fb061c193947a7096471486faade1d0db30bc588/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="fb061c193947a7096471486faade1d0db30bc588" Add `Storable` instances for `Complex` and `Ratio` The actual type-signatures of the new instances are: instance Storable a => Storable (Complex a) instance (Storable a, Integral a) => Storable (Ratio a) See also https://groups.google.com/d/msg/haskell-core- libraries/mjBSo2CQ3LU/0gwg0QvviOIJ Addresses #9826 Reviewed By: ekmett Differential Revision: https://phabricator.haskell.org/D519 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9826#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9826: add Storable Complex and Ratio instance to base library -------------------------------------+------------------------------------- Reporter: carter | Owner: carter Type: feature | Status: closed request | Milestone: 7.10.1 Priority: normal | Version: 7.8.3 Component: | Keywords: libraries/base | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Unknown Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D519 | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9826#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC