[GHC] #14235: Suspiciously missing closure types in isRetainer
#14235: Suspiciously missing closure types in isRetainer -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: high | Milestone: 8.4.1 Component: Runtime | Version: 8.2.1 System | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- `RetainerProfile:isRetainer` has a switch on closure types which appears to be lacking several defined types. * `BLOCKING_QUEUE`: someone actually came into `#ghc` complaining about a crash due to this one * `WHITEHOLE` * `SMALL_MUT_ARR_PTRS_CLEAN` * `SMALL_MUT_ARR_PTRS_DIRTY` * `SMALL_MUT_ARR_PTRS_FROZEN0` * `SMALL_MUT_ARR_PTRS_FROZEN` * `COMPACT_NFDATA` -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14235> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14235: Suspiciously missing closure types in isRetainer -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: high | Milestone: 8.4.1 Component: Runtime System | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3967 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3967 Comment: Here is a patch, although it deserves careful review. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14235#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14235: Suspiciously missing closure types in isRetainer -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: patch Priority: high | Milestone: 8.4.1 Component: Runtime System | Version: 8.2.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3967 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"6252292d4f4061f6e55c7f92a399160147c4ca74/ghc" 6252292d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="6252292d4f4061f6e55c7f92a399160147c4ca74" rts/RetainerProfile: Adding missing closure types to isRetainer orzo in `#ghc` reported seeing a crash due to the retainer profiler encountering a BLOCKING_QUEUE closure, which isRetainer didn't know about. I performed an audit to make sure that all of the valid closure types were listed; they weren't. This is my guess of how they should appear. Test Plan: Validate Reviewers: simonmar, austin, erikd Reviewed By: simonmar Subscribers: rwbarton, thomie GHC Trac Issues: #14235 Differential Revision: https://phabricator.haskell.org/D3967 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14235#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14235: Suspiciously missing closure types in isRetainer -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: high | Milestone: 8.4.1 Component: Runtime System | Version: 8.2.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3967 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14235#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC