#11317: Test prog003 fails with segfault on Windows (GHCi) -------------------------------+-------------------------------------- Reporter: rdragon | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: Operating System: Windows | Architecture: x86_64 (amd64) Type of failure: GHCi crash | Test Case: Blocked By: | Blocking: Related Tickets: #11234 | Differential Rev(s): Wiki Page: | -------------------------------+-------------------------------------- Changes (by thomie): * cc: Phyx- (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Changes (by Phyx-): * keywords: => GC * testcase: => prog003 * architecture: x86_64 (amd64) => Unknown/Multiple * related: #11234 => #11234 #3408 Comment: This seems like it's related to #3408. The `GC` timeout `-I` is at fault. The default timeout for Windows was changed to 5secs in https://github.com/ghc/ghc/blob/master/ghc/hschooks.c#L42 to avoid issues with the `GC` and `haskeline` on Windows. Coincidentally I don't know why this was done there (which is rather hidden) rather than in `RtsFlags.c`. The helptext for RTS opts is also wrong (says the default is 0.3s for all platforms). In any case, the test is setting a value so low that it's causing a segfault. On a normal run the GC ends with {{{ Memory inventory: gen 0 blocks : 16 blocks ( 0.1 MB) gen 1 blocks : 5541 blocks ( 21.6 MB) nursery : 5379 blocks ( 21.0 MB) retainer : 0 blocks ( 0.0 MB) arena blocks : 0 blocks ( 0.0 MB) exec : 1 blocks ( 0.0 MB) free : 1411 blocks ( 5.5 MB) total : 12348 blocks ( 48.2 MB) 84f44: cap 0: all caps stopped for GC 84f44: cap 0: finished GC 84f44: exitHpc 84f44: cap 0: shutting down }}} but when it segfaults {{{ Memory inventory: gen 0 blocks : 51 blocks ( 0.2 MB) gen 1 blocks : 5470 blocks ( 21.4 MB) nursery : 5202 blocks ( 20.3 MB) retainer : 0 blocks ( 0.0 MB) arena blocks : 0 blocks ( 0.0 MB) exec : 1 blocks ( 0.0 MB) free : 3388 blocks ( 13.2 MB) total : 14112 blocks ( 55.1 MB) 84cd4: cap 0: all caps stopped for GC 84cd4: cap 0: finished GC }}} So GC does finish, but something happens between then and `exitHpc` -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: fixed | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Changes (by Phyx-): * status: new => closed * resolution: => fixed Comment: This commit seems to fix `prog003` as well. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Comment (by Ben Gamari ): In [changeset:"24a4fe2925d66e50b4f5e66e7a5c1ca4a320bf88/ghc" 24a4fe2/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="24a4fe2925d66e50b4f5e66e7a5c1ca4a320bf88" testsuite: Mark prog003 as broken on Windows Due to #11317. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Comment (by Tamar Christina ): In [changeset:"a3704409acc3bd237d3e872f640686918fb51f5f/ghc" a3704409/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="a3704409acc3bd237d3e872f640686918fb51f5f" Fix various issues with testsuite code on Windows Summary: Previously we would make direct calls to `diff` using `os.system`. On Windows `os.system` is implemented using the standard idiom `CreateProcess .. WaitForSingleObject ..`. This again runs afoul with the `_exec` behaviour on Windows. So we ran into some trouble where sometimes `diff` would return before it's done. On tests which run multiple ways, such as `8086` what happens is that we think the diff is done and continue. The next way tries to set things up again by removing any previous directory. This would then fail with and error saying the directory can't be removed. Which is true, because the previous diff code/child is still running. We shouldn't make any external calls to anything using `os.system`. Instead just use `runCmd` which uses `timeout`. This also ensures that if we hit the cygwin bug where diff or any other utility hangs, we kill it and continue and not hang the entire test and leave hanging processes. Further more we also: Ignore error lines from `removeFile` from tools in the testsuite. This is a rather large hammer to work around the fact that `hsc2hs` often tries to remove it's own file too early. When this is patched the workaround can be removed. See Trac #9775 We mark `prog003` as skip. Since this test randomly fails and passes. For stability it's disabled but it is a genuine bug which we should find. It's something with interface files being overwritten. See Trac #11317 when `rmtree` hits a readonly file, the `onerror` handler is raised afterwards but not during the tree walk. It doesn't allow you to recover and continue as we thought. Instead you have to explicitly start again. This is why sometimes even though we call `cleanup` before `os.mkdirs`, it would sometimes fail with an error that the folder already exists. So we now do a second walk. A new verbosity level (4) will strip the silent flags from `MAKE` invocations so you can actually see what's going on. Test Plan: ./validate on build bots. Reviewers: bgamari, austin Reviewed By: bgamari Subscribers: mpickering, thomie, #ghc_windows_task_force Differential Revision: https://phabricator.haskell.org/D2894 GHC Trac Issues: #12661, #11317, #9775 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Changes (by bmjames): * cc: bmjames (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Changes (by meteficha): * cc: meteficha (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#11317: Test prog003 fails with segfault on Windows (GHCi) ---------------------------------+---------------------------------------- Reporter: rdragon | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: GHCi | Version: 7.11 Resolution: | Keywords: GC Operating System: Windows | Architecture: Unknown/Multiple Type of failure: GHCi crash | Test Case: prog003 Blocked By: | Blocking: Related Tickets: #11234 #3408 | Differential Rev(s): Wiki Page: | ---------------------------------+---------------------------------------- Comment (by Phyx-): Hi, do you have a small example where this occurs? prog003 is quote hard to debug due to the shell interactions. If you have a Haskell only example could you report it under a new issue? Thanks! -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11317#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler