[GHC] #12870: Allow completely disabling +RTS options parsing
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: Type: feature | Status: new request | Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I'd like to have a way to completely disable the +RTS flag so that a ghc- compiled binary does not eat it, but keeps it in `argv`/`getArgs` instead. This is needed whenever you try to make a program that's supposed to pass on all arguments, for example something like `ccache` or [https://github.com/fpco/pid1 pid1]. As you can imagine, swallowing +RTS argument's isn't great when you want to pass them on to a Haskell program. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by nh2): From IRC: {{{ rwbarton: nh2_: looks like -rtsopts=none will do it, judging from the source rwbarton: or hm, maybe not rwbarton: I guess it will consume +RTS and then error out rwbarton: it looks like it would probably be pretty easy to implement }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by rwbarton): Agree that this would be useful, but as a workaround you can always use `--RTS` as the first argument to your program; it will be consumed by the RTS, and then disable all further command-line processing by the RTS. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * owner: (none) => AndreasK -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by AndreasK): I would suggest adding at least two new flags to `rtsopts=`. * One to disable all parsing of RTS flags except the ones included at compile time. * One to disable parsing of RTS flags passed via arguments but still allow parsing of arguments passed via ENVs. My suggestions would be to use `ignore` and `ignoreArgs` although I'm open to suggestions. I don't see a usecase for parsing argument RTS flags but ignoring ENV Flags but that would be a logical third option. (`ignoreENV`?) Although not sure how useful parsing only env is as well since it suffers from the same problem of applying RTS flags where one might not have intended to. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | -------------------------------------+------------------------------------- Changes (by AndreasK): * differential: => Phab:D3740 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"d75bba852db208b1d9fcb84dab01598a765d2534/ghc" d75bba8/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="d75bba852db208b1d9fcb84dab01598a765d2534" Add rtsopts ignore and ignoreAll. These ignore commandline arguments for ignore and commandline as well as GHCRTS arguments for ignoreAll. Passing RTS flags given on the command line along to the program by simply skipping processing of these flags by the RTS. This fixes #12870. Test Plan: ./validate Reviewers: austin, hvr, bgamari, erikd, simonmar Reviewed By: simonmar Subscribers: Phyx, rwbarton, thomie GHC Trac Issues: #12870 Differential Revision: https://phabricator.haskell.org/D3740 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:6> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed * milestone: => 8.4.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:7> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | -------------------------------------+------------------------------------- Comment (by alpmestan): I'm seeing quite a few failures related to the `T12870*` tests in a run of `./validate --slow` with master from yesterday. First, _all_ those tests fail with the `ghci` way, because `ghci` doesn't see that those modules are declared as `module Main where ...` and have a `main` function, and reports an error about this. {{{ =====> T12870a(ghci) 1 of 8 [0, 0, 0] cd "./rts/flags/T12870a.run" && "/home/alp/ghc/inplace/test spaces/ghc- stage2" T12870 -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno- warn-missed-specialisations -fshow-warning-groups -fdiagnostics- color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts -main-is T12870< T12870a.genscript Actual stderr output differs from expected: diff -uw "/dev/null" "./rts/flags/T12870a.run/T12870a.run.stderr.normalised" --- /dev/null 2018-03-07 13:03:27.344000000 +0100 +++ ./rts/flags/T12870a.run/T12870a.run.stderr.normalised 2018-03-08 13:56:21.487965000 +0100 @@ -0,0 +1,4 @@ + +T12870a:6:30: + Not in scope: ‘Main.main’ + No module named ‘Main’ is imported. *** unexpected failure for T12870a(ghci) =====> T12870b(ghci) 2 of 8 [0, 1, 0] cd "./rts/flags/T12870b.run" && "/home/alp/ghc/inplace/test spaces/ghc- stage2" T12870 -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno- warn-missed-specialisations -fshow-warning-groups -fdiagnostics- color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts=none -main-is T12870< T12870b.genscript Wrong exit code for T12870b(ghci) (expected 1 , actual 0 ) Stderr ( T12870b ): T12870b:6:30: error: Not in scope: ‘Main.main’ No module named ‘Main’ is imported. *** unexpected failure for T12870b(ghci) =====> T12870c(ghci) 3 of 8 [0, 2, 0] cd "./rts/flags/T12870c.run" && "/home/alp/ghc/inplace/test spaces/ghc- stage2" T12870 -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno- warn-missed-specialisations -fshow-warning-groups -fdiagnostics- color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts=some -main-is T12870< T12870c.genscript Wrong exit code for T12870c(ghci) (expected 1 , actual 0 ) Stderr ( T12870c ): T12870c:6:30: error: Not in scope: ‘Main.main’ No module named ‘Main’ is imported. *** unexpected failure for T12870c(ghci) =====> T12870d(ghci) 4 of 8 [0, 3, 0] cd "./rts/flags/T12870d.run" && "/home/alp/ghc/inplace/test spaces/ghc- stage2" T12870 -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno- warn-missed-specialisations -fshow-warning-groups -fdiagnostics- color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -main-is T12870< T12870d.genscript Actual stderr output differs from expected: diff -uw "/dev/null" "./rts/flags/T12870d.run/T12870d.run.stderr.normalised" --- /dev/null 2018-03-07 13:03:27.344000000 +0100 +++ ./rts/flags/T12870d.run/T12870d.run.stderr.normalised 2018-03-08 13:56:22.091965000 +0100 @@ -0,0 +1,4 @@ + +T12870d:6:30: + Not in scope: ‘Main.main’ + No module named ‘Main’ is imported. *** unexpected failure for T12870d(ghci) =====> T12870e(ghci) 5 of 8 [0, 4, 0] cd "./rts/flags/T12870e.run" && "/home/alp/ghc/inplace/test spaces/ghc- stage2" T12870 -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno- warn-missed-specialisations -fshow-warning-groups -fdiagnostics- color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts=ignore -main-is T12870< T12870e.genscript Actual stderr output differs from expected: diff -uw "/dev/null" "./rts/flags/T12870e.run/T12870e.run.stderr.normalised" --- /dev/null 2018-03-07 13:03:27.344000000 +0100 +++ ./rts/flags/T12870e.run/T12870e.run.stderr.normalised 2018-03-08 13:56:22.307965000 +0100 @@ -0,0 +1,4 @@ + +T12870e:6:30: + Not in scope: ‘Main.main’ + No module named ‘Main’ is imported. *** unexpected failure for T12870e(ghci) =====> T12870f(ghci) 6 of 8 [0, 5, 0] cd "./rts/flags/T12870f.run" && "/home/alp/ghc/inplace/test spaces/ghc- stage2" T12870 -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno- warn-missed-specialisations -fshow-warning-groups -fdiagnostics- color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts=ignoreAll -main-is T12870< T12870f.genscript Actual stderr output differs from expected: diff -uw "/dev/null" "./rts/flags/T12870f.run/T12870f.run.stderr.normalised" --- /dev/null 2018-03-07 13:03:27.344000000 +0100 +++ ./rts/flags/T12870f.run/T12870f.run.stderr.normalised 2018-03-08 13:56:22.547965000 +0100 @@ -0,0 +1,4 @@ + +T12870f:6:30: + Not in scope: ‘Main.main’ + No module named ‘Main’ is imported. *** unexpected failure for T12870f(ghci) =====> T12870g(ghci) 7 of 8 [0, 6, 0] cd "./rts/flags/T12870g.run" && GHCRTS=-G7 "/home/alp/ghc/inplace/test spaces/ghc-stage2" T12870g -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts -main-is T12870g -with-rtsopts="-G3"< T12870g.genscript Actual stderr output differs from expected: diff -uw "/dev/null" "./rts/flags/T12870g.run/T12870g.run.stderr.normalised" --- /dev/null 2018-03-07 13:03:27.344000000 +0100 +++ ./rts/flags/T12870g.run/T12870g.run.stderr.normalised 2018-03-08 13:56:22.799965000 +0100 @@ -0,0 +1,4 @@ + +T12870g:6:30: + Not in scope: ‘Main.main’ + No module named ‘Main’ is imported. *** unexpected failure for T12870g(ghci) =====> T12870h(ghci) 8 of 8 [0, 7, 0] cd "./rts/flags/T12870h.run" && GHCRTS=-G7 "/home/alp/ghc/inplace/test spaces/ghc-stage2" T12870g -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output --interactive -v0 -ignore-dot-ghci -fno-ghci-history +RTS -I0.1 -RTS -rtsopts=ignoreAll -main-is T12870g -with-rtsopts="-G3"< T12870h.genscript Actual stderr output differs from expected: diff -uw "/dev/null" "./rts/flags/T12870h.run/T12870h.run.stderr.normalised" --- /dev/null 2018-03-07 13:03:27.344000000 +0100 +++ ./rts/flags/T12870h.run/T12870h.run.stderr.normalised 2018-03-08 13:56:23.031965000 +0100 @@ -0,0 +1,4 @@ + +T12870h:6:30: + Not in scope: ‘Main.main’ + No module named ‘Main’ is imported. *** unexpected failure for T12870h(ghci) }}} I also see failures with `threaded2`, because of additional RTS options passed to all tests executed in the `threaded2` way, I suppose: {{{ =====> T12870e(threaded2) 1 of 2 [0, 0, 0] cd "./rts/flags/T12870e.run" && "/home/alp/ghc/inplace/test spaces /ghc-stage2" --make -o T12870e T12870 -dcore-lint -dcmm-lint -no-user- package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output -O -threaded -eventlog -rtsopts=ignore -main-is T12870 cd "./rts/flags/T12870e.run" && ./T12870e +RTS -N2 -ls -RTS +RTS -G2 -RTS arg1 --RTS +RTS arg2 Actual stdout output differs from expected: diff -uw "./rts/flags/T12870e.run/T12870e.stdout.normalised" "./rts/flags/T12870e.run/T12870e.run.stdout.normalised" --- ./rts/flags/T12870e.run/T12870e.stdout.normalised 2018-03-08 13:37:41.099965000 +0100 +++ ./rts/flags/T12870e.run/T12870e.run.stdout.normalised 2018-03-08 13:37:41.099965000 +0100 @@ -1 +1 @@ -["+RTS","-G2","-RTS","arg1","--RTS","+RTS","arg2"] +["+RTS","-N2","-ls","-RTS","+RTS","-G2","-RTS","arg1","-- RTS","+RTS","arg2"] *** unexpected failure for T12870e(threaded2) =====> T12870f(threaded2) 2 of 2 [0, 1, 0] cd "./rts/flags/T12870f.run" && "/home/alp/ghc/inplace/test spaces /ghc-stage2" --make -o T12870f T12870 -dcore-lint -dcmm-lint -no-user- package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show-caret -dno-debug-output -O -threaded -eventlog -rtsopts=ignoreAll -main-is T12870 cd "./rts/flags/T12870f.run" && ./T12870f +RTS -N2 -ls -RTS +RTS -G2 -RTS arg1 --RTS +RTS arg2 Actual stdout output differs from expected: diff -uw "./rts/flags/T12870f.run/T12870f.stdout.normalised" "./rts/flags/T12870f.run/T12870f.run.stdout.normalised" --- ./rts/flags/T12870f.run/T12870f.stdout.normalised 2018-03-08 13:37:41.671965000 +0100 +++ ./rts/flags/T12870f.run/T12870f.run.stdout.normalised 2018-03-08 13:37:41.671965000 +0100 @@ -1 +1 @@ -["+RTS","-G2","-RTS","arg1","--RTS","+RTS","arg2"] +["+RTS","-N2","-ls","-RTS","+RTS","-G2","-RTS","arg1","-- RTS","+RTS","arg2"] *** unexpected failure for T12870f(threaded2) }}} I'm also not sure what `-rtsopts=ignoreAll` is about, I don't see anything being ignored, only some more options being given to the program and reported. This makes it hard to expect the same output from a test executed under different ways. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | -------------------------------------+------------------------------------- Comment (by AndreasK): Replying to [comment:8 alpmestan]:
I'm seeing quite a few failures related to the `T12870*` tests in a run of `./validate --slow` with master from yesterday.
First, _all_ those tests fail with the `ghci` way, because `ghci` doesn't see that those modules are declared as `module Main where ...` and have a `main` function, and reports an error about this.
I'm also not sure what `-rtsopts=ignoreAll` is about, I don't see anything being ignored, only some more options being given to the program and reported. This makes it hard to expect the same output from a test executed under different ways.
I didn't test these using the slow run when I wrote these tests. https://phabricator.haskell.org/D4486 should fix the tests. Thanks for reporting this. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:9> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Changes (by AndreasK): * differential: Phab:D3740 => Phab:D3740 Phab:D4486 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Comment (by alpmestan): Thanks for the quick fix Andreas! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Changes (by alpmestan): * cc: alpmestan (added) -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:12> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"fdec06a201f81467badb9e2a5d43b4a85564dff9/ghc" fdec06a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="fdec06a201f81467badb9e2a5d43b4a85564dff9" Update tests for #12870 to pass with a slow run of the testsuite. Test Plan: make slow Reviewers: bgamari, erikd, simonmar Reviewed By: bgamari Subscribers: rwbarton, thomie, carter GHC Trac Issues: #12870 Differential Revision: https://phabricator.haskell.org/D4486 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:13> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Comment (by alpmestan): I'm seeing the following failures with commit 8b823f270e: {{{ /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870b.run T12870b [bad heap profile] (profasm) /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870c.run T12870c [bad heap profile] (profasm) /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870e.run T12870e [bad stdout] (profasm) /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870e.run T12870e [bad stdout] (profthreaded) /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870f.run T12870f [bad stdout] (profasm) /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870h.run T12870h [bad heap profile] (profasm) /run/user/1001/ghctest-9vjo4opa/test spaces/./rts/flags/T12870f.run T12870f [bad stdout] (profthreaded) }}} Could someone else try to run those tests with those `WAY`s and let me know if they see the same failures? -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:14> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Comment (by alpmestan): The aforementionned failures are addressed by Andreas in [https://phabricator.haskell.org/D4585 D4585]. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:15> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12870: Allow completely disabling +RTS options parsing -------------------------------------+------------------------------------- Reporter: nh2 | Owner: AndreasK Type: feature request | Status: closed Priority: normal | Milestone: 8.4.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D3740 Wiki Page: | Phab:D4486 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"9e89092d4ee1effd558757361fb62b83697f8f42/ghc" 9e89092d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="9e89092d4ee1effd558757361fb62b83697f8f42" Omit ways depending on rts flags for #12870 related tests. Some of these tests instruct the RTS to ignore all RTS flags being passed. While this is intended it causes test failures for some ways like profiling which depend on passing RTS flags. So we skip these ways. Test Plan: testsuite/tests/rts/flags$ make slow Reviewers: bgamari, simonmar, alpmestan Reviewed By: alpmestan Subscribers: alpmestan, thomie, carter GHC Trac Issues: #12870 Differential Revision: https://phabricator.haskell.org/D4585 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12870#comment:16> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC