[GHC] #12118: Testsuite driver does not normalise platform-dependent .stdout/stderr files
#12118: Testsuite driver does not normalise platform-dependent .stdout/stderr files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- This change was made without explanation in commit 429f0099ab9adfadc779ca76f3aae1c9c160fb8c: {{{ Author: Esa Ilari Vuokko <ei@vuokko.info> Date: Sun Aug 13 12:46:49 2006 +0000 Fix driver not to normalise output when using platform specific output files }}} I don't understand why that change was made. It makes `T11223_link_order_a_b_2_fail` and `T11223_simple_duplicate_lib` fail on Windows, when running with `BINDIST=YES` (or, after accepting the `BINDIST=YES` output, when running with `BINDIST=NO`). -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12118> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12118: Testsuite driver does not normalise platform-dependent .stdout/stderr files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.2 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2267 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => patch * differential: => Phab:D2267 * milestone: => 8.0.2 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12118#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12118: Testsuite driver does not normalise platform-dependent .stdout/stderr files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: patch Priority: normal | Milestone: 8.0.2 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2267 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Thomas Miedema <thomasmiedema@…>): In [changeset:"6a5bce14ffb8b10def150b185fc95d7b2ebab263/ghc" 6a5bce14/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="6a5bce14ffb8b10def150b185fc95d7b2ebab263" Testsuite: also normalise platform-dependent .stdout/stderr This effectively reverses commit 429f0099ab9adfadc779ca76f3aae1c9c160fb8c (2006). I don't see why platform-dependent .stdout/stderr files should //not// get normalised. It fixes T11223_link_order_a_b_2_fail on Windows, by normalising `ghc-stage2.exe` to `ghc` when comparing stderr with .stderr-mingw32. Reviewed by: Phyx Differential Revision: https://phabricator.haskell.org/D2267 GHC Trac Issues: #12118 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12118#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12118: Testsuite driver does not normalise platform-dependent .stdout/stderr files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: merge Priority: normal | Milestone: 8.0.2 Component: Test Suite | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2267 Wiki Page: | -------------------------------------+------------------------------------- Changes (by thomie): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12118#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#12118: Testsuite driver does not normalise platform-dependent .stdout/stderr files -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: bug | Status: closed Priority: normal | Milestone: 8.0.2 Component: Test Suite | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2267 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed Comment: Merged to `ghc-8.0` as 43eef4353790d1311b29cff28b23cd2e006e633b. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/12118#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC