#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: Type: feature | Status: new request | Milestone: Priority: normal | Version: 7.9 Component: Compiler | Keywords: (LLVM) | Architecture: Unknown/Multiple Resolution: | Difficulty: Moderate (less Operating System: | than a day) Unknown/Multiple | Blocked By: Type of failure: Runtime | Related Tickets: performance bug | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by rwbarton): I probably won't get around to this myself in the near future. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: michalt Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by michalt): * owner: => michalt Comment: This looks like a nice way to learn more about LLVM backend, so I've started working on adding support for: `MO_Add2` and `MO_{Add,Sub}IntC`. I hope to send something out within the next few days. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: michalt Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"b1d1c652908ecd7bfcf13cf2e5dd06ac7926992c/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="b1d1c652908ecd7bfcf13cf2e5dd06ac7926992c" Support MO_{Add,Sub}IntC and MO_Add2 in the LLVM backend This includes: - Adding new LlvmType called LMStructP that represents an unpacked struct (this is necessary since LLVM's instructions the llvm.sadd.with.overflow.* return an unpacked struct). - Modifications to LlvmCodeGen.CodeGen to generate the LLVM instructions for the primops. - Modifications to StgCmmPrim to actually use those three instructions if we use the LLVM backend (so far they were only used for NCG). Test Plan: validate Reviewers: austin, rwbarton, bgamari Reviewed By: bgamari Subscribers: thomie, bgamari Differential Revision: https://phabricator.haskell.org/D991 GHC Trac Issues: #9430 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: michalt Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by michalt): Sorry I wasn't clear in the previous message - I'm actually planning to implement support for the two remaining operations as well (hopefully I'll have some time over the weekend). I just wanted to split the work into two parts since I'm not very familiar with the codebase. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: michalt Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"82ffc80df573512f788524c4616db3c08fc9f125/ghc" 82ffc80d/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="82ffc80df573512f788524c4616db3c08fc9f125" LlvmCodeGen: add support for MO_U_Mul2 CallishMachOp This adds support MO_U_Mul2 to the LLVM backend by simply using 'mul' instruction but operating at twice the bit width (e.g., for 64 bit words we will generate mul that operates on 128 bits and then extract the two 64 bit values for the result of the CallishMachOp). Test Plan: validate Reviewers: rwbarton, austin, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1068 GHC Trac Issues: #9430 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Runtime | Test Case: performance bug | primops/should_run/T9430 Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Changes (by michalt): * status: closed => new * owner: michalt => * resolution: fixed => * milestone: 7.12.1 => Comment: I was also planning to add support for MO_U_QuotRem2 (using `udiv` and `urem`), so let's not close this just yet. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: michalt Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Runtime | Test Case: performance bug | primops/should_run/T9430 Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"92f5385d8b2be50848a2496199a481f299f4b53a/ghc" 92f5385/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="92f5385d8b2be50848a2496199a481f299f4b53a" Support MO_U_QuotRem2 in LLVM backend This adds support for MO_U_QuotRem2 in LLVM backend. Similarly to MO_U_Mul2 we use the standard LLVM instructions (in this case 'udiv' and 'urem') but do the computation on double the word width (e.g., for 64-bit we will do them on 128 registers). Test Plan: validate Reviewers: rwbarton, austin, bgamari Reviewed By: bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1100 GHC Trac Issues: #9430 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9430: implement more arithmetic operations natively in the LLVM backend -------------------------------------+------------------------------------- Reporter: rwbarton | Owner: michalt Type: feature request | Status: new Priority: normal | Milestone: Component: Compiler (LLVM) | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Runtime | Test Case: performance bug | primops/should_run/T9430 Blocked By: | Blocking: Related Tickets: | Differential Revisions: -------------------------------------+------------------------------------- Comment (by rwbarton): But MO_U_Mul2 was done in 82ffc80d (comment:9) right? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9430#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler