[GHC] #14703: T14507 testcase fragile due to unique exposed in error message
#14703: T14507 testcase fragile due to unique exposed in error message -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.4.1-alpha1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- I noticed this failure in the CircleCI output: {{{#!patch --- ./patsyn/should_fail/T14507.run/T14507.stderr.normalised 2018-01-22 18:57:32.381575253 +0000 +++ ./patsyn/should_fail/T14507.run/T14507.comp.stderr.normalised 2018-01-22 18:57:32.381575253 +0000 @@ -2,7 +2,7 @@ T14507.hs:18:9: Iceland Jack! Iceland Jack! Stop torturing me! Pattern-bound variable x :: TypeRep a - has a type that mentions pattern-bound coercion: co_a2CF + has a type that mentions pattern-bound coercion: co_a2D4 Hint: use -fprint-explicit-coercions to see the coercions Probable fix: add a pattern signature In the declaration for pattern synonym ‘SO’ }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14703 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14703: T14507 testcase fragile due to unique exposed in error message -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * version: 8.4.1-alpha1 => 8.5 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14703#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14703: T14507 testcase fragile due to unique exposed in error message
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner: (none)
Type: bug | Status: new
Priority: normal | Milestone:
Component: Test Suite | Version: 8.5
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s):
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ryan Scott
#14703: T14507 testcase fragile due to unique exposed in error message -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: closed Priority: normal | Milestone: Component: Test Suite | Version: 8.5 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by RyanGlScott): * status: new => closed * resolution: => fixed Comment: Oops! Fortunately, an easy fix. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14703#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14703: Uniques should not appear in error messages -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Test Suite | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * status: closed => new * resolution: fixed => Comment: This feels like the wrong solution. We really shouldn't print uniques in user error messages in the first place. Still, it's very much a corner case, so I'm not sure it's worth many cycles to fix. But I'll re-open as "uniques should not appear in error messages". -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14703#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC