[GHC] #7907: patch to make comment about stgclosure struct more accurate
#7907: patch to make comment about stgclosure struct more accurate ------------------------------+--------------------------------------------- Reporter: carter | Owner: Type: task | Status: new Priority: normal | Component: Compiler Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Documentation bug | Blockedby: Blocking: | Related: ------------------------------+--------------------------------------------- I've been digging into the rts code to understand function application etc, and the current comment about where StgClosure is defined is wrong. theres a patch fix it. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7907> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7907: patch to make comment about stgclosure struct more accurate ---------------------------------+------------------------------------------ Reporter: carter | Owner: simonmar Type: task | Status: new Priority: normal | Milestone: 7.8.1 Component: Runtime System | Version: 7.7 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: Documentation bug Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Changes (by igloo): * owner: => simonmar * difficulty: => Unknown * component: Compiler => Runtime System * milestone: => 7.8.1 Comment: Hmm, this seems a little odd to me. It looks like it's been this way since a2a67cd520b9841114d69a87a423dabcb3b4368e. Why aren't we just defining `StgClosure` here? Simon, do you remember? -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7907#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7907: patch to make comment about stgclosure struct more accurate ---------------------------------+------------------------------------------ Reporter: carter | Owner: simonmar Type: task | Status: new Priority: normal | Milestone: 7.8.1 Component: Runtime System | Version: 7.7 Keywords: | Os: Unknown/Multiple Architecture: Unknown/Multiple | Failure: Documentation bug Difficulty: Unknown | Testcase: Blockedby: | Blocking: Related: | ---------------------------------+------------------------------------------ Comment(by marlowsd@…): commit 22574cf00438922badee0e8e0ea5ef1614c5d17d {{{ Author: Simon Marlow <marlowsd@gmail.com> Date: Tue May 21 09:00:35 2013 +0100 fix comment (#7907) includes/rts/storage/Closures.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7907#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7907: patch to make comment about stgclosure struct more accurate --------------------------------+------------------------------------------- Reporter: carter | Owner: simonmar Type: task | Status: closed Priority: normal | Milestone: 7.8.1 Component: Runtime System | Version: 7.7 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Documentation bug | Difficulty: Unknown Testcase: | Blockedby: Blocking: | Related: --------------------------------+------------------------------------------- Changes (by simonmar): * status: new => closed * resolution: => fixed Comment: Replying to [comment:1 igloo]:
Why aren't we just defining `StgClosure` here? Simon, do you remember?
Probably because it needs to be forward-declared for something else. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7907#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC