[GHC] #14658: 'Fix two more bugs in partial signatures' broke T10846
#14658: 'Fix two more bugs in partial signatures' broke T10846 -------------------------------------+------------------------------------- Reporter: niteria | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- {{{ =====> T10846(normal) 1 of 1 [0, 0, 0] cd "./typecheck/should_run/T10846.run" && "/home/niteria/ghc-allocate- tyids/inplace/test spaces/ghc-stage2" -o T10846 T10846.hs -dcore-lint -dcmm-lint -no-user-package-db -rtsopts -fno-warn-missed-specialisations -fshow-warning-groups -fdiagnostics-color=never -fno-diagnostics-show- caret -dno-debug-output cd "./typecheck/should_run/T10846.run" && ./T10846 Actual stdout output differs from expected: diff -uw "./typecheck/should_run/T10846.run/T10846.stdout.normalised" "./typecheck/should_run/T10846.run/T10846.run.stdout.normalised" --- ./typecheck/should_run/T10846.run/T10846.stdout.normalised 2018-01-10 13:39:29.720468420 +0000 +++ ./typecheck/should_run/T10846.run/T10846.run.stdout.normalised 2018-01-10 13:39:29.720468420 +0000 @@ -1,3 +1,3 @@ [18] -[19] -[20] +[] +[] *** unexpected failure for T10846(normal) }}} Harbormaster results: https://phabricator.haskell.org/harbormaster/build/39597/ Reverting fixed it for me locally. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14658> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14658: 'Fix two more bugs in partial signatures' broke T10846 -------------------------------------+------------------------------------- Reporter: niteria | Owner: simonpj Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by niteria): * owner: (none) => simonpj -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14658#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14658: 'Fix two more bugs in partial signatures' broke T10846 -------------------------------------+------------------------------------- Reporter: niteria | Owner: simonpj Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by simonpj): Ugh. Validate obviously didn't run that test. Fix validating now. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14658#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14658: 'Fix two more bugs in partial signatures' broke T10846 -------------------------------------+------------------------------------- Reporter: niteria | Owner: simonpj Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by Simon Peyton Jones <simonpj@…>): In [changeset:"f3f90a079179e085295ee7edd2dda6505799370c/ghc" f3f90a07/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="f3f90a079179e085295ee7edd2dda6505799370c" Fix previous patch This recent patch commit 1577908f2a9db0fcf6f749d40dd75481015f5497 Author: Simon Peyton Jones <simonpj@microsoft.com> Date: Tue Jan 9 16:20:46 2018 +0000 Fix two more bugs in partial signatures These were shown up by Trac #14643 failed validation for typecheck/should_run/T10846 (Reported in Trac #14658.) The fix is simple. }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14658#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14658: 'Fix two more bugs in partial signatures' broke T10846 -------------------------------------+------------------------------------- Reporter: niteria | Owner: simonpj Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * status: new => closed * resolution: => fixed Comment: Sorry about that. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14658#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#14658: 'Fix two more bugs in partial signatures' broke T10846 -------------------------------------+------------------------------------- Reporter: niteria | Owner: simonpj Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: Resolution: fixed | Keywords: | PartialTypeSignatures Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * keywords: => PartialTypeSignatures -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/14658#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC