[GHC] #11690: stage 1 compiler silently ignores plugins
#11690: stage 1 compiler silently ignores plugins -------------------------------------+------------------------------------- Reporter: osa1 | Owner: osa1 Type: feature | Status: new request | Priority: lowest | Milestone: Component: Compiler | Version: 7.10.3 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- It can't load plugins but it shouldn't just silently ignore IMHO. At least a warning would be nice. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11690> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11690: stage 1 compiler silently ignores plugins -------------------------------------+------------------------------------- Reporter: osa1 | Owner: osa1 Type: feature request | Status: patch Priority: lowest | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2334 Wiki Page: | -------------------------------------+------------------------------------- Changes (by osa1): * status: new => patch * differential: => Phab:D2334 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11690#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11690: stage 1 compiler silently ignores plugins -------------------------------------+------------------------------------- Reporter: osa1 | Owner: osa1 Type: feature request | Status: patch Priority: lowest | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2334 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ömer Sinan Ağacan <omeragacan@…>): In [changeset:"930a525a5906fdd65ab0c3e804085d5875517a20/ghc" 930a525a/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="930a525a5906fdd65ab0c3e804085d5875517a20" Abort the build when a Core plugin pass is specified in stage1 compiler This also makes the behavior the same with frontend plugin errors -- frontend was failing with an exception (`CmdLineError`) while the simplifier was just ignoring plugins. Now we abort with `CmdLineError` in both cases with a slightly improved error message. Test Plan: - add tests (will add tests once #12197 is implemented) - validate (done) Reviewers: austin, bgamari Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2334 GHC Trac Issues: #11690 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11690#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11690: stage 1 compiler silently ignores plugins -------------------------------------+------------------------------------- Reporter: osa1 | Owner: osa1 Type: feature request | Status: merge Priority: lowest | Milestone: Component: Compiler | Version: 7.10.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2334 Wiki Page: | -------------------------------------+------------------------------------- Changes (by osa1): * status: patch => merge -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11690#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#11690: stage 1 compiler silently ignores plugins -------------------------------------+------------------------------------- Reporter: osa1 | Owner: osa1 Type: feature request | Status: closed Priority: lowest | Milestone: 8.0.2 Component: Compiler | Version: 7.10.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2334 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: merge => closed * resolution: => fixed * milestone: => 8.0.2 Comment: Merged to `ghc-8.0` as df4323bccbe26205e7100af2292501b9c903e71c. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/11690#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC