#12822: Cleanup GHC verbosity flags -------------------------------------+------------------------------------- Reporter: hsyl20 | Owner: Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: | newcomer,flags Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonmar): * cc: simonmar (added) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12822#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12822: Cleanup GHC verbosity flags -------------------------------------+------------------------------------- Reporter: hsyl20 | Owner: (none) Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: | newcomer,flags Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Let's discuss a concrete proposal before discussing implementation strategy. Which of the two parts listed in the ticket description would you like to take up? Both? If so, what concrete renaming are you proposing? For how long of a deprecation window do we want to keep the current flags around? Changes like these tend to inflict a small amount of pain on a lot of users for a long time, so I think we should be careful and deliberate in approaching this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12822#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12822: Cleanup GHC verbosity flags -------------------------------------+------------------------------------- Reporter: hsyl20 | Owner: (none) Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: | newcomer,flags Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Let's first define specifically which flags we are talking about changing here; there are currently several broad categories that one might consider "verbosity" flags, * the dump (`-d*`) flags; these are currently handled uniformly within just and are represented by the `DynFlags.DumpFlags` type. * the `-fprint-*` flags * the `-fshow-options` flag * the `-v<n>` flags * the as-of-yet non-existent flags which denote the individual effects currently controlled by the `-v<n>` flags What concretely would you like to do with these flags? It's not entirely clear to me that, for instance, unifying the `-d*` flags with the `-fprint-*` flags is a good idea; afterall, the former are meant for developers while the latter are for users. Regarding the refactoring bit of (1): There should be no need to add a constructor to `DynFlags` (which is essentially just a product of all of the user-specified configuration GHC needs). You should have a look at how the `-On` flags are currently implemented; namely look at references to `optLevel` in `DynFlags`. Of particular interest will be `DynFlags.optLevelFlags`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12822#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12822: Cleanup GHC verbosity flags -------------------------------------+------------------------------------- Reporter: hsyl20 | Owner: (none) Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: | newcomer,flags Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): For the record, here are the relevant uses of `verbosity` that I was able to quickly find, {{{ $ ag "verbosity .*dflags" compiler/backpack/DriverBkp.hs 514: | verbosity (hsc_dflags hsc_env) >= 2 -> showMsg "Skipping " "" compiler/ghci/Linker.hs 1463: = when (verbosity dflags > 1) $ compiler/main/Finder.hs 659: | verbosity dflags < 3 = 775: | verbosity dflags < 3 = compiler/main/DynFlags.hs 1998: || (verbosity dflags >= 4 && enableIfVerbose f) 2203: | verbosity dflags >= 4 = ["-v"] compiler/main/HscMain.hs 810: | verbosity (hsc_dflags hsc_env) >= 2 -> showMsg "Skipping " "" compiler/main/ErrUtils.hs 554: | verbosity dflags >= val = act 613: if verbosity dflags >= 2 684: = do { let verb = verbosity dflags ghc/Main.hs 233: case verbosity dflags6 of 736: let verb = verbosity dflags ghc/GHCi/UI.hs 553: when (isNothing maybe_exprs && verbosity dflags > 0) $ 588: let show_prompt = verbosity dflags > 0 || is_tty 618: liftIO $ when (verbosity dflags > 0) $ putStrLn "Leaving GHCi." 1818: when (verbosity dflags > 0) $ 2634: when (verbosity dflags2 > 0) $ }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12822#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#12822: Cleanup GHC verbosity flags -------------------------------------+------------------------------------- Reporter: hsyl20 | Owner: (none) Type: task | Status: new Priority: low | Milestone: Component: Compiler | Version: 8.0.1 Resolution: | Keywords: | newcomer,flags Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: Other | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by captaintrunky): I've done some preliminary fixes for this task in DynFlags. Is that the right approach? Next step is to refactor some uses of 'verbosity' in some files mentioned above. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12822#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler