[GHC] #14505: CircleCI only builds pushed heads
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- It appears that CircleCI only builds the head commit of pushes. This means that most of our commits are currently going untested. It seems that the ability to build all commits has been an outstanding feature request since February 2017. See, * https://stackoverflow.com/questions/42074618/circleci-build-all- commits-between-last * https://discuss.circleci.com/t/manually-trigger-a-build-all-commits- between-two-revisions/10160/2 It seems like our options are currently to either ensure that people only push on commit at a time or develop some automation to manually trigger commits using the [[https://circleci.com/docs/api/v1-reference/#new- build|API]]. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Unfortunately it looks like the API is [[https://discuss.circleci.com/t/creating-a-new-workflow-based-build-via- api-mysteriously-fails/18280|buggy]] and consequently the second option is off the table, at least for the moment. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Indeed it appears that the CircleCI API [[https://circleci.com/docs/2.0/faq/#can-i-use-the-api-with-workflows|can not be used]] to start workflow builds. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by chak): Replying to [comment:2 bgamari]:
Indeed it appears that the CircleCI API [[https://circleci.com/docs/2.0/faq/#can-i-use-the-api-with-workflows|can not be used]] to start workflow builds.
That is bad, but from what I understand it is a not-yet-implemented type of shortcoming (i.e., workflows are new in 2.0 and the API hasn't caught up to all 2.0 features yet). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by chak): Seems like we can sidestep this issue by using GitHub PRs instead of direct pushing to master, as per https://mail.haskell.org/pipermail/ghc- devops-group/2017-December/000129.html -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by nomeata): Does this mean that contributors with commit rights will have to create a separate GitHub PR for each commit that we want to push? Or one for each set of somehow connected commits? And will these commits eventually enter `master` with the same git commit id? -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
Seems like we can sidestep this issue by using GitHub PRs instead of
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mpickering): Replying to [comment:4 chak]: direct pushing to master, as per https://mail.haskell.org/pipermail/ghc- devops-group/2017-December/000129.html Does this mean that the builders will not run on differentials? This seems like a very serious flaw if so. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#14505: CircleCI only builds pushed heads -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: bug | Status: new Priority: normal | Milestone: Component: Continuous | Version: 8.2.1 Integration | Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari):
Does this mean that the builders will not run on differentials? This seems like a very serious flaw if so.
Differentials unfortunately need to be handled separately but sadly this isn't entirely trivial due to the GitHub-centric nature of CircleCI. See #14506. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/14505#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC