[GHC] #9766: Use TypeLits in the meta-data encoding of GHC.Generics
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: dreixel Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.9 Keywords: | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: 9043 | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- This ticket serves to track the task of improving the meta-data representation in GHC.Generics as described in the following wiki page: https://ghc.haskell.org/trac/ghc/wiki/Commentary/Compiler/GenericDeriving#Am... I'm working on this in branch `wip/GenericsMetaData`, and I intend to have it in 7.10. -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: dreixel Type: task | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.9 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: #9043 Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by dreixel): * related: 9043 => #9043 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: dreixel Type: task | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.9 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: #9043 Test Case: | Blocking: 9043 | Differential Revisions: Phab:D493 | -------------------------------------+------------------------------------- Changes (by dreixel): * status: new => patch * differential: => Phab:D493 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: dreixel Type: task | Status: patch Priority: normal | Milestone: 7.10.1 Component: Compiler | Version: 7.9 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: #9043 Test Case: | Blocking: 9043 | Differential Revisions: Phab:D493 | -------------------------------------+------------------------------------- Changes (by hvr): * milestone: => 7.10.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:4> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: dreixel Type: task | Status: patch Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.9 Resolution: | Keywords: Operating System: | Architecture: Unknown/Multiple Unknown/Multiple | Difficulty: Unknown Type of failure: | Blocked By: None/Unknown | Related Tickets: #9043 Test Case: | Blocking: 9043 | Differential Revisions: Phab:D493 | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * milestone: 7.10.1 => 7.12.1 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:5> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: kosmikus Type: task | Status: patch Priority: normal | Milestone: 7.12.1 Component: Compiler | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: 9043 Related Tickets: #9043 | Differential Revisions: Phab:D493 -------------------------------------+------------------------------------- Changes (by simonpj): * owner: dreixel => kosmikus Comment: On the Phab ticket, Ben says
@dreixel, this looks like a nice use of promotion. Is there any chance you will be continuing this work? and Pedro replies I'm afraid not, at least not in the foreseeable future. I'd love it if someone were to pick it up, though!
I think that Andres has volunteered to pick up Generics related tickets, of which this is a prime example, so I'll change the owner to him. Andres, might you get to this? It's mostly done!! Thanks Simon -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:8> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: kosmikus Type: task | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.9 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: 9043 Related Tickets: #9043 | Differential Rev(s): Phab:D493 -------------------------------------+------------------------------------- Comment (by Ben Gamari <ben@…>): In [changeset:"700c42b5e0ffd27884e6bdfa9a940e55449cff6f/ghc" 700c42b/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="700c42b5e0ffd27884e6bdfa9a940e55449cff6f" Use TypeLits in the meta-data encoding of GHC.Generics Test Plan: Validate. Reviewers: simonpj, goldfire, hvr, dreixel, kosmikus, austin, bgamari Reviewed By: kosmikus, austin, bgamari Subscribers: RyanGlScott, Fuuzetsu, bgamari, thomie, carter, dreixel Differential Revision: https://phabricator.haskell.org/D493 GHC Trac Issues: #9766 }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:10> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: kosmikus Type: task | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.9 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: 9043 Related Tickets: #9043 | Differential Rev(s): Phab:D493 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:11> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: kosmikus Type: task | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.9 Resolution: fixed | Keywords: Generics Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: 9043 Related Tickets: #9043 | Differential Rev(s): Phab:D493 Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * keywords: => Generics -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:12> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9766: Use TypeLits in the meta-data encoding of GHC.Generics -------------------------------------+------------------------------------- Reporter: dreixel | Owner: kosmikus Type: task | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.9 Resolution: fixed | Keywords: Generics Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: 9043 Related Tickets: #9043 | Differential Rev(s): Phab:D493 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ryan Scott <ryan.gl.scott@…>): In [changeset:"dad39ff04a6585ab9cf3a2572ea922e309e6385f/ghc" dad39ff/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="dad39ff04a6585ab9cf3a2572ea922e309e6385f" Remove dead generics-related code from OccName Before #9766 was fixed, GHC would generate auxiliary datatypes for every Generic instance, and it would use functions from OccName to prefix the generated names. GHC no longer generates any auxiliary datatypes for Generic instances, but the accompanying code was never removed from OccName (until now). }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9766#comment:13> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC