Re: [GHC] #6135: Unboxed Booleans

#6135: Unboxed Booleans -------------------------------+-------------------------------------------- Reporter: benl | Owner: jstolarek Type: feature request | Status: new Priority: normal | Milestone: 7.8.1 Component: Compiler | Version: 7.4.1 Resolution: | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: None/Unknown | Difficulty: Unknown Testcase: | Blockedby: Blocking: | Related: #605 -------------------------------+-------------------------------------------- Comment(by simonpj): Great. I suggest * One patch per repo, with a commit message summarising changes. No need to record all the intermediate patches on your path to completion! * The goal of all this is better performance. So including that evidence in the commit message would be good. Maybe the improved perf only shows on benchmarks that aren't in nofib? Then perhaps add tests to `perf/should_run` and point to them from the commit message. * I don't understand the cause of the `eqInteger#` constant folding problem. It should be easy to reproduce in HEAD, just by writing a new `Integer` type in test, and some suitable wrappers and a fake primop (with NOINLINE on that). Then you can open a ticket on that and we can solve it separately. Probably it'll be done before you are ready with all the rest. * User docs: I'm not sure that any change is needed. The important thing is that the wiki page is up to date, explains the motivation and the reasoning for the main design choices (eg why `Int#` rather than `Word#` as the return type). Thanks Jan Simon -- Ticket URL: http://hackage.haskell.org/trac/ghc/ticket/6135#comment:53 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC