[GHC] #12129: Optimize the implementation of minusInteger in the integer-gmp package
#12129: Optimize the implementation of minusInteger in the integer-gmp package -------------------------------------+------------------------------------- Reporter: admock | Owner: Type: task | Status: new Priority: normal | Milestone: Component: libraries | Version: 8.0.1 (other) | Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Runtime Unknown/Multiple | performance bug Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- As mentioned in [https://www.fpcomplete.com/blog/2016/05/weigh-package], the current implementation of `minusInteger` is {{{#!hs minusInteger x y = inline plusInteger x (inline negateInteger y) }}} which always allocates an additional integer. This could be improved by not always calling `negateInteger` and instead having an implementation more like `plusInteger`'s. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12129 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12129: Optimize the implementation of minusInteger in the integer-gmp package -------------------------------------+------------------------------------- Reporter: admock | Owner: admock Type: task | Status: new Priority: normal | Milestone: Component: libraries | Version: 8.0.1 (other) | Resolution: | Keywords: integer-gmp Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by hvr): * owner: => admock * keywords: => integer-gmp -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12129#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12129: Optimize the implementation of minusInteger in the integer-gmp package -------------------------------------+------------------------------------- Reporter: admock | Owner: admock Type: task | Status: new Priority: normal | Milestone: Component: libraries | Version: 8.0.1 (other) | Resolution: | Keywords: integer-gmp Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2278 Wiki Page: | -------------------------------------+------------------------------------- Changes (by admock): * differential: => Phab:D2278 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12129#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12129: Optimize the implementation of minusInteger in the integer-gmp package
-------------------------------------+-------------------------------------
Reporter: admock | Owner: admock
Type: task | Status: new
Priority: normal | Milestone:
Component: libraries | Version: 8.0.1
(other) |
Resolution: | Keywords: integer-gmp
Operating System: Unknown/Multiple | Architecture:
Type of failure: Runtime | Unknown/Multiple
performance bug | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D2278
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#12129: Optimize the implementation of minusInteger in the integer-gmp package -------------------------------------+------------------------------------- Reporter: admock | Owner: admock Type: task | Status: new Priority: normal | Milestone: 8.2.1 Component: libraries | Version: 8.0.1 (other) | Resolution: | Keywords: integer-gmp Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2278 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * milestone: => 8.2.1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12129#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#12129: Optimize the implementation of minusInteger in the integer-gmp package -------------------------------------+------------------------------------- Reporter: admock | Owner: admock Type: task | Status: closed Priority: normal | Milestone: 8.2.1 Component: libraries | Version: 8.0.1 (other) | Resolution: fixed | Keywords: integer-gmp Operating System: Unknown/Multiple | Architecture: Type of failure: Runtime | Unknown/Multiple performance bug | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D2278 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/12129#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC