#9184: Allow the use of Python 3 when building GHC -------------------------------+------------------------------------------- Reporter: aspidites | Owner: Type: feature | Status: new request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Description changed by aspidites: Old description:

According to the [https://ghc.haskell.org/trac/ghc/wiki/Building/Preparation/Windows wiki], it is preferred that a user have Python 2.7 installed before attempting to build GHC. As I'm on Arch Linux the default Python version is 3.4. As such, rather than simply changing the shebang line to explicitly ask for version 2, I made it so that the scripts all use syntax that works properly for versions 2.7 to 3.4. I don't think I've used anything that disallows 2.6, but don't have that version available to check against.

New description: According to the [https://ghc.haskell.org/trac/ghc/wiki/Building/Preparation/Windows wiki], it is preferred that a user have Python 2.7 installed before attempting to build GHC. As I'm on Arch Linux the default Python version is 3.4. As such, rather than simply changing the shebang line to explicitly ask for version 2, I made it so that the scripts all use syntax that works properly for versions 2.7 to 3.4. I don't think I've used anything that disallows 2.6, but don't have that version available to check against. I should note that the changes were as minimal as possible. That is, I didn't bother refactoring to use more modern idioms (such as string substitution vs concatenation). As these are helper scripts, I doubt doing so would be much help, but I wouldn't mind doing so upon request. -- -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------+------------------------------------------- Reporter: aspidites | Owner: Type: feature | Status: new request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by aspidites): My mistake. I've corrected this by manually unpacking the tuple. The alternative would have been to unpack the tuple as it was being sent into the lambda, but I figured this way was less disruptive. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------+------------------------------------------- Reporter: aspidites | Owner: Type: feature | Status: new request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 hour) Operating System: | Blocked By: Unknown/Multiple | Related Tickets: Type of failure: | None/Unknown | Test Case: | Blocking: | -------------------------------+------------------------------------------- Comment (by aspidites): Wow. I thought this was more trivial then it apparently is. I'll run the full test suite this weekend under both python 2 and 3 and submit another patch. I might actually just start fresh and see if I can come up with a solution that honors python 2.5 as well (though there are at least two places that are python 2.5 incompatible already). -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: monoidal Type: feature | Status: new request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by monoidal): * owner: => monoidal Comment: I'm refactoring scripts to support Python 3. Not sure if I'll catch all incompatibilities; my goal is at least to successfully execute a failed and passed run under 3, and don't change the behavior over 2. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: monoidal Type: feature | Status: patch request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D233 | -------------------------------------+------------------------------------- Comment (by aspidites): Sorry about the delay. I replied inline while at work, but the email got kicked back because I wasn't signed in. I had this mostly done, but recently fried the motherboard on my home machine. I also was apparently foolish in that while I had changes committed locally, I didn't push them. Sorry about that. What I did find was that forsaking python 2.5 made the necessary changes rather trivial, but in my second stab at it, I was trying to preserve python 2.5 support. While the changes were trivial, there was a lot of mechanical changes that had me chasing my tail. In any case, I'm glad someone else picked up the ball on this, and apologize again for my lack of communication. I seem to be losing track of time in more than one place. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: monoidal Type: feature | Status: patch request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D233 | -------------------------------------+------------------------------------- Comment (by aspidites): Deal. I just set myself an alarm to do this immediately after work tomorrow. (I have a large project due for school this afternoon) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: monoidal Type: feature | Status: patch request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D233 | -------------------------------------+------------------------------------- Comment (by hvr): Replying to [comment:12 aspidites]:

Ugh. Got backlogged with school. I'm reading the phabricator documentation right now though.

TLDR: Just head over to Phab:D233 and look through the code. You can comment inline, and don't forget to submit all inline-comments (otherwise they don't become visible for others) when you're done with the form at the very end of that page. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:13 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: monoidal Type: feature | Status: closed request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: fixed | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D233 | -------------------------------------+------------------------------------- Changes (by monoidal): * status: patch => closed * resolution: => fixed Comment: I consider this done; I marked the support as "experimental" since I'm not absolutely sure if all code is properly covered and the code will be less used then the P2 version, but once it gets traction and no issues arise, I will remove the mark. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:15 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: Type: feature | Status: new request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D233 | -------------------------------------+------------------------------------- Changes (by monoidal): * owner: monoidal => * status: closed => new * resolution: fixed => Comment: I reverted this, since it's likely to have broken the Windows build. I will investigate, but it might take some time since I don't have a Windows build set up. I suspect this is caused by the change to `findTFiles`, which previously joined paths with '/', while I changed it to `os.walk` + `os.path.join`. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:17 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: Type: feature | Status: patch request | Milestone: Priority: normal | Version: 7.8.2 Component: Build | Keywords: python System | Architecture: Unknown/Multiple Resolution: | Difficulty: Easy (less than 1 Operating System: | hour) Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: None/Unknown | Test Case: | Blocking: | Differential Revisions: Phab:D310 | -------------------------------------+------------------------------------- Comment (by Krzysztof Gogolewski ): In [changeset:"d576fc38d9493c4979217fa36565f1f97fcc03d4/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="d576fc38d9493c4979217fa36565f1f97fcc03d4" Python 3 support, second attempt (Trac #9184) Summary: This is a fixup of https://phabricator.haskell.org/D233 The only difference is in findTFiles (first commit), which previously broke Windows runner; now I translated literally instead attempting to improve it, and checked it works. Test Plan: I used validate under 2,3 on Linux and under 2 on msys2. On Windows I've seen a large number of failures, but they don't seem to be connected with the patch. Reviewers: hvr, simonmar, thomie, austin Reviewed By: austin Subscribers: thomie, carter, ezyang, simonmar Differential Revision: https://phabricator.haskell.org/D310 GHC Trac Issues: #9184 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:19 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: Type: feature request | Status: closed Priority: normal | Milestone: Component: Build System | Version: 7.8.2 Resolution: fixed | Keywords: python Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D310 -------------------------------------+------------------------------------- Comment (by Herbert Valerio Riedel ): In [changeset:"32215996528779f71a636350a36c01a8b3ccb1bf/ghc" 32215996/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="32215996528779f71a636350a36c01a8b3ccb1bf" Make testsuite work again with Py3 Python 3 support seems to have mildly bitrotten since #9184 was closed. Luckily, only some minor tweaks seem necessary. }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:21 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

#9184: Allow the use of Python 3 when building GHC -------------------------------------+------------------------------------- Reporter: aspidites | Owner: Type: feature request | Status: closed Priority: normal | Milestone: 8.0.1 Component: Build System | Version: 7.8.2 Resolution: fixed | Keywords: python Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D310 Wiki Page: | -------------------------------------+------------------------------------- Comment (by Ben Gamari ): In [changeset:"7d2df32091dfe94f4da34868a64bea56ca74843e/ghc" 7d2df320/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="7d2df32091dfe94f4da34868a64bea56ca74843e" testsuite/driver: More Unicode awareness Explicitly specify utf8 encoding in a few spots which were failing on Windows with Python 3. Test Plan: Validate Reviewers: austin, thomie Differential Revision: https://phabricator.haskell.org/D2602 GHC Trac Issues: #9184 }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9184#comment:23 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler