[GHC] #9068: Don't uninstall signal handlers if none were installed
#9068: Don't uninstall signal handlers if none were installed --------------------------+------------------------------------------------ Reporter: tomgr | Owner: simonmar Type: bug | Status: new Priority: normal | Milestone: Component: | Version: 7.8.2 Runtime System | Operating System: Windows Keywords: | Type of failure: Incorrect result at runtime Architecture: | Test Case: Unknown/Multiple | Blocking: Difficulty: | Unknown | Blocked By: | Related Tickets: | --------------------------+------------------------------------------------ GHC 7.8.2 calls resetSignalHandlers even when --install-signal-handlers=no is specified. On windows this results in the call to SetConsoleCtrlHandler failing. The attached patch only calls resetSignalHandlers when there are signal handlers to remove (it mirrors the logic used when installing the handlers). -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9068> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9068: Don't uninstall signal handlers if none were installed ------------------------------------------------+-------------------------- Reporter: tomgr | Owner: Type: bug | simonmar Priority: normal | Status: new Component: Runtime System | Milestone: Resolution: | Version: 7.8.2 Operating System: Windows | Keywords: Type of failure: Incorrect result at runtime | Architecture: Test Case: | Unknown/Multiple Blocking: | Difficulty: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Comment (by Simon Marlow <marlowsd@…>): In [changeset:"bc7d49a658a516679cc264502e72560c1d2c2314/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="bc7d49a658a516679cc264502e72560c1d2c2314" Only uninstall signal handlers if they were actually installed (#9068) Submitted by: tomgr }}} -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9068#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9068: Don't uninstall signal handlers if none were installed ------------------------------------------------+-------------------------- Reporter: tomgr | Owner: Type: bug | simonmar Priority: normal | Status: merge Component: Runtime System | Milestone: 7.8.3 Resolution: | Version: 7.8.2 Operating System: Windows | Keywords: Type of failure: Incorrect result at runtime | Architecture: Test Case: | Unknown/Multiple Blocking: | Difficulty: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Changes (by simonmar): * status: new => merge * milestone: => 7.8.3 -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9068#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#9068: Don't uninstall signal handlers if none were installed ------------------------------------------------+-------------------------- Reporter: tomgr | Owner: Type: bug | simonmar Priority: normal | Status: closed Component: Runtime System | Milestone: 7.8.3 Resolution: fixed | Version: 7.8.2 Operating System: Windows | Keywords: Type of failure: Incorrect result at runtime | Architecture: Test Case: | Unknown/Multiple Blocking: | Difficulty: | Unknown | Blocked By: | Related Tickets: ------------------------------------------------+-------------------------- Changes (by thoughtpolice): * status: merge => closed * resolution: => fixed Comment: Merged, thanks! -- Ticket URL: <http://ghc.haskell.org/trac/ghc/ticket/9068#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC