[GHC] #9594: Cleanup of filepath package
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: new Priority: normal | Milestone: Component: libraries (other) | Version: 7.9 Keywords: filepath | Operating System: Architecture: Unknown/Multiple | Unknown/Multiple Difficulty: Unknown | Type of failure: Blocked By: | None/Unknown Related Tickets: #8752 | Test Case: | Blocking: | Differential Revisions: -------------------------------------+------------------------------------- I did a general cleanup/refactoring of the filepath package. Notable changes: * 10% less code * 2 tiny bug fixes * a few extra tests * some more documentation The commits are in my [https://github.com/thomie/filepath/commits/cleanup cleanup branch] on Github. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: libraries | Version: 7.9 (other) | Keywords: filepath Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by thomie): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: patch Priority: normal | Milestone: Component: libraries | Version: 7.9 (other) | Keywords: filepath Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by hvr): please feel free to submit that as a pull-request to the `haskell/filepath` (even though it says "dont use yet") so we can start code-reviewing :-) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: upstream Priority: normal | Milestone: Component: Core | Version: 7.9 Libraries | Keywords: filepath Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by hvr): * cc: core-libraries-committee@… (added) * status: patch => upstream Comment: This is being handled upstream over at https://github.com/haskell/filepath/pull/1 now -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: upstream Priority: normal | Milestone: Component: Core | Version: 7.9 Libraries | Keywords: filepath Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by NeilMitchell): I see no reason to keep this ticket here - I suggest we close it and deal with it exclusively on GitHub. It's not really of any interest to GHC. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: upstream Priority: normal | Milestone: Component: Core | Version: 7.9 Libraries | Keywords: filepath Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by hvr): The only thing I think may be of interest to GHC's release-plans is to have those "2 tiny bug fixes" available by the time GHC 7.10.1 gets released. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: upstream Priority: normal | Milestone: Component: Core | Version: 7.9 Libraries | Keywords: filepath Resolution: | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Comment (by NeilMitchell): The two tiny bug fixes are fairly minor in nature (shipping GHC 7.10.1 without them wouldn't be the end of the world) and they should be fixed within a week or so.[[Image()]] -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9594: Cleanup of filepath package -------------------------------------+------------------------------------- Reporter: thomie | Owner: Type: task | Status: closed Priority: normal | Milestone: Component: Core | Version: 7.9 Libraries | Keywords: filepath Resolution: fixed | Architecture: Unknown/Multiple Operating System: | Difficulty: Unknown Unknown/Multiple | Blocked By: Type of failure: | Related Tickets: #8752 None/Unknown | Test Case: | Blocking: | Differential Revisions: | -------------------------------------+------------------------------------- Changes (by thomie): * status: upstream => closed * resolution: => fixed Comment: The filepath submodule in GHC HEAD will have all the fixes once Phab:D414 is landed. We need to update it again once a formal release of filepath is made, but closing this here. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9594#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC