[GHC] #8170: Remove _scc_

newer
[GHC] #8492: Exception: expectJust...

older
[GHC] #8139: ghc 7.6.3 fails to...

GHC

24 Aug 2013 24 Aug '13

2:55 p.m.

#8170: Remove _scc_ ------------------------------------+------------------------------------- Reporter: monoidal | Owner: Type: bug | Status: new Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: Other Difficulty: Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | ------------------------------------+------------------------------------- _scc_ is an ancient way of writing {-# SCC #-} pragmas. The old pragmas were discouraged in 2001 ([http://www.haskell.org/ghc/docs/5.00/set/release-5-00.html GHC 5.0]) and officialy deprecated in 2007 ([http://www.haskell.org/ghc/docs/6.8.3/html/users_guide/release-6-8-1.html GHC 6.8]). I downloaded the archive of the latest versions of packages in Hackage; there are over 1000 occurrences of {-# SCC #-} and 0 occurrences of _scc_. Patch attached. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

Show replies by date

GHC

24 Aug 24 Aug

2:57 p.m.

GHC

27 Aug 27 Aug

8:52 a.m.

GHC

28 Aug 28 Aug

9:52 p.m.

GHC

29 Aug 29 Aug

7:35 a.m.

GHC

4:21 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by thoughtpolice): No, of course. I just wanted to note it here since I put it aside while merging patches last night and wanted to keep track of why. I'll step through this again sometime tonight and get it cleaned up. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

3 Sep 3 Sep

7:41 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by monoidal): Sorry about that; I didn't think about nofib. _scc_ occurs in 4 files; only one is not bitrotten, and it's a Happy file (no actual pragma, only its parsing). If you want to minimize work, I would not do anything with nofib. Alternative: I attached a 1MB patch file that removes the pragma in the files. It's so huge because nofib keeps a corresponding .hs file for .y file, and a single change there has many consequences. Either way, please don't lose too much time on this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:6 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

5 Oct 5 Oct

8:47 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by Krzysztof Gogolewski ): In [changeset:3e0109b302bbd9f849d71cbc3efcc905d5271e4e/ghc]: {{{ #!CommitTicketReference repository="ghc" revision="3e0109b302bbd9f849d71cbc3efcc905d5271e4e" Remove deprecated _scc_ (#8170) }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

8:47 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by Krzysztof Gogolewski ): In [changeset:d7b4529a141716c7f9c375d0a5b46349e5634e0b/testsuite]: {{{ #!CommitTicketReference repository="testsuite" revision="d7b4529a141716c7f9c375d0a5b46349e5634e0b" Change deprecated _scc_ to {-# SCC #-} (#8170) }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:8 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

8:52 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: patch Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by Krzysztof Gogolewski ): In [changeset:b9d8bcdd929d664539843f96e56b50800f623891/nofib]: {{{ #!CommitTicketReference repository="nofib" revision="b9d8bcdd929d664539843f96e56b50800f623891" Remove deprecated _scc_ (#8170) }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:9 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

8:56 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Changes (by monoidal): * status: patch => closed * resolution: => fixed Comment: I've applied the changes, except for the megapatch to one happy-generated file which seemed pointless. (Austin consented to me finishing the ticket.) -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:10 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

GHC

1 Nov 1 Nov

12:21 p.m.

#8170: Remove _scc_ -------------------------------------+------------------------------------ Reporter: monoidal | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Compiler | Version: 7.6.3 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Other | Difficulty: Unknown Test Case: | Blocked By: Blocking: | Related Tickets: -------------------------------------+------------------------------------ Comment (by Krzysztof Gogolewski ): In [changeset:"61c855803f9d4319e2394e151ddd46089192d84a/ghc"]: {{{ #!CommitTicketReference repository="ghc" revision="61c855803f9d4319e2394e151ddd46089192d84a" Remove remains of _scc_ (#8170) }}} -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/8170#comment:11 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler

4265

Age (days ago)

4334

Last active (days ago)

List overview

Download

11 comments

1 participants

[GHC] #8170: Remove _scc_

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

GHC

tags

participants (1)