[GHC] #15291: Incorrect SCC name parsing according to user manual
#15291: Incorrect SCC name parsing according to user manual -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.5 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- The user manual says this about SCC names:
The syntax of a cost centre annotation for expressions is
{-# SCC "name" #-} <expression>
where "name" is an arbitrary string, that will become the name of your cost centre as it appears in the profiling output, and <expression> is any Haskell expression.
However GHC is actually more strict about SCC strings, for example, it doesn't accept spaces: {{{ $ cat test.hs main = {-# SCC "test test" #-} return () $ ghc test.hs [1 of 1] Compiling Main ( test.hs, test.o ) test.hs:1:16: error: Spaces are not allowed in SCCs | 1 | main = {-# SCC "test test" #-} return () | ^^^^^^^^^^^ }}} It's also possible that GHC is right and user manual is wrong. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15291 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15291: Incorrect SCC name parsing according to user manual -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): FWIW, here's a 10-years-old program that uses SCC names with spaces: https://github.com/haskell/bytestring/blob/master/tests/Bench.hs It seems like GHC used to accept this. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15291#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15291: Incorrect SCC name parsing according to user manual -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #2071 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by sighingnow): * related: => #2071 Comment: The restriction was add 10 years ago to fix #2071. See: https://github.com/ghc/ghc/commit/82a7cebaea5dce16fc9658cc6a5ec037348075d1 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15291#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15291: Incorrect SCC name parsing according to user manual -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #2071 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): Nice find. I wonder if hp2ps still doesn't handle spaces. May worth checking. Easiest fix is to update the user manual although I wonder if we should spend some time to actually fix hp2ps. Not sure how hard that would be. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15291#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#15291: Incorrect SCC name parsing according to user manual -------------------------------------+------------------------------------- Reporter: osa1 | Owner: (none) Type: bug | Status: new Priority: normal | Milestone: 8.6.1 Component: Compiler | Version: 8.5 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #2071 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by osa1): There's also an alternative to hp2ps now: http://hackage.haskell.org/package/hp2pretty perhaps it accepts spaces in identifiers. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/15291#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC