[GHC] #11057: toIfaceIdDetails trace statement catches PatSynBuilder
#11057: toIfaceIdDetails trace statement catches PatSynBuilder -------------------------------------+------------------------------------- Reporter: bgamari | Owner: Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: Incorrect Unknown/Multiple | warning at compile-time Test Case: | Blocked By: Blocking: | Related Tickets: Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- hvr reported this `pprTrace` message showing up during a GHC build, {{{ [ 73 of 212] Compiling GHC.Exception ( GHC/Exception.hs, dist/build/GHC/Exception.o ) toIfaceIdDetails [PatSynBuilder] }}} I believe this is due to mpickering's Phab:D1152, which introduced the `PatSynBuilder` constructor without handling it in `toIfaceIdDetails`. Given that things appear to work, I would guess we want to handle it with, {{{ toIfaceIdDetails PatSynBuilder = IfVanillaId }}} but I'm not certain. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11057 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11057: toIfaceIdDetails trace statement catches PatSynBuilder -------------------------------------+------------------------------------- Reporter: bgamari | Owner: mpickering Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by simonpj): * owner: => mpickering * cc: mpickering (added) Comment: Yes, that is wrong. `PatSynBuilder` is not making it through interface files. But it's a pain having to track the fact that an Id is in fact a `PatSynBuilderId`. And it's only done for one extremely narrow purpose: to service `idConLike` which in turn is only called in `dsExpr` for `RecordCon`. We should not use `IdDetails` for such a narrow reason. Let's remove it from `IdDetails` altogether, and get the info from the type checker to the desugarer some other way. What we want is for the post-typecheck `RecordCon` to carry `ConLike`, which `tcExpr (RecordCon ...)` has in its sticky paw. To do this we either need a `PostTc ConLike` field, or a new data constructor `RecordConOut`. (Compare `ConPatIn` and `ConPatOut` in `HsPat`; the latter has a `ConLike`.) Matthew would you like to look at this? Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11057#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11057: toIfaceIdDetails trace statement catches PatSynBuilder -------------------------------------+------------------------------------- Reporter: bgamari | Owner: mpickering Type: bug | Status: new Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by mpickering): Yes. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11057#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11057: toIfaceIdDetails trace statement catches PatSynBuilder -------------------------------------+------------------------------------- Reporter: bgamari | Owner: mpickering Type: bug | Status: patch Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1443 Wiki Page: | -------------------------------------+------------------------------------- Changes (by mpickering): * status: new => patch * differential: => Phab:D1443 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11057#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#11057: toIfaceIdDetails trace statement catches PatSynBuilder
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner: mpickering
Type: bug | Status: patch
Priority: normal | Milestone: 8.0.1
Component: Compiler | Version: 7.11
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
Type of failure: Incorrect | Unknown/Multiple
warning at compile-time | Test Case:
Blocked By: | Blocking:
Related Tickets: | Differential Rev(s): Phab:D1443
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Matthew Pickering
#11057: toIfaceIdDetails trace statement catches PatSynBuilder -------------------------------------+------------------------------------- Reporter: bgamari | Owner: mpickering Type: bug | Status: closed Priority: normal | Milestone: 8.0.1 Component: Compiler | Version: 7.11 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Type of failure: Incorrect | Unknown/Multiple warning at compile-time | Test Case: Blocked By: | Blocking: Related Tickets: | Differential Rev(s): Phab:D1443 Wiki Page: | -------------------------------------+------------------------------------- Changes (by mpickering): * status: patch => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/11057#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC