[GHC] #7577: ./sync-all doesn't properly detect the existence of the 'time' submodule
#7577: ./sync-all doesn't properly detect the existence of the 'time' submodule -----------------------------+---------------------------------------------- Reporter: parcs | Owner: Type: bug | Status: new Priority: normal | Component: Build System Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Other | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- The `time` submodule is present in my repository (at `./libraries/time`) but some `./sync-all` operations, like `./sync-all fetch`, don't seem to detect its presence: Output from `./sync-all get`: {{{ ... Submodule 'libraries/time' () registered for path 'libraries/time' ... == Checking for old time from tarball }}} Output from a subsequent `./sync-all fetch`: {{{ ... == libraries/time repo not present; skipping ... }}} `./sync-all fetch` thinks that the `time` repo is not present and thus doesn't pull in any updates for it. ---- This issue is similar to the one which 31d771bec93b17813b03e7a72a586e1f401ef240 fixes. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7577> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7577: ./sync-all doesn't properly detect the existence of the 'time' submodule -----------------------------+---------------------------------------------- Reporter: parcs | Owner: Type: bug | Status: patch Priority: normal | Component: Build System Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Other | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- Changes (by parcs): * status: new => patch -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7577#comment:1> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7577: ./sync-all doesn't properly detect the existence of the 'time' submodule -----------------------------+---------------------------------------------- Reporter: parcs | Owner: Type: bug | Status: patch Priority: normal | Component: Build System Version: 7.7 | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Other | Blockedby: Blocking: | Related: -----------------------------+---------------------------------------------- Comment(by patrick@…): commit 146b0eafa17f0ac28f7ef3f273919c4c6a22f45b {{{ Author: Patrick Palka <patrick@parcs.ath.cx> Date: Sun Jan 13 12:02:10 2013 -0500 use -e rather than -d when checking for the existence of a subrepo The .git file in a submodule's root directory is not necessarily a directory, as is the case for the 'time' submodule. This fixes #7577, where some './sync-all' operations don't detect that the 'time' submodule is present in the repository. sync-all | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) }}} -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7577#comment:2> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
#7577: ./sync-all doesn't properly detect the existence of the 'time' submodule -------------------------------+-------------------------------------------- Reporter: parcs | Owner: Type: bug | Status: closed Priority: normal | Milestone: Component: Build System | Version: 7.7 Resolution: fixed | Keywords: Os: Unknown/Multiple | Architecture: Unknown/Multiple Failure: Other | Difficulty: Unknown Testcase: | Blockedby: Blocking: | Related: -------------------------------+-------------------------------------------- Changes (by igloo): * status: patch => closed * difficulty: => Unknown * resolution: => fixed Comment: Thanks for the patch; applied. -- Ticket URL: <http://hackage.haskell.org/trac/ghc/ticket/7577#comment:3> GHC <http://www.haskell.org/ghc/> The Glasgow Haskell Compiler
participants (1)
-
GHC