[GHC] #13979: Don't use gtar to produce FreeBSD binary distribution
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: (none) Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Keywords: | Operating System: Unknown/Multiple Architecture: | Type of failure: None/Unknown Unknown/Multiple | Test Case: | Blocked By: Blocking: | Related Tickets: #13974 Differential Rev(s): | Wiki Page: -------------------------------------+------------------------------------- Mentioned in #13974. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #13974 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * owner: (none) => bgamari -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: task | Status: new Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #13974 | Differential Rev(s): Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): I think actually just passing `--format=posix` will be sufficient. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: task | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #13974 | Differential Rev(s): Phab:D3765 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: new => patch * differential: => Phab:D3765 -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: task | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #13974 | Differential Rev(s): Phab:D3765 Wiki Page: | -------------------------------------+------------------------------------- Comment (by bgamari): Ahh, never mind. It has little to do with the tar file format. Rather, the files which failed in ticket:13974#comment:5 are all included multiple times in the bindist. For instance, {{{ $ tar -vtf ghc-8.3.20170720-x86_64-unknown-linux.tar.xz ... -rwxr-xr-x 0 ben ben 54184 Jul 20 20:45 ghc-8.3.20170720/utils/hp2ps/dist-install/build/tmp/hp2ps hrwxr-xr-x 0 ben ben 0 Jul 20 20:45 ghc-8.3.20170720/utils/hp2ps/dist-install/build/tmp/hp2ps link to ghc-8.3.20170720/utils/hp2ps/dist-install/build/tmp/hp2ps }}} This is no doubt due to a build system bug. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: task | Status: patch Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #13974 | Differential Rev(s): Phab:D3767 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * differential: Phab:D3765 => Phab:D3767 Comment: Alright Make, you win. I spent a half an hour trying to work out where these duplicates were coming from. It seems like the `ifeq`s in `rules/build-prog.mk` aren't quite doing what we expect. Given that Hadrian is right around the corner I'm not terribly keen on sinking a bunch of time into this. Consequently, I propose the hack in Phab:D3767. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979#comment:5 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#13979: Don't use gtar to produce FreeBSD binary distribution
-------------------------------------+-------------------------------------
Reporter: bgamari | Owner: bgamari
Type: task | Status: patch
Priority: highest | Milestone: 8.2.1
Component: Compiler | Version: 8.0.1
Resolution: | Keywords:
Operating System: Unknown/Multiple | Architecture:
| Unknown/Multiple
Type of failure: None/Unknown | Test Case:
Blocked By: | Blocking:
Related Tickets: #13974 | Differential Rev(s): Phab:D3767
Wiki Page: |
-------------------------------------+-------------------------------------
Comment (by Ben Gamari
#13979: Don't use gtar to produce FreeBSD binary distribution -------------------------------------+------------------------------------- Reporter: bgamari | Owner: bgamari Type: task | Status: closed Priority: highest | Milestone: 8.2.1 Component: Compiler | Version: 8.0.1 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: | Unknown/Multiple Type of failure: None/Unknown | Test Case: Blocked By: | Blocking: Related Tickets: #13974 | Differential Rev(s): Phab:D3767 Wiki Page: | -------------------------------------+------------------------------------- Changes (by bgamari): * status: patch => closed * resolution: => fixed Comment: The fix in comment:6 is really a workaround, but it's as close as we'll likely get with the Make-based build system. Merged to `ghc-8.2` with 96ce53866496b72a3eb34ee13a2a9c5392c29fcb. -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/13979#comment:7 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC