[GHC] #9039: Annotation reification from TH is not looking into HPT
#9039: Annotation reification from TH is not looking into HPT -------------------------------------+------------------------------------- Reporter: errge | Owner: Type: bug | Status: new Priority: normal | Milestone: 7.8.3 Component: Template Haskell | Version: 7.8.2 Keywords: | Operating System: Unknown/Multiple Architecture: Unknown/Multiple | Type of failure: Incorrect result Difficulty: Moderate (less | at runtime than a day) | Test Case: annth_make Blocked By: | annth_compunits Related Tickets: | Blocking: -------------------------------------+------------------------------------- The annotation reification code only looks into EPS and TCG while trying to find annotations. Unfortunately it forgets HPT, where the annotations for the currently compiling (via --make) package are. The attached patch fixes this issue. Also, I added some test cases that I should have done a long time ago. Sorry for the oversight :( -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9039 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9039: Annotation reification from TH is not looking into HPT -------------------------------------+------------------------------------- Reporter: errge | Owner: Type: bug | Status: patch Priority: normal | Milestone: 7.8.3 Component: Template Haskell | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Incorrect result | Difficulty: Moderate (less at runtime | than a day) Test Case: annth_make | Blocked By: annth_compunits | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by errge): * status: new => patch -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9039#comment:1 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9039: Annotation reification from TH is not looking into HPT -------------------------------------+------------------------------------- Reporter: errge | Owner: Type: bug | Status: patch Priority: normal | Milestone: 7.8.3 Component: Template Haskell | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Incorrect result | Difficulty: Moderate (less at runtime | than a day) Test Case: annth_make | Blocked By: annth_compunits | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Comment (by simonpj): Austin could you commit this please? And merge to the 7.8 branch, I guess. Thanks Gergo! Simon -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9039#comment:2 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9039: Annotation reification from TH is not looking into HPT -------------------------------------+------------------------------------- Reporter: errge | Owner: Type: bug | Status: merge Priority: normal | Milestone: 7.8.3 Component: Template Haskell | Version: 7.8.2 Resolution: | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Incorrect result | Difficulty: Moderate (less at runtime | than a day) Test Case: annth_make | Blocked By: annth_compunits | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: patch => merge -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9039#comment:3 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
#9039: Annotation reification from TH is not looking into HPT -------------------------------------+------------------------------------- Reporter: errge | Owner: Type: bug | Status: closed Priority: normal | Milestone: 7.8.3 Component: Template Haskell | Version: 7.8.2 Resolution: fixed | Keywords: Operating System: Unknown/Multiple | Architecture: Unknown/Multiple Type of failure: Incorrect result | Difficulty: Moderate (less at runtime | than a day) Test Case: annth_make | Blocked By: annth_compunits | Related Tickets: Blocking: | -------------------------------------+------------------------------------- Changes (by thoughtpolice): * status: merge => closed * resolution: => fixed -- Ticket URL: http://ghc.haskell.org/trac/ghc/ticket/9039#comment:4 GHC http://www.haskell.org/ghc/ The Glasgow Haskell Compiler
participants (1)
-
GHC